Repository navigation
[release/2.15] Skip FSDP overlap tests on ROCm >= 10.1 (#196753) - #3882
Merged
pragupta merged 1 commit intoOct 27, 2026
Merged
Conversation
Partial cherry-pick of c489527 ("[ROCm] Bump trunk ROCm version to 10.1"): only the test/distributed/_composable/fsdp/test_fully_shard_overlap.py hunk. ROCm 10.1 removes high priority queue, which reduces the total number of queues from 8 (4 high + 4 normal) to 4 (4 normal), causing some streams can't overlap. (cherry picked from commit c489527) Co-authored-by: Cursor <cursoragent@cursor.com>
pragupta
deleted the
albmalamd/cherry-pick/2.15/196753-rocm-10.1-rc-bump
branch
October 27, 2026 13:59
jithunnair-amd
pushed a commit
that referenced
this pull request
Nov 4, 2026
… (#3882) Partial cherry-pick of c489527 ("[ROCm] Bump trunk ROCm version to 10.1"): only the test/distributed/_composable/fsdp/test_fully_shard_overlap.py hunk. ROCm 10.1 removes high priority queue, which reduces the total number of queues from 8 (4 high + 4 normal) to 4 (4 normal), causing some streams can't overlap. (cherry picked from commit c489527) Co-authored-by: Z Liu <zhuojin.liu@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial cherry-pick of c489527 ("[ROCm] Bump trunk ROCm version to 10.1"): only the test/distributed/_composable/fsdp/test_fully_shard_overlap.py hunk.
ROCm 10.1 removes high priority queue, which reduces the total number of queues from 8 (4 high + 4 normal) to 4 (4 normal), causing some streams can't overlap.
(cherry picked from commit c489527)