You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
format_bytes_for_user prints KB/MB/GB for base-1024 math #190
format_bytes_for_user (apps/rocm/src/main.rs) divides by 1024 but labels the result KB, MB, GB. The units say base 1000; the arithmetic is base 1024, so every figure it prints is mislabelled.
format_bytes, used by rocm storage, does the same arithmetic and prints KiB, MiB, GiB. Two size formatters with the same maths and different units now both appear in user-facing output.
Suggested direction
Pick one and use it everywhere: either correct the units on format_bytes_for_user to the Ki/Mi/Gi forms, or make it genuinely base 1000. Then collapse the two functions so there is a single size formatter.
Context
Out of scope for #172, which only made format_bytes live and fixed its rounding at unit boundaries. format_bytes_for_user reaches unrelated call sites, so changing its output belongs in its own change. Raised from review feedback on that PR.
Activity
fix: give the automations proposal line real KiB/MiB/GiB units (ROCm#671
test(e2e-cucumber): add regression coverage for the gpu_compact_line …
test(e2e-cucumber): add regression coverage for the gpu_compact_line …
test(e2e-cucumber): add regression coverage for the gpu_compact_line …
fix(rocm-dash-tui): label gpu_compact_line VRAM as GiB, not GB (ROCm#699