You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
diagnose: a line reading "blacklistamdgpu" is treated as blacklisting amdgpu #506
line_blacklists_amdgpu strips the blacklist prefix and then trims leading whitespace, so it never requires any whitespace between the directive and the module name:
line_blacklists_amdgpu("blacklistamdgpu") -> true
modprobe does not treat that line as a directive, so nothing is blacklisted — but rocm diagnose reports amdgpu_blacklisted_in for that file.
Expected behavior
Matches the contract the function's own doc comment states, ^\s*blacklist\s+amdgpu\b, where \s+ requires at least one whitespace character.
Steps to reproduce
Put a line reading exactly blacklistamdgpu in a file under /etc/modprobe.d/ and run rocm diagnose.
Consequence
The diagnosis points at a non-cause. A user is told to un-blacklist a module that was never blacklisted, while whatever actually prevented the driver loading goes unreported.
Possible solution
Require whitespace after the directive. The doc comment one line above already states the intended grammar; the code is the side that disagrees.
Environment
Built from main. Pure text parsing, platform-independent.
Additional context
Found by property-testing the modprobe grammar — the property asserted that a line only reports a blacklist when it matches the documented shape. Pre-existing; unrelated to any in-flight change, which is why it is filed separately rather than folded into one.
Activity
test(examine): property-test the driver-side text readers (ROCm#558)
docs(testing): state when a known-gap reproducer may be committed ign…
docs(testing): make `known gap:` the one prefix for defect reproducers
docs(testing): state when a known-gap reproducer may be committed ign…
docs(testing): make `known gap:` the one prefix for defect reproducers
docs(testing): state when a known-gap reproducer may be committed ign…
docs(testing): make `known gap:` the one prefix for defect reproducers
test: property-test --gpu selection and the SSE line emitters (ROCMAI…