Skip to content

examine: lspci cannot name a GPU that pci.ids does not know, though the device id is on the line #507

Open

Description

@rominf

Current behavior

Every lspci -nn line carries the vendor:device id in brackets, e.g.

c5:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Raphael [1002:164e] (rev cb)

When the host's pci.ids database has no entry for the device, lspci prints the bare word Device in place of the name. Classification then has nothing to work with and the GPU resolves to no target — even though [1002:xxxx] is right there on the same line and the crate already has a device-id decoder.

Expected behavior

The device id is preferred over the marketing name, as it is on the Windows probe path, which reads the id out of the PNP id.

Steps to reproduce

On a host whose pci.ids predates the GPU — the reported case is Strix Halo, see #449 — run rocm examine --json and observe an empty gfx_target.

Status

The reader half is now in place: extract_lspci_device_id pulls [1002:xxxx] from the line (AMD vendor only, so the [0300] class tag cannot be mistaken for a device id) and is preferred over the name. What is missing is table coverage: gfx_target_from_amd_pci_device_id has no entry for

These were deliberately not added without hardware to confirm them: guessing numeric ids into a public hardware table is worse than a documented gap. Anyone with the part can verify the id from lspci -nn and add the row.

Environment

  • Linux. The equivalent Windows path already reads the device id.

Additional context

Related to #449, which reports the user-visible symptom on Strix Halo. This issue covers the mechanism and what remains to close it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions