You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
uninstall: remove a directory symlink or junction root on Windows with remove_dir #560
On Windows, remove_path (used by rocm uninstall and rocm storage remove-downloads) calls remove_file on any symlink. A directory symlink or junction needs RemoveDirectory, so a config, data or cache folder that is a directory link may fail to uninstall. This is untested; no Windows lane covers it.
Expected behavior
A directory symlink or junction root is unlinked, never followed, whether or not it is written with a trailing \.
Possible solution
On Windows, when FileTypeExt::is_symlink_dir() is true (junctions included), call fs::remove_dir, which removes the link without following it. Add a Windows-lane test that covers:
Activity