You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
e2e-report: Expectation grid column headers use raw platform_slug instead of the canonical platform label #702
While verifying the #640 refactor (PR #701) with a CLI Journey review of cargo xtask e2e-report, found that the Expectation grid section's column header is built from the raw platform.jsonplatform_slug field, while every other section of the same consolidated report (summary matrix, command-coverage table, per-platform details) uses the canonical, artifact-directory-derived platform label. The same platform can therefore show under two different identities within one report — e.g. mi300x in the grid versus MI300X everywhere else.
Confirmed with a two-platform fixture (e2e-report, a manifest-less Mock-shaped directory; e2e-gpu-report, a directory with platform.json + commands.jsonl): the grid's single column was headed with the raw slug value, while the summary matrix, command-coverage table, and per-platform details all consistently used the canonical label for the same platform. Re-running with platform_slug changed to an arbitrary string made the grid header track that string exactly, confirming the header is driven verbatim by the raw field rather than the canonical label.
A second, related issue: the Expectation grid only includes a column for platforms whose platform.json declares an expectations array — other platforms, which are present and fully reported everywhere else, are silently absent from the grid with no caption explaining the narrower scope.
Where
Grid::build/GridColumn::label in crates/e2e-report/src/consolidated.rs reads manifest.platform_slug directly, instead of the canonical label the other sections already derive from the artifact directory name (parse_descriptor → e.g. platform_cell/PlatformReport::label).
Proposed direction
Make the Expectation grid's column header read the same canonical, directory-derived platform label the summary matrix, command-coverage table, and per-platform details already use, instead of the raw manifest platform_slug.
Either include a column for every platform present in the report — even one with no platform.json/expectations, shown with an explicit "no expectations declared" marker — or add a caption stating which platforms were excluded from the grid and why.
Not a regression
Confirmed via diff that Grid::build/GridColumn — where this lives — was not touched by #640/#701; this is pre-existing behavior, just surfaced while verifying that PR.
Activity
fix(e2e-report): use canonical platform label in expectation grid
e2e-report: use canonical platform label in expectation grid (ROCm#706)