Skip to content

dash: add an Esc-menu route to the warnings popup (the ! key is the only keyboard path) #795

Open

Description

@jussielo-amd

Is your feature request related to a problem? Please describe.
The dashboard's header warning badge (⚠ N (!)) opens a popup with the warning text. Today the only keyboard route to that popup is the ! key (the badge can also be clicked). On many non-US keyboard layouts ! needs Shift or a modifier combination, and nothing else in the keyboard-driven UI leads there, so a keyboard-only user has no discoverable path other than the (!) hint on the badge and the help overlay's key list.

This was noted as a non-blocking follow-up while reviewing #793, which made the warning text readable (#286).

Describe the solution you'd like
Add a "Warnings" row to the Esc menu, shown only while a snapshot reports at least one warning, so the popup can be reached with the same arrow/Enter navigation as the other rows. It should dispatch the existing open-warnings action and respect the same gate as the ! key and the badge click, so it never opens over another modal or a pending prompt.

Describe alternatives you've considered

  • A second, layout-friendly key binding for the popup. Cheaper, but it spends another global hotkey and still has to be discovered.
  • Leaving ! as the only key. Acceptable for now, but keyboard-only users on layouts where ! is awkward get a worse experience than mouse users.

Additional context
Once a menu row exists, the dash-38 end-to-end scenario could also cover reaching the popup through the menu, which today is only exercised through !.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions