You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
dashboard: bench-run overlay starts rocm bench load without approval and opens no job console #969
The dashboard's bench-run overlay starts rocm bench load as soon as the form is submitted, with no approval step, and then closes the form without opening a job console. Both look unintended. I found this while reading the code for #965; I have not reproduced it in a running dashboard.
What the code does
In crates/rocm-dash-tui/src/ui/bench_run.rs, try_submit builds the rocm bench load --endpoint ... argv and applies StateEvent::StartJob with the job id bench-run directly. It then sets the overlay state to None, with the comment "the job console is shown by the job-bridge".
Two things do not match that:
No approval. Every other overlay that runs a command which changes state stages an ApprovalRequest first, and ui/command_screen.rs gates every command behind one. The header of bench_run.rs says it "mirrors the command-screen pattern", but it does not. rocm bench load sends request load to an endpoint and appends rows to a CSV file, so it is not read-only. (The read-only overlays, logs_view.rs and examine_manager.rs, start their jobs directly, which is reasonable for them.)
No console.AppState::active_job_id in crates/rocm-dash-tui/src/app/overlays.rs checks each manager's active_job in turn, and bench_run has no arm. Closing the overlay means nothing selects the bench-run job for the shared job console. On a wide terminal (at least 180 x 45) the logs dock lists the output of every job, and rows appear in the Bench panel if the output path is the daemon-tailed CSV. Otherwise I could not find where a failed run, such as an unreachable endpoint, would be shown.
Questions for whoever picks this up
Should bench-run go through the approval gate like the other state-changing overlays? If load generation against an arbitrary endpoint is meant to be one keystroke, the header comment and the module docs should say why it differs.
Should the overlay keep the form open and show the shared job console once the job starts, as the other managers do, so output and failure are visible?
Acceptance
Whichever way question 1 goes, a test covers it: either that submitting stages an approval and starts nothing until it is approved, or that it deliberately does not and why. A test also shows that after the job starts, its output is reachable from the dashboard without a wide terminal.
Activity