Skip to content

Hardware panel shows disk and network throughput that the host collector never collects #971

Open

Description

@jussielo-amd

Summary

The Hardware panel renders a disk and network throughput row, but the host collector that feeds it hard-codes all four values to zero. On a live dashboard the row therefore always reads as zero throughput, which looks like a measurement and is not one.

What the code does

  • crates/rocm-dash-collectors/src/host.rs: HostCollector fills SystemMetrics with CPU, memory and swap from sysinfo, and sets disk_read_bps, disk_write_bps, net_rx_bps and net_tx_bps to 0, under the comment TODO: wire sysinfo::Disks / sysinfo::Networks for I/O deltas.
  • crates/rocm-dash-tui/src/ui/tabs/hardware.rs: draw_io_row renders those four fields as "read", "write", "rx" and "tx", and its doc comment says they "are collected by the host sampler".
  • Both the daemon (runner.rs) and the Windows in-process path (rocm-dash-tui's client.rs) use HostCollector, and winperf.rs does not provide these fields either, so no live path produces a non-zero value. Only the synthetic demo session does.

I read this from the code and have not checked what the panel looks like on screen.

Options

  1. Implement the TODO: sample sysinfo::Disks and sysinfo::Networks and report the delta per second, taking care over the first sample (as the constructor already does for CPU) and over counters that reset.
  2. Until then, make the missing data visible: show a placeholder instead of 0 B/s, as the Home tab already does for missing telemetry, or hide the row.

Whichever is chosen, the doc comment on draw_io_row should stop claiming the values are collected, and a test should pin what a snapshot with no I/O data renders as, not only that a populated snapshot renders its numbers.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions