Skip to content

Pin Rust toolchain to 1.96.0 - #12

Merged
rominf merged 1 commit into
mainfrom
pin-rust-toolchain
Jun 16, 2026
Merged

rominf merged 1 commit into
mainfrom
pin-rust-toolchain

Conversation

@rominf

@rominf rominf commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

Pins the Rust toolchain to 1.96.0 for reproducible builds. Previously builds floated on the latest stable, so a new stable release could silently change CI behavior. 1.96.0 also carries security fixes (CVE-2026-33055 / CVE-2026-33056 via Cargo's tar bump).

The version lives in one place — rust-toolchain.toml — and every environment defers to it:

Environment Setup Source of version
GitHub-hosted runners (CI ×5, Windows nightly/release) actions-rust-lang/setup-rust-toolchain@v1 reads rust-toolchain.toml
manylinux Docker (Linux nightly/release) rustup --default-toolchain none → cargo rustup auto-installs the pinned channel from the file

To bump Rust in future, edit one line in rust-toolchain.toml.

Incidental cleanups

  • Dropped the manual actions/cache blocks — setup-rust-toolchain bundles Swatinem/rust-cache with more precise keys.
  • Dropped with: components: on the fmt/clippy jobs — components now come from the toolchain file.

MSRV

Aligned rust-version (1.88 → 1.96). This is an application shipping prebuilt binaries built with the pinned toolchain, so the supported version tracks the toolchain we actually build with rather than an unverified older floor.

Verification (local, on pinned 1.96.0)

  • cargo fmt --all --check — clean
  • cargo clippy --workspace --all-targets -- -D warnings — clean, no new lints
  • cargo build --workspace --all-targets — clean
  • cargo test --workspace --all-targets — 747 passed; 1 pre-existing flaky test (tui::tests::assistant_comfyui_start_result_shows_url_models_and_quit_prompt, passes in isolation; unaffected by this change as it touches no Rust code)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the repository’s Rust toolchain to a specific version (1.96.0) to make CI and release builds reproducible, and updates CI/release workflows to consistently install Rust from that pinned toolchain definition.

Changes:

  • Added rust-toolchain.toml with channel = "1.96.0" plus rustfmt/clippy components and minimal profile.
  • Updated workspace rust-version to 1.96 in Cargo.toml.
  • Switched GitHub Actions workflows from dtolnay/rust-toolchain@stable (and manual cargo caching) to actions-rust-lang/setup-rust-toolchain@v1, and adjusted manylinux rustup installation to avoid defaulting to stable.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rust-toolchain.toml Introduces a single source of truth for the pinned Rust toolchain and components.
Cargo.toml Aligns declared rust-version with the pinned toolchain used for builds.
.github/workflows/ci.yml Uses the pinned toolchain in CI via setup-rust-toolchain and removes manual cargo cache steps.
.github/workflows/release.yml Ensures release builds use the pinned toolchain (including inside manylinux Docker builds).
.github/workflows/nightly.yml Ensures nightly builds use the pinned toolchain (including inside manylinux Docker builds).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Builds previously floated on the latest stable toolchain, so a new
stable release could silently change CI behavior. Add a
rust-toolchain.toml as the single source of truth and have every
environment defer to it: GitHub-hosted runners use
actions-rust-lang/setup-rust-toolchain (which reads the file), and the
manylinux release/nightly builds install rustup with --default-toolchain
none so cargo auto-installs the pinned channel.

Bumping Rust now means editing one line in rust-toolchain.toml.

Switching to setup-rust-toolchain also lets the action's bundled
rust-cache replace the manual actions/cache blocks, and the rustfmt and
clippy components now come from the toolchain file.

Align the workspace rust-version to 1.96 as well: this is an application
shipping prebuilt binaries built with the pinned toolchain, so the
supported version tracks the toolchain we actually build with rather
than an unverified older floor.
@rominf
rominf force-pushed the pin-rust-toolchain branch from bac0c1c to 1729a48 Compare June 16, 2026 13:34
@rominf
rominf added this pull request to the merge queue Jun 16, 2026
Merged via the queue into main with commit 47eca2b Jun 16, 2026
4 checks passed
@rominf
rominf deleted the pin-rust-toolchain branch July 22, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants