Repository navigation
Pin Rust toolchain to 1.96.0 - #12
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the repository’s Rust toolchain to a specific version (1.96.0) to make CI and release builds reproducible, and updates CI/release workflows to consistently install Rust from that pinned toolchain definition.
Changes:
- Added
rust-toolchain.tomlwithchannel = "1.96.0"plusrustfmt/clippycomponents andminimalprofile. - Updated workspace
rust-versionto1.96inCargo.toml. - Switched GitHub Actions workflows from
dtolnay/rust-toolchain@stable(and manual cargo caching) toactions-rust-lang/setup-rust-toolchain@v1, and adjusted manylinux rustup installation to avoid defaulting tostable.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust-toolchain.toml | Introduces a single source of truth for the pinned Rust toolchain and components. |
| Cargo.toml | Aligns declared rust-version with the pinned toolchain used for builds. |
| .github/workflows/ci.yml | Uses the pinned toolchain in CI via setup-rust-toolchain and removes manual cargo cache steps. |
| .github/workflows/release.yml | Ensures release builds use the pinned toolchain (including inside manylinux Docker builds). |
| .github/workflows/nightly.yml | Ensures nightly builds use the pinned toolchain (including inside manylinux Docker builds). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
r0x0r
approved these changes
Jun 16, 2026
Builds previously floated on the latest stable toolchain, so a new stable release could silently change CI behavior. Add a rust-toolchain.toml as the single source of truth and have every environment defer to it: GitHub-hosted runners use actions-rust-lang/setup-rust-toolchain (which reads the file), and the manylinux release/nightly builds install rustup with --default-toolchain none so cargo auto-installs the pinned channel. Bumping Rust now means editing one line in rust-toolchain.toml. Switching to setup-rust-toolchain also lets the action's bundled rust-cache replace the manual actions/cache blocks, and the rustfmt and clippy components now come from the toolchain file. Align the workspace rust-version to 1.96 as well: this is an application shipping prebuilt binaries built with the pinned toolchain, so the supported version tracks the toolchain we actually build with rather than an unverified older floor.
rominf
force-pushed
the
pin-rust-toolchain
branch
from
June 16, 2026 13:34
bac0c1c to
1729a48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins the Rust toolchain to 1.96.0 for reproducible builds. Previously builds floated on the latest
stable, so a new stable release could silently change CI behavior. 1.96.0 also carries security fixes (CVE-2026-33055 / CVE-2026-33056 via Cargo'starbump).The version lives in one place —
rust-toolchain.toml— and every environment defers to it:actions-rust-lang/setup-rust-toolchain@v1rust-toolchain.tomlrustup --default-toolchain none→cargoTo bump Rust in future, edit one line in
rust-toolchain.toml.Incidental cleanups
actions/cacheblocks —setup-rust-toolchainbundlesSwatinem/rust-cachewith more precise keys.with: components:on thefmt/clippyjobs — components now come from the toolchain file.MSRV
Aligned
rust-version(1.88→1.96). This is an application shipping prebuilt binaries built with the pinned toolchain, so the supported version tracks the toolchain we actually build with rather than an unverified older floor.Verification (local, on pinned 1.96.0)
cargo fmt --all --check— cleancargo clippy --workspace --all-targets -- -D warnings— clean, no new lintscargo build --workspace --all-targets— cleancargo test --workspace --all-targets— 747 passed; 1 pre-existing flaky test (tui::tests::assistant_comfyui_start_result_shows_url_models_and_quit_prompt, passes in isolation; unaffected by this change as it touches no Rust code)