Repository navigation
fix(dash): restore terminal on SIGTERM/SIGINT and make typed Ctrl-C quit #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f6fe0ec
fix(dash): restore terminal on SIGTERM/SIGINT across the launcher hub…
r0x0r f971ab6
fix(dash): arbitrate concurrent termination watchers and test the wiring
r0x0r 4639efb
fix(dash): handle a typed Ctrl-C as a key and stop late frames undoin…
r0x0r c36ab86
Merge origin/main into fix/dash-restore-terminal-on-sigterm
r0x0r 2e1ebb6
fix(e2e): collapse the duplicate wait_for_exit_code from the merge
r0x0r 7a82ef8
fix(e2e): restore in_alternate_screen dropped while deduping the merge
r0x0r e3e36cc
fix(dash): quit on Ctrl-C over a finished job console, and cover the …
r0x0r f46ca9a
fix(dash): gate the test signal timeout to unix so the Windows lane b…
r0x0r f3e29d6
test(dash): assert the restore path disables mouse capture
r0x0r 94702d1
fix(dash): unwedge the launcher hub, and stop the help modal truncating
r0x0r ba6d161
test(dash): replace a help-modal test that could not fail, and conten…
r0x0r 52cb544
fix(dash): clamp the popup width floor, and mark a help modal that st…
r0x0r 68db54f
fix(dash): stop an in-flight frame undoing the restore it raced
r0x0r cbe5af6
fix(dash): clamp the popup height floor, the twin of the width floor
r0x0r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ctrl-C is now a first-class quit gesture in both loops, but it isn't documented on any key-hint surface. These all still list just
q quit:ui/modal.rs:88and:604(the?help modals)ui/mod.rsui/launcher.rs:251README.md:158(Anchored here because none of those lines are in this PR's diff.)