Repository navigation
fix(dash): detect amd-smi through WSL DXG (EAI-8450) #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
23ff23f
fix(dash): detect amd-smi through WSL DXG
michaelroy-amd b4f98bc
fix(dash): reuse rocm-core's GPU-reachability verdict for the WSL pre…
juhovainio 07c328a
fix(dash): tighten the WSL GPU telemetry e2e scenario per review
juhovainio d948452
fix(dash): distinguish amd-smi contradiction from real inaccessibility
juhovainio a765338
test(dash): pin the WSL amd-smi preflight production wiring
juhovainio 4e33a40
fix(dash): gate WSL GPU-reachable verdict, fix contradiction message
juhovainio 9ff24aa
fix(dash): truth-table the WSL gate, restore bare-metal amd-smi cause
juhovainio f74d59f
fix(dash): bound the WSL regression guards, close review's residual gaps
juhovainio 4ff83e1
fix(dash): drop the vacuous WSL-gate wiring test, close review's resi…
juhovainio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small things here.
Nit (formatting): no blank line after
use super::*;. This is the sole outlier among 18 test modules repo-wide, andcargo fmtwon't catch it.Coverage: of five plausible mutants of
gpu_device_accessible, this test kills only||→&&. Surviving: returning unconditionaltrue; a typo inDXG_DEVICE; a call site that passesKFD_DEVICEtwice;.write(true)instead of.read(true). There's no assertion of the false direction at all, andDXG_DEVICEhas exactly one reference in the crate — the untested call site at line 76. Because the test writes a regular file, the interesting real-device failure modes (EACCES / ENXIO / EBUSY on a char device) are unrepresented, so what it mostly proves isstd::fssemantics.Minimal close: add a
gpu_device_accessible(missing, missing) == falsecase, a KFD-only case, andassert_eq!(DXG_DEVICE, "/dev/dxg").