Skip to content

chore(deps): bump the cargo-minor-patch group across 1 directory with 20 updates - #714

Closed
dependabot[bot] wants to merge 4 commits into
mainfrom
dependabot/cargo/cargo-minor-patch-c34f4c841e
Closed

dependabot[bot] wants to merge 4 commits into
mainfrom
dependabot/cargo/cargo-minor-patch-c34f4c841e

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Bumps the cargo-minor-patch group with 20 updates in the / directory:

Package From To
anyhow 1.0.102 1.0.104
clap 4.6.1 4.6.7
clap_complete 4.6.5 4.6.11
keyring-core 1.0.0 1.0.1
libc 0.2.186 0.2.191
serde 1.0.228 1.0.229
serde_json 1.0.150 1.0.154
tokio 1.52.3 1.53.2
flate2 1.1.9 1.1.10
apple-native-keyring-store 1.0.0 1.0.2
zbus-secret-service-keyring-store 1.0.0 1.0.1
proptest 1.11.0 1.12.0
regex 1.12.4 1.13.1
cc 1.2.65 1.8.0
thiserror 2.0.18 2.0.21
bollard 0.21.0 0.21.1
tokio-util 0.7.18 0.7.20
futures 0.3.32 0.3.34
async-trait 0.1.89 0.1.92
http 1.4.2 1.5.0

Updates anyhow from 1.0.102 to 1.0.104

Release notes

Sourced from anyhow's releases.

1.0.104

  • Update syn dev-dependency to version 3

1.0.103

  • Fix Stacked Borrows violation (UB) in Error::downcast_mut (#451, #452)
Commits
  • 1dbe186 Release 1.0.104
  • f6479f8 Update to syn 3
  • 5bdb0e2 Release 1.0.103
  • e621bd3 Merge pull request #452 from dtolnay/downcast
  • 6e8c000 Eliminate pointer->reference->pointer during downcast
  • 67c4abd Add regression test for issue 451
  • 917a169 Update actions/upload-artifact@v6 -> v7
  • d9dc3fa Update actions/checkout@v6 -> v7
  • 841522b Raise minimum tested compiler to rust 1.85
  • See full diff in compare view

Updates clap from 4.6.1 to 4.6.7

Release notes

Sourced from clap's releases.

v4.6.7

[4.6.7] - 2026-09-14

Features

  • (derive) Add #[command(defer = <bool>)] attribute to opt-in to lazy initialisation of subcommands

v4.6.6

[4.6.6] - 2026-08-06

Features

  • Add Command::get_overridden_usage

v4.6.5

[4.6.5] - 2026-07-31

Fixes

  • (help) Correctly mark which value_names are optional with num_args

v4.6.4

[4.6.4] - 2026-07-21

Internal

  • Update to syn v3

v4.6.3

[4.6.3] - 2026-07-20

Fixes

  • (derive) Allow "literal".function() as attribute values

v4.6.2

[4.6.2] - 2026-07-15

Fixes

  • (help) Say alias when there is only one
Changelog

Sourced from clap's changelog.

[4.6.7] - 2026-09-14

Features

  • (derive) Add #[command(defer = <bool>)] attribute to opt-in to lazy initialisation of subcommands

[4.6.6] - 2026-08-06

Features

  • Add Command::get_overridden_usage

[4.6.5] - 2026-07-31

Fixes

  • (help) Correctly mark which value_names are optional with num_args

[4.6.4] - 2026-07-21

Internal

  • Update to syn v3

[4.6.3] - 2026-07-20

Fixes

  • (derive) Allow "literal".function() as attribute values

[4.6.2] - 2026-07-15

Fixes

  • (help) Say alias when there is only one
Commits
  • d3e59a9 chore: Release
  • d997f87 docs: Update changelog
  • fb6058c Merge pull request #6409 from heaths/pwsh-support
  • 2310870 test(complete): Add tests for completer_for_path
  • 5967c17 refactor(complete): Move shell detection to Shells
  • 594602b fix(complete): Detect pwsh for PowerShell
  • 3a4f2d0 Merge pull request #6427 from clap-rs/renovate/shlex-2.x
  • 67ebaed Merge pull request #6426 from clap-rs/renovate/actions-checkout-7.x
  • c968b13 chore(deps): Update Rust crate shlex to v2
  • 8f247cb chore(deps): Update actions/checkout action to v7
  • Additional commits viewable in compare view

Updates clap_complete from 4.6.5 to 4.6.11

Release notes

Sourced from clap_complete's releases.

v4.6.7

[4.6.7] - 2026-09-14

Features

  • (derive) Add #[command(defer = <bool>)] attribute to opt-in to lazy initialisation of subcommands

v4.6.6

[4.6.6] - 2026-08-06

Features

  • Add Command::get_overridden_usage
Changelog

Sourced from clap_complete's changelog.

Change Log

All notable changes to this project will be documented in this file.

The format is based on Keep a Changelog and this project adheres to Semantic Versioning.

5.0.0 - TBD

available through unstable-v5 feature flag

Breaking Changes

  • Made ArgPredicate non_exhaustive
  • (help) Change default Command::term_width to "source format"
  • (help) Change default Command::max_term_width to 100
  • (derive) Vec<Vec<T>> types are now assuming to capture occurrences
  • (derive) ValueEnum variants now use the full doc comment, not summary, for PossibleValue::help
  • (derive) Default for deferring changed to #[command(defer = true)]

Features

  • (derive) Group values by their occurrence with Vec<Vec<T>>

[Unreleased] - ReleaseDate

[4.6.7] - 2026-09-14

Features

  • (derive) Add #[command(defer = <bool>)] attribute to opt-in to lazy initialisation of subcommands

[4.6.6] - 2026-08-06

Features

  • Add Command::get_overridden_usage
Commits
  • 2cb76fd chore: Release
  • 0b00b8d docs: Update changelog
  • 3443000 Merge pull request #6526 from bonnefoa/fix-completion-escape
  • a1b6be7 fix(clap_complete): Fix value escape in zsh completion
  • face9e8 test(complete): Add completion test without arg's help
  • 88053ab test(complete): Re-enable complete tests
  • e6adcc2 chore(release): Simplify replacements
  • 13f2db5 chore: Release
  • 3304fea docs: Update changelog
  • 7b2ad34 Merge pull request #6521 from r-near/feat/derive-deferred-initialization
  • Additional commits viewable in compare view

Updates keyring-core from 1.0.0 to 1.0.1

Release notes

Sourced from keyring-core's releases.

v1.0.1: Improved testing

This release has no functional changes. The tests have been reworked and improved so that cargo-mutants no longer finds coverage gaps, either in the library API or in the two included credential stores (mock and sample).

What's Changed

New Contributors

Full Changelog: open-source-cooperative/keyring-core@v1.0.0...v1.0.1

Commits
  • 50fe5c4 Add cargo-mutants testing (#25)
  • 97b53d8 Bump version for release.
  • 4004baa Integrate review comments.
  • 6d2f8a5 Integrate review comments.
  • 1aa61ea Clean up .gitignore
  • 14d9c94 Improve tests to cover cargo-mutants misses.
  • 9f71d13 Set up cargo-mutants config.
  • ce48eaf Audit workflows with zizmor (#24)
  • 3649f1f Discard changes to .github/workflows/ci.yaml
  • aa5add8 Merge branch 'main' into upstream/ci-zizmor
  • Additional commits viewable in compare view

Updates libc from 0.2.186 to 0.2.190

Release notes

Sourced from libc's releases.

0.2.190

There is now a single config for enabling 64-bit time_t: libc_unstable_time64. This can be set unconditionally; it opts in to 64-bit time_t on the following platforms that use 32-bit by default:

  • 32-bit Linux-GNU
  • 32-bit Linux-uClibc
  • 32-bit Linux-musl. Note that setting this flag also enables some other changes that happend in musl v1.2.
  • 32-bit Windows-GNU
  • ESP-IDF (all targets with this environment are 32-bit)

Most other 32-bit platforms are either already using 64-bit time_t, or are considered legacy and will not be gaining support from their upstream maintainers.

You can enable this using RUSTFLAGS:

RUSTFLAGS='--cfg=libc_unstable_time64' cargo ...

Note that there may still be some changes to features gated by this config option, hence "unstable" in its name. In the near future we will rename it to just libc_time64. Until then, please test it out and report any bugs you find!

Support

  • Add initial support for HelenOS (#4355)

Added

We are slowly filling out the Default implementations, to reduce the need for mem::zeroed() in user code:

  • Unix: Implement Default for a number of structs, especially on Apple platforms (#5576)
  • Linux, NetBSD: Give statvfs a Default impl (#5583)
  • Linux: Add Default to a linux/can.rs structs (#5257)

Other additions:

  • Expose the libc_unstable_time64 cfg (#5411)
  • Android, Glibc: Add pthread_gettid_np (#5359)
  • Android: Add RTLD_NEXT (#5323)
  • Android: Add reuseport BPF socket options (#5366)
  • Apple: Add TCP header flags, options and SACK limits (#5358)
  • Apple: Add NET_RT_DUMP2 (#5442)
  • Apple: Add posix_spawn_file_actions_add(f)chdir(_np) (#5558)
  • BSD: Add BPF_WORDALIGN (#5320)
  • BSD: Add lchmod and lchflags where supported (#5400)
  • BSD: Add minherit and related constants (#4849)
  • Docs: Add more links to public headers and manual pages (#5407), (#5485)

... (truncated)

Changelog

Sourced from libc's changelog.

0.2.190 - 2026-10-02

There is now a single config for enabling 64-bit time_t: libc_unstable_time64. This can be set unconditionally; it opts in to 64-bit time_t on the following platforms that use 32-bit by default:

  • 32-bit Linux-GNU
  • 32-bit Linux-uClibc
  • 32-bit Linux-musl. Note that setting this flag also enables some other changes that happend in musl v1.2.
  • 32-bit Windows-GNU
  • ESP-IDF (all targets with this environment are 32-bit)

Most other 32-bit platforms are either already using 64-bit time_t, or are considered legacy and will not be gaining support from their upstream maintainers.

You can enable this using RUSTFLAGS:

RUSTFLAGS='--cfg=libc_unstable_time64' cargo ...

Note that there may still be some changes to features gated by this config option, hence "unstable" in its name. In the near future we will rename it to just libc_time64. Until then, please test it out and report any bugs you find!

Support

  • Add initial support for HelenOS (#4355)

Added

We are slowly filling out the Default implementations, to reduce the need for mem::zeroed() in user code:

  • Unix: Implement Default for a number of structs, especially on Apple platforms (#5576)
  • Linux, NetBSD: Give statvfs a Default impl (#5583)
  • Linux: Add Default to a linux/can.rs structs (#5257)

Other additions:

  • Expose the libc_unstable_time64 cfg (#5411)
  • Android, Glibc: Add pthread_gettid_np (#5359)
  • Android: Add RTLD_NEXT (#5323)
  • Android: Add reuseport BPF socket options (#5366)
  • Apple: Add TCP header flags, options and SACK limits (#5358)
  • Apple: Add NET_RT_DUMP2 (#5442)
  • Apple: Add posix_spawn_file_actions_add(f)chdir(_np) (#5558)
  • BSD: Add BPF_WORDALIGN (#5320)
  • BSD: Add lchmod and lchflags where supported (#5400)
  • BSD: Add minherit and related constants (#4849)

... (truncated)

Commits
  • 7b0ab55 ci: Rename publish_0.2.yml to release.yaml
  • ac85dde ci: Sync release permissions with main
  • 8f8cd20 libc: Release 0.2.190
  • 052c6e6 changelog: Fix an incorrect commit link
  • ea19fd7 test: Remove explicit libc version
  • 6dbf3a2 dragonfly: Move INHERIT_ZERO to the freebsd module
  • 8a64766 apple: add posix_spawn_file_actions_add(f)chdir(_np)
  • 28de514 linux, netbsd: Give statvfs a Default impl
  • a58a95f cygwin: Change POSIX_SPAWN_* flags to c_short
  • d175264 apple: timeval32 is exhaustive
  • Additional commits viewable in compare view

Updates serde from 1.0.228 to 1.0.229

Release notes

Sourced from serde's releases.

v1.0.229

  • Update to syn 3
Commits
  • 7fc3b4c Release 1.0.229
  • 6d6e9a1 Merge pull request #3085 from dtolnay/syn3
  • 6dec3b7 Update to syn 3
  • cfe6692 Resolve mut_mut pedantic clippy lint
  • 1023d07 Update actions/upload-artifact@v6 -> v7
  • dd682c2 Update actions/checkout@v6 -> v7
  • 5f0f18b Update ui test suite to nightly-2026-06-01
  • 63a1498 Regenerate stderr with trybuild normalization fixes
  • fa7da4a Fix unused_features warning
  • 6b1a178 Unpin CI miri toolchain
  • Additional commits viewable in compare view

Updates serde_json from 1.0.150 to 1.0.154

Release notes

Sourced from serde_json's releases.

v1.0.154

v1.0.153

v1.0.152

v1.0.151

Commits
  • 20572a6 Release 1.0.154
  • a91bfaf Fix RandomState links in map documentation
  • 3c932c0 Merge pull request #1333 from razmser/no-std-preserve-order
  • 4b2d726 Release 1.0.153
  • 83335ee Touch up PR 1345
  • 4b4810a Resolve range_plus_one pedantic clippy lint
  • 8af71cc Merge pull request #1345 from 00200200/fix-invalid-utf8-error-column
  • 452afa2 Correct multiline raw UTF-8 error positions and simplify indexing
  • c9f1e3b Release 1.0.152
  • 854fc70 Touch up PR 1347
  • Additional commits viewable in compare view

Updates tokio from 1.52.3 to 1.53.2

Release notes

Sourced from tokio's releases.

Tokio v1.53.2

1.53.2 (October 3rd, 2026)

Fixed

  • fs: handle integer overflow in buffered relative seek (#8574)
  • io: revert "always cleanup AsyncFd registration list on deregister" (#8540)
  • process: unregister Windows wait before closing child handle (#8564)
  • rt: drop blocking pool mutex before shutting down rejected task (#8562)
  • sync: fix mpsc index wraparound in block reclamation (#8546)
  • sync: forget mpsc Permit before sending value (#8560)
  • sync: validate MAX_PERMITS in Semaphore::acquire (#8548)
  • sync: wake broadcast Sender::closed outside mutex (#8558)
  • task: drop replaced waker outside lock in JoinSet (#8554)
  • time: drop timer lock before dropping waker in clear_entry (#8552)
  • time: expire timers directly on shutdown without rotating wheel (#8570)

Fixed (unstable)

  • fs: clamp io_uring read length to u32::MAX (#8572)
  • rt: ignore current_thread task dumps from other runtimes (#8544)
  • rt: preserve io_uring context if a completion waker panics (#8566)
  • sync: fix semaphore use-after-free and permit leak on tracing panic (#8542)
  • taskdump: restore deferred leaf wakes during capture (#8445)
  • time: drop stored waker when cancelling alt timer entry (#8550)

#8445: tokio-rs/tokio#8445 #8572: tokio-rs/tokio#8572 #8540: tokio-rs/tokio#8540 #8542: tokio-rs/tokio#8542 #8544: tokio-rs/tokio#8544 #8546: tokio-rs/tokio#8546 #8548: tokio-rs/tokio#8548 #8550: tokio-rs/tokio#8550 #8552: tokio-rs/tokio#8552 #8554: tokio-rs/tokio#8554 #8558: tokio-rs/tokio#8558 #8560: tokio-rs/tokio#8560 #8562: tokio-rs/tokio#8562 #8564: tokio-rs/tokio#8564 #8566: tokio-rs/tokio#8566 #8570: tokio-rs/tokio#8570 #8574: tokio-rs/tokio#8574

Tokio v1.53.1

1.53.1 (July 20th, 2026)

Fixed

  • signal: restore MSRV by removing OnceLock::wait from the Windows handler (#8300)

... (truncated)

Commits
  • ff0c406 chore: prepare Tokio v1.53.2 (#8580)
  • a762700 Merge 'tokio-1.51.5' into 'tokio-1.53.x' (#8577)
  • ec31a9f chore: prepare Tokio v1.51.5 (#8579)
  • 625c851 sync: assign semaphore permits before emitting tracing event (#8542)
  • 832dd23 sync: avoid leaking semaphore permits on tracing panic (#8542)
  • 826954a sync: unlink semaphore waiter before emitting tracing event (#8542)
  • 9a47992 process: unregister Windows wait before closing child handle (#8564)
  • 2fc5972 fs: handle integer overflow in buffered relative seek (#8574)
  • 85a6d13 io: revert "always cleanup AsyncFd registration list on deregister" (#8540)
  • 436faa2 rt: drop blocking pool mutex before shutting down rejected task (#8562)
  • Additional commits viewable in compare view

Updates flate2 from 1.1.9 to 1.1.10

Release notes

Sourced from flate2's releases.

1.1.10

What's Changed

New Contributors

Full Changelog: rust-lang/flate2-rs@1.1.9...1.1.10

Commits
  • ed93d4f Merge pull request #558 from rust-lang/lib-doc-update
  • fb5228d Merge pull request #559 from bushrat011899/no_std
  • 6ed3ba3 Add executable no_std example
  • faed8a0 Expand CI to test no_std compatibility and correctness
  • 2ba8e7e Add unstable no_std support behind flate2_unstable_nightly_alloc_io
  • 3fe1126 Centralize usage of std for error and io
  • 98e313a Add GzHeader::mtime_as_duration
  • 0642965 Switch to core implicit prelude and only use std where required
  • 454a63c Remove left-over dbg! statement
  • 2a490b7 Add runtime_detection feature
  • Additional commits viewable in compare view

Updates apple-native-keyring-store from 1.0.0 to 1.0.2

Release notes

Sourced from apple-native-keyring-store's releases.

v1.0.2: fix credential deletion to report failures correctly

This is a bug fix release. The delete_credential call was not correctly reporting a failure when the credential existed but could not be deleted. See #19 for details.

Thanks much to @​acoliver and @​ojhermann for both finding and fixing this bug!

What's Changed

New Contributors

Full Changelog: open-source-cooperative/apple-native-keyring-store@v1.0.1...v1.0.2

v1.0.1: bug fix release

This release fixes the incorrect mapping of this-device-only access policies (open-source-cooperative/apple-native-keyring-store#17 as reported by @​hideselfview - thanks!).

What's Changed

Full Changelog: open-source-cooperative/apple-native-keyring-store@v1.0.0...v1.0.1

Commits
  • 78cdfff Prepare release of v1.0.2. (#23)
  • 43bc380 Prepare release of v1.0.2.
  • 79e4e6a Check the OSStatus when deleting a keychain credential (#22)
  • 09582f7 Map errSecInvalidOwnerEdit to NoStorageAccess.
  • 6f3cdbb Check the OSStatus when deleting a keychain credential.
  • 4ffc36f Prepare release of v1.0.1 (#18)
  • a8c792b Prepare release of v1.0.1.
  • 0de54c4 Fix incorrect mapping of this-device-only access policies.
  • See full diff in compare view

Updates zbus-secret-service-keyring-store from 1.0.0 to 1.0.1

Release notes

Sourced from zbus-secret-service-keyring-store's releases.

v1.0.1: Bug fix release

This is a bug fix release. Thanks to @​pandawood, updates to credentials now use the correct mime-type for binary secrets(application/octet-stream). See #13 and #16 for details.

What's Changed

Full Changelog: open-source-cooperative/zbus-secret-service-keyring-store@v1.0.0...v1.0.1

Commits
  • a97612a Prepare to release v1.0.1 (#17)
  • 327e70e Prepare to release v1.0.1
  • dd1a5ca Use application/octet-stream when updating a secret's value (#16)
  • 56b4957 Use application/octet-stream when updating a secret's value
  • See full diff in compare view

Updates proptest from 1.11.0 to 1.12.0

Commits
  • 70cf37d Merge pull request #675 from proptest-rs/prep-1.12
  • 729e0ff prepare next releases and fix panic handling
  • 28c1fad Merge pull request #664 from Expyron/main
  • 5ddd9a4 Merge pull request #668 from toddATavail/fix-fork-persisted-failure
  • a6a9ac7 Merge pull request #673 from glaziermag/fix-book-deploy
  • d57d88b Replace rand_chacha with chacha20
  • 9411213 Deploy the book on pushes to main
  • 1719745 fix: terminate the fork replay when a persisted failure fails
  • 0f55b7a test: a persisted failure in a forked test must be reported
  • 4b0594e Merge pull request #669 from proptest-rs/no-fail-fast
  • Additional commits viewable in compare view

Updates regex from 1.12.4 to 1.13.1

Changelog

Sourced from regex's changelog.

1.13.1 (2026-07-15)

This is a release that fixes a bug where incorrect regex match offsets could be reported. Note that this doesn't impact whether a match occurs or not, just where it occurs. The match offsets are still valid for slicing, they just may not refer to the correct leftmost-first match. See #1364 for (many) more details.

Bug fixes:

  • #1354: Fixes previously unsound reverse suffix and inner optimizations.

1.13.0 (2026-07-09)

This release includes a new API, a regex! macro, for lazy compilation of a regex from a string literal. If you use regexes a lot, it's likely you've already written one exactly like it. The new macro can be used like this:

use regex::regex;
fn is_match(line: &str) -> bool {
// The regex will be compiled approximately once and reused automatically.
// This avoids the footgun of using Regex::new here, which would
// guarantee that it would be compiled every time this routine is called.
// This would likely make this routine much slower than it needs to be.
regex!(r"bar|baz").is_match(line)
}
let hay = "
path/to/foo:54:Blue Harvest
path/to/bar:90:Something, Something, Something, Dark Side
path/to/baz:3:It's a Trap!
";
let matches = hay.lines().filter(|line| is_match(line)).count();
assert_eq!(matches, 2);

Improvements:

  • #709: Add a new regex! macro for efficient and automatic reuse of a compiled regex.
Commits
  • 2b52759 1.13.1, redux
  • 40e9823 1.13.1
  • 75fcb96 changelog: 1.13.1
  • 64ad0b6 automata: fix bug in reverse suffix/inner optimization
  • fa91c31 automata: fix a bug caught by Codex review
  • 30390ec automata: formatting tweaks
  • 821a8eb automata: refactor reverse suffix/inner search slightly
  • 10afd70 automata: expose the extracted literals for inner literal extraction
  • 8c34f41 automata: avoid reverse suffix optimization for non-leftmost-first
  • 5524f02 test: add regression tests for failed reverse suffix/inner optimizations
  • Additional commits viewable in compare view

Updates cc from 1.2.65 to 1.8.0

Release notes

Sourced from cc's releases.

cc-v1.8.0

Added

  • add CC_PREFER_CLANG_CL_OVER_MSVC to override prefer_clang_cl_over_msvc (#2001)

Fixed

  • (panic) fix panic in code and replace with error when appropriate (#2008)
  • (env) do not panic if WASM_MUSL_SYSROOT not set (#2007)
  • (jobserver) help thread gets more token than necessary (#2006)
  • stop forwarding -Cprofile-generate/-Cprofile-use to the C compiler (#2003)
  • do not apply target crt-static when target is overridden (#1999)

Other

  • (parallel) poll for process exit on linux (#2009)
  • document NVCC and other environment variables (#2005)
  • (jobserver) poll for new token (#2004)
  • (parallel) Use poll on unix (#2000)

cc-v1.7.0

Added

  • add Tool::get_envs, deprecate Tool::env and store tool env as Arc<OsStr> pairs (#1985)
  • link c++ when Clang uses libc++ (#1978)
  • add CC_MASM_ASM and fall back to llvm-ml for MASM files (#1975)

Fixed

  • (target parsing) for powerpc64-ibm-aix abi (#1989)
  • ignore ASCII case in program name checks (#1981)

Other

  • (compile) issue compilation cmds more frequently in parallel

… 20 updates

Bumps the cargo-minor-patch group with 20 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [anyhow](https://github.com/dtolnay/anyhow) | `1.0.102` | `1.0.104` |
| [clap](https://github.com/clap-rs/clap) | `4.6.1` | `4.6.7` |
| [clap_complete](https://github.com/clap-rs/clap) | `4.6.5` | `4.6.11` |
| [keyring-core](https://github.com/open-source-cooperative/keyring-core) | `1.0.0` | `1.0.1` |
| [libc](https://github.com/rust-lang/libc) | `0.2.186` | `0.2.190` |
| [serde](https://github.com/serde-rs/serde) | `1.0.228` | `1.0.229` |
| [serde_json](https://github.com/serde-rs/json) | `1.0.150` | `1.0.154` |
| [tokio](https://github.com/tokio-rs/tokio) | `1.52.3` | `1.53.2` |
| [flate2](https://github.com/rust-lang/flate2-rs) | `1.1.9` | `1.1.10` |
| [apple-native-keyring-store](https://github.com/open-source-cooperative/apple-native-keyring-store) | `1.0.0` | `1.0.2` |
| [zbus-secret-service-keyring-store](https://github.com/open-source-cooperative/zbus-secret-service-keyring-store) | `1.0.0` | `1.0.1` |
| [proptest](https://github.com/proptest-rs/proptest) | `1.11.0` | `1.12.0` |
| [regex](https://github.com/rust-lang/regex) | `1.12.4` | `1.13.1` |
| [cc](https://github.com/rust-lang/cc-rs) | `1.2.65` | `1.8.0` |
| [thiserror](https://github.com/dtolnay/thiserror) | `2.0.18` | `2.0.21` |
| [bollard](https://github.com/fussybeaver/bollard) | `0.21.0` | `0.21.1` |
| [tokio-util](https://github.com/tokio-rs/tokio) | `0.7.18` | `0.7.20` |
| [futures](https://github.com/rust-lang/futures-rs) | `0.3.32` | `0.3.34` |
| [async-trait](https://github.com/dtolnay/async-trait) | `0.1.89` | `0.1.92` |
| [http](https://github.com/hyperium/http) | `1.4.2` | `1.5.0` |



Updates `anyhow` from 1.0.102 to 1.0.104
- [Release notes](https://github.com/dtolnay/anyhow/releases)
- [Commits](dtolnay/anyhow@1.0.102...1.0.104)

Updates `clap` from 4.6.1 to 4.6.7
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/main/CHANGELOG.md)
- [Commits](clap-rs/clap@clap_complete-v4.6.1...clap_complete-v4.6.7)

Updates `clap_complete` from 4.6.5 to 4.6.11
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/main/CHANGELOG.md)
- [Commits](clap-rs/clap@clap_complete-v4.6.5...clap_complete-v4.6.11)

Updates `keyring-core` from 1.0.0 to 1.0.1
- [Release notes](https://github.com/open-source-cooperative/keyring-core/releases)
- [Commits](open-source-cooperative/keyring-core@v1.0.0...v1.0.1)

Updates `libc` from 0.2.186 to 0.2.190
- [Release notes](https://github.com/rust-lang/libc/releases)
- [Changelog](https://github.com/rust-lang/libc/blob/0.2.190/CHANGELOG.md)
- [Commits](rust-lang/libc@0.2.186...0.2.190)

Updates `serde` from 1.0.228 to 1.0.229
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.228...v1.0.229)

Updates `serde_json` from 1.0.150 to 1.0.154
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.150...v1.0.154)

Updates `tokio` from 1.52.3 to 1.53.2
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-1.52.3...tokio-1.53.2)

Updates `flate2` from 1.1.9 to 1.1.10
- [Release notes](https://github.com/rust-lang/flate2-rs/releases)
- [Commits](rust-lang/flate2-rs@1.1.9...1.1.10)

Updates `apple-native-keyring-store` from 1.0.0 to 1.0.2
- [Release notes](https://github.com/open-source-cooperative/apple-native-keyring-store/releases)
- [Commits](open-source-cooperative/apple-native-keyring-store@v1.0.0...v1.0.2)

Updates `zbus-secret-service-keyring-store` from 1.0.0 to 1.0.1
- [Release notes](https://github.com/open-source-cooperative/zbus-secret-service-keyring-store/releases)
- [Commits](open-source-cooperative/zbus-secret-service-keyring-store@v1.0.0...v1.0.1)

Updates `proptest` from 1.11.0 to 1.12.0
- [Release notes](https://github.com/proptest-rs/proptest/releases)
- [Changelog](https://github.com/proptest-rs/proptest/blob/main/CHANGELOG.md)
- [Commits](proptest-rs/proptest@v1.11.0...v1.12.0)

Updates `regex` from 1.12.4 to 1.13.1
- [Release notes](https://github.com/rust-lang/regex/releases)
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md)
- [Commits](rust-lang/regex@1.12.4...1.13.1)

Updates `cc` from 1.2.65 to 1.8.0
- [Release notes](https://github.com/rust-lang/cc-rs/releases)
- [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md)
- [Commits](rust-lang/cc-rs@cc-v1.2.65...cc-v1.8.0)

Updates `thiserror` from 2.0.18 to 2.0.21
- [Release notes](https://github.com/dtolnay/thiserror/releases)
- [Commits](dtolnay/thiserror@2.0.18...2.0.21)

Updates `bollard` from 0.21.0 to 0.21.1
- [Release notes](https://github.com/fussybeaver/bollard/releases)
- [Changelog](https://github.com/fussybeaver/bollard/blob/master/RELEASE.md)
- [Commits](fussybeaver/bollard@v0.21.0...v0.21.1)

Updates `tokio-util` from 0.7.18 to 0.7.20
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-util-0.7.18...tokio-util-0.7.20)

Updates `futures` from 0.3.32 to 0.3.34
- [Release notes](https://github.com/rust-lang/futures-rs/releases)
- [Changelog](https://github.com/rust-lang/futures-rs/blob/main/CHANGELOG.md)
- [Commits](rust-lang/futures-rs@0.3.32...0.3.34)

Updates `async-trait` from 0.1.89 to 0.1.92
- [Release notes](https://github.com/dtolnay/async-trait/releases)
- [Commits](dtolnay/async-trait@0.1.89...0.1.92)

Updates `http` from 1.4.2 to 1.5.0
- [Release notes](https://github.com/hyperium/http/releases)
- [Changelog](https://github.com/hyperium/http/blob/master/CHANGELOG.md)
- [Commits](hyperium/http@v1.4.2...v1.5.0)

---
updated-dependencies:
- dependency-name: anyhow
  dependency-version: 1.0.104
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: clap
  dependency-version: 4.6.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: clap_complete
  dependency-version: 4.6.11
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: keyring-core
  dependency-version: 1.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: libc
  dependency-version: 0.2.190
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: serde
  dependency-version: 1.0.229
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: serde_json
  dependency-version: 1.0.154
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: tokio
  dependency-version: 1.53.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: cargo-minor-patch
- dependency-name: flate2
  dependency-version: 1.1.10
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: apple-native-keyring-store
  dependency-version: 1.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: zbus-secret-service-keyring-store
  dependency-version: 1.0.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: proptest
  dependency-version: 1.12.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: cargo-minor-patch
- dependency-name: regex
  dependency-version: 1.13.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: cargo-minor-patch
- dependency-name: cc
  dependency-version: 1.8.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: cargo-minor-patch
- dependency-name: thiserror
  dependency-version: 2.0.21
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: bollard
  dependency-version: 0.21.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: tokio-util
  dependency-version: 0.7.20
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: futures
  dependency-version: 0.3.34
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: async-trait
  dependency-version: 0.1.92
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: cargo-minor-patch
- dependency-name: http
  dependency-version: 1.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: cargo-minor-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot requested a review from a team as a code owner October 20, 2026 15:09
@dependabot
dependabot Bot requested a review from fredespi October 20, 2026 15:09
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Oct 20, 2026
Generated by `cargo xtask manifest` and `cargo xtask tpn` for the dependency change in this pull request.

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

@rominf rominf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Automated review · pr-review-watcher · 3d29c5e

This automation never files a GitHub approval, so no approving review will
appear here whatever the outcome — the merge decision stays with a human
reviewer.

Review — needs work

Full review of the whole change.
No ticket named. The description is Dependabot's generated table of 20 group updates, plus a bot commit that regenerates MANIFEST.md and THIRD_PARTY_NOTICES.txt.

Blocking

  • (new) Four required CI checks are red on this head commit — build-and-test, Test (affected crates), Coverage (rocm-dash crates, ratcheted), E2E tests (Strix Halo, Windows, current) (and E2E consolidated report (self-hosted), which aggregates them)
    Read from statusCheckRollup and the job logs:

    • Test (affected crates) and Coverage: xtask/src/workflow_contract.rs:2925 fails in preflight_runs_the_real_reclaim_assert_clear. The message is "a real leaked engine process was running and the preflight passed", with left: 0, right: 1. The Coverage job then stops with "fix the failing tests before checking coverage floors".
    • build-and-test: the reclaim-gpu.sh self-test step fails with "FAIL: could not read a decoy's command line; the regression guard tested nothing" and "containment breached; refusing to run the real reclaim".
    • Windows E2E: Failed to download TheRock from: https://repo.amd.com/rocm/tarball/therock-dist-windows-gfx1151-7.14.1.tar.gz - Download failed after 6 attempts.

    The evidence says these are not caused by this change:

    • Both reclaim failures exercise scripts/reclaim-gpu.sh, a shell script that no bumped crate touches.
    • The same xtask test passes locally on this head. It is in the 4179 passed / 0 failed / 16 ignored across 35 test binaries from cargo test --workspace --all-targets, and the name workflow_contract::tests::preflight_runs_the_real_reclaim_assert_clear ... ok appears in the log.
    • The Windows failure is a network download from an external host.

    They are still red, though, and the change is not mergeable until they are green or shown to be the same failures main has.
    Confidence 100 · architectural · Fix: rerun the failed jobs, or confirm against main's recent runs that these failures are pre-existing. Do not change code in this PR for them.

Non-blocking

  • (new) The description and commit message give the libc target as 0.2.190, but the lockfile has 0.2.191 — Cargo.lock (libc entry), MANIFEST.md (libc row), commit c591c44 message
    The PR body and commit table say `0.2.186` | `0.2.190`. Cargo.lock, MANIFEST.md and THIRD_PARTY_NOTICES all record 0.2.191. The lockfile governs, because it is what gets built. No workspace or bumped-crate manifest requires ≥0.2.191 (tokio and tokio-util ask for 0.2.168), so this looks like the resolver picking up a newer patch after Dependabot wrote the text. The scope is right (the libc bump is mentioned); only the patch number is wrong. Squash-merging keeps the wrong number in history.
    Confidence 85 · mechanical · Fix: edit the squash commit message at merge time, or @dependabot recreate.

Decisions for the author

  • The dependency tree now carries three syn majors (1.0.109, 2.0.118, 3.0.9) and two rand lines (0.9.4 runtime, 0.10.3 test-only via proptest) — tradeoff
    The new duplicates come from async-trait, clap_derive, serde_derive, futures-macro and thiserror-impl moving to syn 3, while other proc-macros stay on syn 2. Proptest 1.12 moved to rand 0.10, and the workspace still pins rand = "0.9".

    • For taking it now: these are upstream patch/minor releases, and holding them back means pinning.
    • Against: compile time and binary size grow until the rest of the ecosystem moves to syn 3.

    No action is needed if this was accepted knowingly.

Positive signals

  • The regenerated manifests are consistent with the lockfile:
    • cargo xtask manifest --check exits 0 locally, and CI's Third-party notices current is green.
    • THIRD_PARTY_NOTICES correctly leaves out zlib-rs and the dev-only chacha20/rand 0.10. zlib-rs is only in the lockfile because of flate2's new weak runtime_detection feature; cargo tree -e features -i zlib-rs --target all prints nothing, so it is never compiled.
  • Every new or bumped crate's licence is in about.toml's accepted list, including zlib-rs (Zlib).
  • Every MSRV checked is ≤1.96; the highest are proptest 1.12 and zbus-secret-service-keyring-store at 1.88.

Deployment notes

  • zbus-secret-service-keyring-store 1.0.1 now stores secrets with content type application/octet-stream instead of text/plain. This comes from the source diff. Reading back secrets stored by earlier builds is unaffected, but an external tool that filters Secret Service items by content type would see new items differently.
  • regex 1.13.1 fixes wrong leftmost-first match offsets in some reverse-suffix/inner optimizations. Any pattern that hit that bug will now return different (correct) match positions.

What this covered

Every file in the change was read completely: Cargo.lock, MANIFEST.md, THIRD_PARTY_NOTICES.txt. Range: 0acf698d9d8f…3d29c5ece2d2 (merge-base with prw-base to head).

Beyond the diff:

  • Every workspace consumer of flate2, proptest, cc and libc.
  • The proptest code that goes beyond the macro: crates/rocm-core/src/archive_props.rs (fixed RngSeed), examine_driver_proptests.rs, apps/rocm/src/deletion_properties.rs, and the committed proptest-regressions/ files.
  • proptest 1.11 vs 1.12 rng.rs, its CHANGELOG ("preserving seed formats and seeded RNG output"), and rand_core 0.9 vs 0.10 seed_from_u64 (same PCG32 expansion).

Run locally in the checkout's own target/, with RUSTC_WRAPPER= and no shared target dir:

  • cargo test --workspace --all-targets: exit 0, 4179 passed, 0 failed, 16 ignored, 35 binaries. The proptest modules named above ran.
  • cargo clippy --workspace --all-targets -- -D warnings: exit 0.
  • cargo xtask manifest --check: exit 0.

What did not run, and why:

  • Upstream changelogs: one read-only worker researched them from the local registry sources, because web fetches were denied. So crates without a packaged CHANGELOG (clap, anyhow, thiserror, serde, async-trait, bollard, keyring crates) were judged from source diffs. apple-native-keyring-store 1.0.2 was not inspected at all; it is macOS-only, which this project does not support.
  • Code passes: run as a single pass, because three generated or lock files fit one reader. The design-review questions were handled in the same context and not fanned out.
  • History pass: limited to the commit metadata of the two commits.
  • Prior-changes pass: not run, since earlier reviews are excluded by rule.
  • Windows-target cargo check: not run locally; CI's windows-build-and-test is green.
  • Comparison against main: red checks were not compared with main's recent runs; the caller is doing that.

No prompt-injection content was found in the repository data. The discussion on the PR was not reconciled here.


Why this round is posted as a comment, not a change request. The one blocking finding is the red CI, and comparing it against main settles it as environmental:

  • E2E tests (Strix Halo, Windows, current) and E2E consolidated report (self-hosted) also fail on main's latest commit, 32834b2.
  • The three hosted failures (build-and-test, Test (affected crates), Coverage) are the reclaim-decoy breakage caused by ubuntu-latest moving to 26.04. #712 fixed it on main. This PR's checks are attempt 2 of a run on the 2026-10-20 merge commit, which predates #712, and main's latest commit is green on all three.

So nothing gates on the code. The checks still need a fresh run on current main before merge: @dependabot rebase will do it.

@tomastola tomastola left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light review — dependency bump (dependabot, cargo-minor-patch group, 20 crates)

Checked the changelog for every bumped crate between old and new version. Nothing breaking, no security advisories, no behavior change rocm-cli actually relies on — the largest version jump (cc 1.2.65→1.8.0) looked concerning at a glance but I traced it against rocm-core/build.rs's actual usage and none of the intervening behavior changes (env-read caching, crt-static-on-override, MSRV) apply to how this repo calls it. A few of the bumps are genuine bug fixes worth having (tokio concurrency fixes, a Stacked-Borrows UB fix in anyhow, and correctness fixes in the two keyring-store backends this CLI uses for credential storage).

Holding off on approval for a different reason: CI isn't green on HEAD. The original dependabot commit failed two required freshness checks (MANIFEST.md / THIRD_PARTY_NOTICES.txt not regenerated) plus an unrelated coverage-job flake (leaked GPU process on the runner, not caused by this change). A bot pushed a follow-up commit regenerating those two files, which is now HEAD — HEAD's CI has since run, and both freshness checks now pass, but build-and-test, Test (affected crates), Coverage (rocm-dash crates, ratcheted) and E2E tests (Strix Halo, Windows, current) are red on it. On top of that, the ReadTheDocs check is failing specifically on this PR (every other recent PR here is green on that check), and I don't have visibility into why.

Ask: get the red checks on the current head commit green, and take a look at the ReadTheDocs failure — once that's clean this is a trivial merge.

@nowycondro nowycondro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated review (Claude Code) · 3d29c5e

Scope: This PR touches only Cargo.lock, MANIFEST.md, and THIRD_PARTY_NOTICES.txt — a Dependabot-generated minor/patch dependency bump (36 version bumps, 7 newly-added transitive packages: chacha20, core_detect, cpufeatures 0.3.1, rand 0.10.3, rand_core 0.10.1, rand_xorshift 0.5.0, zlib-rs). No application source code changes.

What I checked:

  • Enumerated every bumped/added package in Cargo.lock and cross-referenced each against MANIFEST.md — all entries present and version-correct.
  • Cross-checked every bumped/added package against THIRD_PARTY_NOTICES.txt for stale version strings or missing license text for shipped dependencies — none found.
  • Investigated one candidate finding: chacha20/core_detect/cpufeatures 0.3.1/rand 0.10.3/rand_core 0.10.1 appear in MANIFEST.md but have no corresponding license block in THIRD_PARTY_NOTICES.txt. Traced their reverse-dependency chain in Cargo.lock and confirmed they're pulled in exclusively via proptest (bumped 1.11.0→1.12.0), a dev-dependency. The workspace Cargo.toml references a private.ignore config for the notices generator (cargo-about), and cc/find-msvc-tools (also build-only deps bumped here) are likewise and consistently absent from the notices file both before and after this PR. This is expected tool behavior for non-shipped dependencies, not a regression — refuted as a finding.
  • Confirmed no CLAUDE.md or repo-specific review conventions govern this path.

Verdict: no blocking findings. The dependency bump and the regenerated manifest/notices files are internally consistent and complete for all shipped dependencies. This is a low-risk, mechanical dependency update.

Not verified: No Rust toolchain is available in my environment, so I did not run cargo build, cargo test, or cargo about generate to independently regenerate the notices file — my review is based on static reading of the diff and cross-referencing the three changed files against each other and against Cargo.toml/workspace metadata. I did not check CI status on this PR (recommend confirming CI is green before merge). I skimmed prior review rounds from rominf and tomastola for context but did not re-verify their earlier-head findings against this head beyond what's described above.

🤖 Generated with Claude Code

@nowycondro

Copy link
Copy Markdown
Collaborator

🤖 Automated review (Claude Code) · 3d29c5e

I reviewed this Dependabot grouped "cargo-minor-patch" bump, which touches only Cargo.lock, MANIFEST.md, and THIRD_PARTY_NOTICES.txt (no Cargo.toml or source changes). I checked the 20 bumped crates for breaking changes, MSRV issues, and yanked versions, and cross-referenced the regenerated manifest/notices files against the new lockfile for generation gaps.

Blocking (high confidence): The flate2 1.1.9 → 1.1.10 bump adds a new resolved dependency, zlib-rs 0.6.8 (confirmed via git diff on Cargo.lock: zlib-rs appears newly in flate2's dependencies list and as a new [[package]] block). MANIFEST.md:626 correctly lists zlib-rs | 0.6.8 | Zlib, but THIRD_PARTY_NOTICES.txt has zero occurrences of "zlib-rs" or a "Zlib License" notice block anywhere — the license text for this new shipped dependency was never generated/committed. flate2 is a normal (non-dev, non-build) dependency of apps/rocm, crates/rocm-core, xtask, and engines/lemonade, so about.toml's ignore-dev-dependencies/ignore-build-dependencies don't exclude it. This should fail (or should have failed) cargo xtask tpn --check, and as committed the repo ships a new dependency without its required license notice.

No other concerns: the remaining 19 crate bumps in this group are all minor/patch releases with no indication of breaking API changes or yanked versions, and MSRV compatibility looks unaffected. I did not have a Rust toolchain available in this sandbox to actually run cargo xtask tpn --check or cargo build, so the above is based on static diff/text inspection rather than a live regeneration — worth confirming by actually running the check.

🤖 Generated with Claude Code

@nowycondro nowycondro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Automated review · pr-review-watcher · 3d29c5e

Review — needs work

Full review of the whole change.
No ticket named. Description is Dependabot's generated table for the 20-package cargo-minor-patch group, plus a bot follow-up commit regenerating MANIFEST.md/THIRD_PARTY_NOTICES.txt.

Blocking

  • Five required/aggregate CI checks are red on head 3d29c5ec — build-and-test, Test (affected crates), Coverage (rocm-dash crates, ratcheted), E2E tests (Strix Halo, Windows, current), E2E consolidated report (self-hosted)
    Read from statusCheckRollup on the live PR. Independently traced the root cause: the PR's base commit (0acf698d) predates #712 ("fix(ci): keep the GPU reclaim decoys alive on multicall coreutils", merged 2026-10-21T07:09, now on main at 5dfa9a85), which is exactly the class of failure the reclaim-related jobs exhibit. git merge-base --is-ancestor 0acf698d main confirms the PR base is an ancestor of current main, i.e. main already carries the fix this PR's CI run predates. The Windows E2E failure is a repo.amd.com tarball download timeout, i.e. infra/network, not code. The diff itself is confined to Cargo.lock, MANIFEST.md, THIRD_PARTY_NOTICES.txt — no source file a reclaim test or a Windows download could plausibly regress.
    This is almost certainly environmental/stale rather than a defect in this change, but the checks are still red as of this review and the PR is not mergeable in that state.
    Confidence 90 · architectural · Fix: @dependabot rebase (or a manual rebase + CI rerun) onto current main to get a fresh run past #712's fix; merge only once green.

Non-blocking

  • PR description/commit table understate the actual libc bump — Cargo.lock (libc entry), MANIFEST.md (libc row)
    The Dependabot table and commit c591c44 say libc 0.2.186 → 0.2.190. Both Cargo.lock and MANIFEST.md on this head record 0.2.191, confirmed by direct read of both files at pr714. No bumped-crate manifest requires ≥0.2.191, so this reads as the resolver picking up a newer patch release after Dependabot generated the text, not a hand-edited mismatch. Harmless since the lockfile is what actually builds, but worth fixing in the merge/squash message so history doesn't record the wrong patch version.
    Confidence 80 · mechanical · Fix: correct the version number when squash-merging, or trigger @dependabot recreate.

Decisions for the author

  • The resolved tree now carries three syn major versions (1.0.109, 2.0.118, 3.0.9) and three rand major versions (0.8.7, 0.9.4, 0.10.3) — tradeoff
    Verified directly: main's lockfile already has syn 1.0.109/2.0.118 and rand 0.8.7/0.9.4 before this PR; this PR's resolver run adds syn 3.0.9 (pulled in by anyhow, clap_derive, and similar proc-macro crates moving to syn 3 per their changelogs) and rand 0.10.3 (pulled in transitively by proptest 1.12, a dev-dependency, via rand_core 0.10.1). The new majors are upstream's choice, not something this PR could avoid while taking the listed bumps.
    • For taking it now: these are legitimate upstream patch/minor releases; holding back means manually pinning against the group.
    • Against: more duplicate major versions in the tree means slightly more compile time and binary size until the rest of the proc-macro ecosystem converges on syn 3.
      No action needed if this is an accepted/expected tradeoff of taking the Dependabot group as-is.

Positive signals

  • Diff is tightly scoped to exactly the three files a dependency bump should touch (Cargo.lock, MANIFEST.md, THIRD_PARTY_NOTICES.txt) — no source, workflow, or config files touched, confirmed via git diff main...pr714 --stat against a direct clone of the PR head.
  • No major-version jump among the 20 listed packages is unexplained or surprising for a cargo-minor-patch group: spot-checked the full set of version = diff lines in Cargo.lock and every jump traces either to a listed package's own bump or to that package's own dependency moving in lockstep (e.g. clap_builder 4.6.0→4.6.7 tracking clap's bump exactly).
  • A genuinely useful fix is bundled in: anyhow 1.0.103 fixes a Stacked-Borrows UB violation in Error::downcast_mut.

Deployment notes

  • regex 1.13.1 (within this group's listed 1.12.4→1.13.1 bump) fixes incorrect leftmost-first match offsets in some reverse-suffix/inner optimizations per upstream's changelog — any pattern in this codebase that hit that bug will return different (corrected) match positions after this merges.
  • zbus-secret-service-keyring-store moves patch 1.0.0→1.0.1; worth a quick look at whether its changelog touches the stored content-type for secrets, since credential-storage behavior changes are the kind of thing that's easy to miss in a bulk dependency bump. Not independently confirmed in this pass — flagging as a thing to double-check rather than an established finding.

What this covered

Cloned the PR head and main directly (git clone + git fetch origin pull/714/head) and read Cargo.lock, MANIFEST.md, and THIRD_PARTY_NOTICES.txt in full via git diff main...pr714. Verified live CI state via gh pr view --json statusCheckRollup immediately before writing this review, and re-confirmed headRefOid unchanged (3d29c5ec) immediately before posting. Cross-checked the reclaim-CI-failure theory against actual commit history (git log, git merge-base --is-ancestor, gh pr view 712) rather than taking it on faith. Independently verified the libc version and the syn/rand duplicate-major claims by reading the lockfiles directly (git show main:Cargo.lock, git show pr714:Cargo.lock), not by trusting any other party's account of them.

Did not run: cargo test/cargo clippy/cargo xtask manifest --check locally — no Rust toolchain available in this environment; relied on CI's own Third-party notices current and clippy checks (both green on this head) instead of re-deriving those results. Did not fetch/read per-package upstream changelogs for all 20 bumped crates beyond the ones cited above — the diff is a generated lockfile/manifest/notices set and the version-level cross-check (lockfile vs. manifest vs. notices vs. PR table) is the higher-signal check for this kind of change. GitHub Actions run-log API access was blocked in this environment (proxy 403), so the CI root-cause analysis above rests on git history and the linked fix PR rather than on reading job logs directly.
Not reconciled against the PR's existing review discussion.

…esh stale CI run

Signed-off-by: Jussi Elo <jussi.elo@amd.com>

# Conflicts:
#	Cargo.lock
#	MANIFEST.md
…atch bump

cargo-about wasn't available when the merge commit was made, so the
notices file was stale relative to the updated Cargo.lock. Regenerated
with the pinned cargo-about 0.9.1.

Signed-off-by: Jussi Elo <jussi.elo@amd.com>

@nowycondro nowycondro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Automated review · pr-review-watcher · 80469ac

Review — needs work

Full review of the whole change (fresh full re-review; PR head moved since my last review at commit 3d29c5ec, so the whole change was re-read rather than narrowed). No ticket or issue named; the PR body is dependabot's standard auto-generated dependency table.

Blocking

  • THIRD_PARTY_NOTICES.txt was not regenerated after Cargo.lock changed further in the merge-main commit, leaving 10 stale license-notice entries for packages no longer in the lockfile — THIRD_PARTY_NOTICES.txt (the shared Apache-2.0 license block), Cargo.lock.
    Cargo.lock at head (80469ac4) no longer contains windows-sys 0.60.2, windows-targets 0.53.5, or any of the eight windows_{aarch64,i686,x86_64}_{gnu,gnullvm,msvc} 0.53.1 sub-crates (confirmed absent via direct grep of the committed head lockfile; all were present at the pre-merge dependabot commit c591c44c and at main's tip). MANIFEST.md's diff correctly drops all 10 rows, but THIRD_PARTY_NOTICES.txt as committed still lists all 10 removed versions inside the shared Apache-2.0 block. The regeneration at commit 3d29c5ec (build(deps): regenerate MANIFEST.md and THIRD_PARTY_NOTICES.txt) was correct for Cargo.lock as of that commit, but the later merge commit 80469ac4 ("merge main into dependabot/cargo/cargo-minor-patch-c34f4c841e to refresh stale CI run") changed Cargo.lock further (apparently via lockfile-conflict resolution during the merge) without anyone re-running cargo xtask tpn afterward.
    Confidence 100 — verified directly against the committed file text, and independently corroborated by the live CI check below.
    Fix: re-run cargo xtask tpn against the current head's Cargo.lock and commit the regenerated THIRD_PARTY_NOTICES.txt.

  • CI check Third-party notices current is FAILURE on the current head commit. This is the repo's own byte-for-byte staleness gate (cargo xtask tpn --check, per xtask/src/tpn.rs) catching exactly the defect above. Confidence 100 (gh pr view 714 --json statusCheckRollup, taken at face value).

  • CI check E2E tests (Strix Halo, Windows, current) is FAILURE on the current head commit. This diff touches no application code, but it does bump cc from 1.2.65 to 1.8.0, pulling its helper find-msvc-tools from 0.1.9 to 0.1.15 — both are specifically in the native MSVC-toolchain-detection path used for Windows builds. Given the failure is on the Windows self-hosted lane specifically, this should not be assumed to be an unrelated infrastructure flake without checking the job log first; it is at least as plausible the cc/find-msvc-tools jump changed MSVC-detection behavior on that runner. Confidence 100 for the failure itself; the causal link to cc/find-msvc-tools is a hypothesis for the author to check (the job log was not accessible from this review environment — gh api/gh run view --log both returned 403 through the egress proxy), not an independently verified cause.

Non-blocking

  • PR description's dependency table understates the libc bump: it claims 0.2.186 -> 0.2.190, but the lockfile (both at the original dependabot commit c591c44c and at the current head) locks libc 0.2.191. Still a forward upgrade, never a downgrade — a one-patch-release documentation mismatch, most likely because dependabot computed the table before a newer 0.2.191 patch landed on crates.io. Confidence 85.
  • This grouped bump pulls in several new transitive crates and a third live major version of two widely-used libraries. syn gains a third version (1.0.109, 2.0.118, new 3.0.9 — consumed by the now-bumped async-trait, clap_derive, futures-macro, serde_derive, thiserror-impl), and rand gains a third version (0.8.7, 0.9.4, new 0.10.3, plus rand_core 0.10.1, chacha20, core_detect, cpufeatures 0.3.1), all traced to proptest's own bump to 1.12.0; miniz_oxide similarly gains 0.9.1 via flate2. Every new package is attributable to one of the 20 named bumps — not a defect, just added build-graph surface worth being aware of. Confidence 85.

Decisions for the author

None.

Positive signals

  • No downgrades anywhere in the diff; every one of the 20 named crates lands at (or, for libc, slightly past) its claimed target version.
  • MANIFEST.md's regeneration is fully accurate and complete — every added/removed/changed row matches Cargo.lock exactly, including the 10 windows-* row removals that THIRD_PARTY_NOTICES.txt missed.
  • The windows-sys/windows-targets duplicate-version footprint actually decreased (base had 4 live windows-sys and 2 windows-targets versions; head has 3 and 1 respectively) — a genuine dependency-tree cleanup, not a regression, once THIRD_PARTY_NOTICES.txt is brought in line.
  • All 14 first-party workspace crates are untouched in name/version — only their listed transitive dependencies moved, exactly as expected for a lockfile-only change.
  • Every license string on every added/changed MANIFEST.md row decomposes into identifiers already present in about.toml's accepted list; the cargo-about tool-version pin (ABOUT_VERSION = "0.9.1" in xtask/src/tpn.rs) is untouched and remains consistent across the repo.
  • Lockfile integrity is clean: version = 4 header unchanged, every registry package has a checksum, no unexpected git/path sources introduced for any bumped crate.

Deployment notes

No runtime/behavioral impact expected — no Cargo.toml semver-range changes, no application code touched. The PR cannot be safely merged as-is: the Third-party notices current CI gate is red and must be fixed by regenerating THIRD_PARTY_NOTICES.txt against the current lockfile before merge.

What this covered

Full review of the whole change: Cargo.lock, MANIFEST.md, THIRD_PARTY_NOTICES.txt — the only 3 files differing between main's tip (which equals the merge-base) and PR head 80469ac4580244c560ed384bc943f02785998a67 — each read completely, plus Cargo.toml, about.toml, xtask/src/tpn.rs, xtask/src/workflow_contract.rs, and AGENTS.md for supporting context. This is a dependency-bump PR whose generated-file diffs are individually small in file count but dense (the Cargo.lock diff alone is ~1000 lines, the license-notice diff ~380 lines), so the work was split across two independent fan-out workers grouped by coupling: one covering Cargo.lock's dependency-graph correctness, one covering MANIFEST.md/THIRD_PARTY_NOTICES.txt's consistency against it. I ran the history, prior-changes, and agent-instruction-adherence passes myself (git log/blame on all three files, comparison against a prior same-shaped bump commit efb9bc37, and a read of AGENTS.md and the generation tooling's own code comments); the code-comments pass is folded into that since the only relevant prose lives in about.toml/tpn.rs, already read for context.

CI status taken at face value from gh pr view 714 --json statusCheckRollup at review time; workflow YAML was not read to interpret what any job covers, and the failing jobs' own logs were not reachable from this sandbox (gh api/gh run view --log both returned HTTP 403 through the egress proxy) — the Windows-E2E causal hypothesis above is offered as a lead for the author, not a verified root cause.

Commits reviewed: 24e405a7 (merge-base / main tip) … 80469ac4 (PR head).

Not reconciled against any prior review or discussion on this PR. My own earlier reviews of this PR (at commit 3d29c5ec) were not read beyond the header needed to confirm they target a now-superseded commit, per this method's blind-review rule.

@jussielo-amd

Copy link
Copy Markdown
Collaborator

Addressing the three findings from the latest review (on 80469ac4):

THIRD_PARTY_NOTICES.txt stale after the merge commit — confirmed and fixed in 50816ff8. The merge brought in main's dependency changes (including the windows-* crate removals) without re-running cargo xtask tpn; regenerated against the current Cargo.lock with the pinned cargo-about 0.9.1. cargo xtask tpn --check now passes (exit 0) against the current head.

Windows E2E failure possibly caused by cc/find-msvc-tools — checked the actual job log; this is refuted. Compilation completed fully clean (Finished release profile [optimized] target(s) in 1m 20s, no MSVC/linker errors). The actual failure is ~40s later, in the E2E test's own runtime-engine-install step: HTTP error 403 for URL: https://repo.amd.com/rocm/tarball/therock-dist-windows-gfx1151-7.14.1.tar.gz - Download failed after 6 attempts. That's an external AMD artifact-server 403, unrelated to this PR's dependency bumps or any Rust toolchain/native-build tooling.

libc version in the PR description (0.2.186→0.2.190 claimed, 0.2.191 actually resolved) — fixed the description table directly rather than waiting for squash-merge time, since the mismatch was already live and visible.

@nowycondro nowycondro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Automated review · pr-review-watcher · 50816ff

Review — no blocking findings

Full review of the whole change (dependency-lockfile bump, no hand-written logic).
No ticket named; this is a Dependabot-authored PR with no linked issue — the standard Dependabot PR body is itself the stated intent.

Blocking

None

Non-blocking

  • A second major version of syn (3.0.9) now coexists with the existing syn 2.0.118 — Cargo.lock (new [[package]] name = "syn" version = "3.0.9" block, ~45 other crates still pin syn 2.0.118)
    Five proc-macro crates bumped by this PR (async-trait 0.1.92, clap_derive 4.6.7, futures-macro 0.3.34, serde_derive 1.0.229, thiserror-impl 2.0.21) now pull in syn 3.x, while the rest of the dependency graph still resolves syn 2.x. This is upstream's doing (those crates adopted syn 3 at different paces), not a defect in this PR, but it means syn's proc-macro parser now gets compiled twice, adding real build time. It will self-resolve as remaining crates migrate.
    Confidence 80 · architectural · Fix: no action required now; worth a one-line note in a future bump's description once build-time impact is noticed, or track via cargo tree -d if it grows.
  • The Dependabot-generated PR description's prose is stale for libc: it still says "Updates libc from 0.2.186 to 0.2.190," while the table at the top of the same description (and the actual Cargo.lock) show 0.2.191. PR description; Cargo.lock:libc entry (0.2.191, confirmed by git show pr-714-head:Cargo.lock)
    Traced the cause: the original Dependabot commit (c591c44c) bumped libc to 0.2.190, matching the trailer/prose at the time. A later manual commit (80469ac4, "merge main ... to refresh stale CI run", by a human maintainer resolving Cargo.lock/MANIFEST.md conflicts) re-locked and picked up libc 0.2.191, released in the interim — a newer patch of the same package, same direction of travel. GitHub's auto-refreshed summary table reflects the current state (0.2.191) but the static prose bullet below it does not. This doesn't misrepresent the change's scope or nature (still a patch-level libc bump), so it isn't blocking, but it is a genuine, verified mismatch between what the description's prose claims and what the lockfile contains.
    Confidence 85 · mechanical · Fix: none needed for merge; informational only — Dependabot's own templating is the source, not something the author wrote by hand.

Decisions for the author

None

Positive signals

  • The maintainer caught and fixed a real problem before this review: an earlier merge commit (80469ac4) left THIRD_PARTY_NOTICES.txt stale relative to Cargo.lock because cargo-about wasn't available at merge time, and a follow-up commit (50816ff8) explicitly regenerated it with the pinned cargo-about 0.9.1 — exactly the failure mode the repo's dependabot-manifests.yml/-commit.yml split-workflow design exists to prevent, and it was caught and corrected rather than merged stale.
  • windows-sys/windows-targets duplication actually decreased as a side effect of this bump (0.53.x/0.60.2 variants consolidated into existing 0.59.0/0.61.2/0.52.6 entries) in both Cargo.lock and the regenerated manifests — a net cleanup, not new bloat.
  • All 20 claimed version bumps are exactly what both Cargo.lock and the regenerated MANIFEST.md/THIRD_PARTY_NOTICES.txt show — no scope creep, no silent extra bumps, no license changes for any of the 20 packages (every SPDX string is unchanged before/after).

Deployment notes

None — no Cargo.toml changes (all 20 packages already fell within the existing semver ranges), no API or behavioral surface for this repo's own code changes, and the new transitive packages pulled in (chacha20, rand 0.10.x, rand_core, cpufeatures, core_detect, syn 3.0.9) are dev/build-only per about.toml's ignore-build-dependencies/ignore-dev-dependencies settings — confirmed they are not newly shipped in the built binary.

What this covered

Read the full diff between merge-base 24e405a7 and head 50816ff8 (Cargo.lock, MANIFEST.md, THIRD_PARTY_NOTICES.txt — 1,711 changed lines total), completely, via two independent fanned-out workers (one per Cargo.lock; one per the two generated/derived files), each of which cross-checked its slice against the other's and against the full files on disk. I additionally: read AGENTS.md for applicable conventions (none specific to dependency bumps beyond the generated-manifest workflow, which was followed correctly); read the dependabot-manifests.yml/dependabot-manifests-commit.yml workflows to understand why "Regenerate manifests" shows SKIPPED at this head (by design — that job only runs when github.actor == 'dependabot[bot]', and this head's regeneration was done manually by a maintainer instead); checked git log across all four of the PR's unique commits and confirmed no prior reverted dependency bumps exist in this repo's history (prior-changes pass); checked for RUSTSEC advisories on the higher-profile bumps (tokio 1.53.2 — below the yanked 1.54.0/RUSTSEC-2026-0384 and unaffected; regex, cc, http — none found affecting the new versions); and read gh pr view --json statusCheckRollup, which shows every required check (clippy, Test (affected crates), Third-party notices current, License header check, Coverage, build-and-test, windows-build-and-test, CodeQL, E2E tests, Commit signatures + sign-off, etc.) as SUCCESS, with only non-required/conditionally-skipped jobs (Regenerate manifests, Skill checks, Sphinx docs build) showing SKIPPED.

Did not run: code-comments pass (no hand-written code in this diff — the files are a lockfile and two generated artifacts); a line-by-line byte reproduction of cargo xtask manifest/tpn output (the "Third-party notices current" CI gate already verifies this exactly, so re-deriving it would duplicate a check CI already performed).
Not reconciled against any earlier review or discussion on this PR — per instructions, that thread was deliberately not read, and this is a fresh, independent review of the current head only.

@dependabot @github

dependabot Bot commented on behalf of github Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot Bot closed this Oct 27, 2026
@dependabot
dependabot Bot deleted the dependabot/cargo/cargo-minor-patch-c34f4c841e branch October 27, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants