Repository navigation
chore(deps): bump the cargo-minor-patch group across 1 directory with 20 updates - #714
dependabot[bot] wants to merge 4 commits into
Conversation
… 20 updates Bumps the cargo-minor-patch group with 20 updates in the / directory: | Package | From | To | | --- | --- | --- | | [anyhow](https://github.com/dtolnay/anyhow) | `1.0.102` | `1.0.104` | | [clap](https://github.com/clap-rs/clap) | `4.6.1` | `4.6.7` | | [clap_complete](https://github.com/clap-rs/clap) | `4.6.5` | `4.6.11` | | [keyring-core](https://github.com/open-source-cooperative/keyring-core) | `1.0.0` | `1.0.1` | | [libc](https://github.com/rust-lang/libc) | `0.2.186` | `0.2.190` | | [serde](https://github.com/serde-rs/serde) | `1.0.228` | `1.0.229` | | [serde_json](https://github.com/serde-rs/json) | `1.0.150` | `1.0.154` | | [tokio](https://github.com/tokio-rs/tokio) | `1.52.3` | `1.53.2` | | [flate2](https://github.com/rust-lang/flate2-rs) | `1.1.9` | `1.1.10` | | [apple-native-keyring-store](https://github.com/open-source-cooperative/apple-native-keyring-store) | `1.0.0` | `1.0.2` | | [zbus-secret-service-keyring-store](https://github.com/open-source-cooperative/zbus-secret-service-keyring-store) | `1.0.0` | `1.0.1` | | [proptest](https://github.com/proptest-rs/proptest) | `1.11.0` | `1.12.0` | | [regex](https://github.com/rust-lang/regex) | `1.12.4` | `1.13.1` | | [cc](https://github.com/rust-lang/cc-rs) | `1.2.65` | `1.8.0` | | [thiserror](https://github.com/dtolnay/thiserror) | `2.0.18` | `2.0.21` | | [bollard](https://github.com/fussybeaver/bollard) | `0.21.0` | `0.21.1` | | [tokio-util](https://github.com/tokio-rs/tokio) | `0.7.18` | `0.7.20` | | [futures](https://github.com/rust-lang/futures-rs) | `0.3.32` | `0.3.34` | | [async-trait](https://github.com/dtolnay/async-trait) | `0.1.89` | `0.1.92` | | [http](https://github.com/hyperium/http) | `1.4.2` | `1.5.0` | Updates `anyhow` from 1.0.102 to 1.0.104 - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.102...1.0.104) Updates `clap` from 4.6.1 to 4.6.7 - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/main/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.6.1...clap_complete-v4.6.7) Updates `clap_complete` from 4.6.5 to 4.6.11 - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/main/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.6.5...clap_complete-v4.6.11) Updates `keyring-core` from 1.0.0 to 1.0.1 - [Release notes](https://github.com/open-source-cooperative/keyring-core/releases) - [Commits](open-source-cooperative/keyring-core@v1.0.0...v1.0.1) Updates `libc` from 0.2.186 to 0.2.190 - [Release notes](https://github.com/rust-lang/libc/releases) - [Changelog](https://github.com/rust-lang/libc/blob/0.2.190/CHANGELOG.md) - [Commits](rust-lang/libc@0.2.186...0.2.190) Updates `serde` from 1.0.228 to 1.0.229 - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.228...v1.0.229) Updates `serde_json` from 1.0.150 to 1.0.154 - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.150...v1.0.154) Updates `tokio` from 1.52.3 to 1.53.2 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.52.3...tokio-1.53.2) Updates `flate2` from 1.1.9 to 1.1.10 - [Release notes](https://github.com/rust-lang/flate2-rs/releases) - [Commits](rust-lang/flate2-rs@1.1.9...1.1.10) Updates `apple-native-keyring-store` from 1.0.0 to 1.0.2 - [Release notes](https://github.com/open-source-cooperative/apple-native-keyring-store/releases) - [Commits](open-source-cooperative/apple-native-keyring-store@v1.0.0...v1.0.2) Updates `zbus-secret-service-keyring-store` from 1.0.0 to 1.0.1 - [Release notes](https://github.com/open-source-cooperative/zbus-secret-service-keyring-store/releases) - [Commits](open-source-cooperative/zbus-secret-service-keyring-store@v1.0.0...v1.0.1) Updates `proptest` from 1.11.0 to 1.12.0 - [Release notes](https://github.com/proptest-rs/proptest/releases) - [Changelog](https://github.com/proptest-rs/proptest/blob/main/CHANGELOG.md) - [Commits](proptest-rs/proptest@v1.11.0...v1.12.0) Updates `regex` from 1.12.4 to 1.13.1 - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.12.4...1.13.1) Updates `cc` from 1.2.65 to 1.8.0 - [Release notes](https://github.com/rust-lang/cc-rs/releases) - [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/cc-rs@cc-v1.2.65...cc-v1.8.0) Updates `thiserror` from 2.0.18 to 2.0.21 - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@2.0.18...2.0.21) Updates `bollard` from 0.21.0 to 0.21.1 - [Release notes](https://github.com/fussybeaver/bollard/releases) - [Changelog](https://github.com/fussybeaver/bollard/blob/master/RELEASE.md) - [Commits](fussybeaver/bollard@v0.21.0...v0.21.1) Updates `tokio-util` from 0.7.18 to 0.7.20 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-util-0.7.18...tokio-util-0.7.20) Updates `futures` from 0.3.32 to 0.3.34 - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.32...0.3.34) Updates `async-trait` from 0.1.89 to 0.1.92 - [Release notes](https://github.com/dtolnay/async-trait/releases) - [Commits](dtolnay/async-trait@0.1.89...0.1.92) Updates `http` from 1.4.2 to 1.5.0 - [Release notes](https://github.com/hyperium/http/releases) - [Changelog](https://github.com/hyperium/http/blob/master/CHANGELOG.md) - [Commits](hyperium/http@v1.4.2...v1.5.0) --- updated-dependencies: - dependency-name: anyhow dependency-version: 1.0.104 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: clap dependency-version: 4.6.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: clap_complete dependency-version: 4.6.11 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: keyring-core dependency-version: 1.0.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: libc dependency-version: 0.2.190 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: serde dependency-version: 1.0.229 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: serde_json dependency-version: 1.0.154 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: tokio dependency-version: 1.53.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-minor-patch - dependency-name: flate2 dependency-version: 1.1.10 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: apple-native-keyring-store dependency-version: 1.0.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: zbus-secret-service-keyring-store dependency-version: 1.0.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: proptest dependency-version: 1.12.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-minor-patch - dependency-name: regex dependency-version: 1.13.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-minor-patch - dependency-name: cc dependency-version: 1.8.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-minor-patch - dependency-name: thiserror dependency-version: 2.0.21 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: bollard dependency-version: 0.21.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: tokio-util dependency-version: 0.7.20 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: futures dependency-version: 0.3.34 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: async-trait dependency-version: 0.1.92 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: cargo-minor-patch - dependency-name: http dependency-version: 1.5.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: cargo-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Generated by `cargo xtask manifest` and `cargo xtask tpn` for the dependency change in this pull request. Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rominf
left a comment
There was a problem hiding this comment.
🔴 Automated review · pr-review-watcher · 3d29c5e
This automation never files a GitHub approval, so no approving review will
appear here whatever the outcome — the merge decision stays with a human
reviewer.
Review — needs work
Full review of the whole change.
No ticket named. The description is Dependabot's generated table of 20 group updates, plus a bot commit that regenerates MANIFEST.md and THIRD_PARTY_NOTICES.txt.
Blocking
-
(new) Four required CI checks are red on this head commit —
build-and-test,Test (affected crates),Coverage (rocm-dash crates, ratcheted),E2E tests (Strix Halo, Windows, current)(andE2E consolidated report (self-hosted), which aggregates them)
Read fromstatusCheckRollupand the job logs:Test (affected crates)andCoverage:xtask/src/workflow_contract.rs:2925fails inpreflight_runs_the_real_reclaim_assert_clear. The message is "a real leaked engine process was running and the preflight passed", withleft: 0, right: 1. The Coverage job then stops with "fix the failing tests before checking coverage floors".build-and-test: thereclaim-gpu.shself-test step fails with "FAIL: could not read a decoy's command line; the regression guard tested nothing" and "containment breached; refusing to run the real reclaim".- Windows E2E:
Failed to download TheRock from: https://repo.amd.com/rocm/tarball/therock-dist-windows-gfx1151-7.14.1.tar.gz - Download failed after 6 attempts.
The evidence says these are not caused by this change:
- Both reclaim failures exercise
scripts/reclaim-gpu.sh, a shell script that no bumped crate touches. - The same xtask test passes locally on this head. It is in the 4179 passed / 0 failed / 16 ignored across 35 test binaries from
cargo test --workspace --all-targets, and the nameworkflow_contract::tests::preflight_runs_the_real_reclaim_assert_clear ... okappears in the log. - The Windows failure is a network download from an external host.
They are still red, though, and the change is not mergeable until they are green or shown to be the same failures main has.
Confidence 100 · architectural · Fix: rerun the failed jobs, or confirm against main's recent runs that these failures are pre-existing. Do not change code in this PR for them.
Non-blocking
- (new) The description and commit message give the libc target as 0.2.190, but the lockfile has 0.2.191 —
Cargo.lock(libcentry),MANIFEST.md(libcrow), commitc591c44message
The PR body and commit table say`0.2.186` | `0.2.190`. Cargo.lock, MANIFEST.md and THIRD_PARTY_NOTICES all record0.2.191. The lockfile governs, because it is what gets built. No workspace or bumped-crate manifest requires ≥0.2.191 (tokio and tokio-util ask for0.2.168), so this looks like the resolver picking up a newer patch after Dependabot wrote the text. The scope is right (the libc bump is mentioned); only the patch number is wrong. Squash-merging keeps the wrong number in history.
Confidence 85 · mechanical · Fix: edit the squash commit message at merge time, or@dependabot recreate.
Decisions for the author
-
The dependency tree now carries three
synmajors (1.0.109, 2.0.118, 3.0.9) and tworandlines (0.9.4 runtime, 0.10.3 test-only via proptest) — tradeoff
The new duplicates come from async-trait, clap_derive, serde_derive, futures-macro and thiserror-impl moving to syn 3, while other proc-macros stay on syn 2. Proptest 1.12 moved to rand 0.10, and the workspace still pinsrand = "0.9".- For taking it now: these are upstream patch/minor releases, and holding them back means pinning.
- Against: compile time and binary size grow until the rest of the ecosystem moves to syn 3.
No action is needed if this was accepted knowingly.
Positive signals
- The regenerated manifests are consistent with the lockfile:
cargo xtask manifest --checkexits 0 locally, and CI'sThird-party notices currentis green.- THIRD_PARTY_NOTICES correctly leaves out
zlib-rsand the dev-onlychacha20/rand 0.10.zlib-rsis only in the lockfile because of flate2's new weakruntime_detectionfeature;cargo tree -e features -i zlib-rs --target allprints nothing, so it is never compiled.
- Every new or bumped crate's licence is in
about.toml's accepted list, includingzlib-rs(Zlib). - Every MSRV checked is ≤1.96; the highest are proptest 1.12 and zbus-secret-service-keyring-store at 1.88.
Deployment notes
zbus-secret-service-keyring-store1.0.1 now stores secrets with content typeapplication/octet-streaminstead oftext/plain. This comes from the source diff. Reading back secrets stored by earlier builds is unaffected, but an external tool that filters Secret Service items by content type would see new items differently.regex1.13.1 fixes wrong leftmost-first match offsets in some reverse-suffix/inner optimizations. Any pattern that hit that bug will now return different (correct) match positions.
What this covered
Every file in the change was read completely: Cargo.lock, MANIFEST.md, THIRD_PARTY_NOTICES.txt. Range: 0acf698d9d8f…3d29c5ece2d2 (merge-base with prw-base to head).
Beyond the diff:
- Every workspace consumer of
flate2,proptest,ccandlibc. - The proptest code that goes beyond the macro:
crates/rocm-core/src/archive_props.rs(fixedRngSeed),examine_driver_proptests.rs,apps/rocm/src/deletion_properties.rs, and the committedproptest-regressions/files. - proptest 1.11 vs 1.12
rng.rs, its CHANGELOG ("preserving seed formats and seeded RNG output"), and rand_core 0.9 vs 0.10seed_from_u64(same PCG32 expansion).
Run locally in the checkout's own target/, with RUSTC_WRAPPER= and no shared target dir:
cargo test --workspace --all-targets: exit 0, 4179 passed, 0 failed, 16 ignored, 35 binaries. The proptest modules named above ran.cargo clippy --workspace --all-targets -- -D warnings: exit 0.cargo xtask manifest --check: exit 0.
What did not run, and why:
- Upstream changelogs: one read-only worker researched them from the local registry sources, because web fetches were denied. So crates without a packaged CHANGELOG (clap, anyhow, thiserror, serde, async-trait, bollard, keyring crates) were judged from source diffs. apple-native-keyring-store 1.0.2 was not inspected at all; it is macOS-only, which this project does not support.
- Code passes: run as a single pass, because three generated or lock files fit one reader. The design-review questions were handled in the same context and not fanned out.
- History pass: limited to the commit metadata of the two commits.
- Prior-changes pass: not run, since earlier reviews are excluded by rule.
- Windows-target
cargo check: not run locally; CI'swindows-build-and-testis green. - Comparison against main: red checks were not compared with main's recent runs; the caller is doing that.
No prompt-injection content was found in the repository data. The discussion on the PR was not reconciled here.
Why this round is posted as a comment, not a change request. The one blocking finding is the red CI, and comparing it against main settles it as environmental:
E2E tests (Strix Halo, Windows, current)andE2E consolidated report (self-hosted)also fail on main's latest commit, 32834b2.- The three hosted failures (
build-and-test,Test (affected crates),Coverage) are the reclaim-decoy breakage caused byubuntu-latestmoving to 26.04. #712 fixed it on main. This PR's checks are attempt 2 of a run on the 2026-10-20 merge commit, which predates #712, and main's latest commit is green on all three.
So nothing gates on the code. The checks still need a fresh run on current main before merge: @dependabot rebase will do it.
tomastola
left a comment
There was a problem hiding this comment.
Light review — dependency bump (dependabot, cargo-minor-patch group, 20 crates)
Checked the changelog for every bumped crate between old and new version. Nothing breaking, no security advisories, no behavior change rocm-cli actually relies on — the largest version jump (cc 1.2.65→1.8.0) looked concerning at a glance but I traced it against rocm-core/build.rs's actual usage and none of the intervening behavior changes (env-read caching, crt-static-on-override, MSRV) apply to how this repo calls it. A few of the bumps are genuine bug fixes worth having (tokio concurrency fixes, a Stacked-Borrows UB fix in anyhow, and correctness fixes in the two keyring-store backends this CLI uses for credential storage).
Holding off on approval for a different reason: CI isn't green on HEAD. The original dependabot commit failed two required freshness checks (MANIFEST.md / THIRD_PARTY_NOTICES.txt not regenerated) plus an unrelated coverage-job flake (leaked GPU process on the runner, not caused by this change). A bot pushed a follow-up commit regenerating those two files, which is now HEAD — HEAD's CI has since run, and both freshness checks now pass, but build-and-test, Test (affected crates), Coverage (rocm-dash crates, ratcheted) and E2E tests (Strix Halo, Windows, current) are red on it. On top of that, the ReadTheDocs check is failing specifically on this PR (every other recent PR here is green on that check), and I don't have visibility into why.
Ask: get the red checks on the current head commit green, and take a look at the ReadTheDocs failure — once that's clean this is a trivial merge.
nowycondro
left a comment
There was a problem hiding this comment.
🤖 Automated review (Claude Code) · 3d29c5e
Scope: This PR touches only Cargo.lock, MANIFEST.md, and THIRD_PARTY_NOTICES.txt — a Dependabot-generated minor/patch dependency bump (36 version bumps, 7 newly-added transitive packages: chacha20, core_detect, cpufeatures 0.3.1, rand 0.10.3, rand_core 0.10.1, rand_xorshift 0.5.0, zlib-rs). No application source code changes.
What I checked:
- Enumerated every bumped/added package in
Cargo.lockand cross-referenced each againstMANIFEST.md— all entries present and version-correct. - Cross-checked every bumped/added package against
THIRD_PARTY_NOTICES.txtfor stale version strings or missing license text for shipped dependencies — none found. - Investigated one candidate finding: chacha20/core_detect/cpufeatures 0.3.1/rand 0.10.3/rand_core 0.10.1 appear in
MANIFEST.mdbut have no corresponding license block inTHIRD_PARTY_NOTICES.txt. Traced their reverse-dependency chain inCargo.lockand confirmed they're pulled in exclusively viaproptest(bumped 1.11.0→1.12.0), a dev-dependency. The workspaceCargo.tomlreferences aprivate.ignoreconfig for the notices generator (cargo-about), andcc/find-msvc-tools(also build-only deps bumped here) are likewise and consistently absent from the notices file both before and after this PR. This is expected tool behavior for non-shipped dependencies, not a regression — refuted as a finding. - Confirmed no CLAUDE.md or repo-specific review conventions govern this path.
Verdict: no blocking findings. The dependency bump and the regenerated manifest/notices files are internally consistent and complete for all shipped dependencies. This is a low-risk, mechanical dependency update.
Not verified: No Rust toolchain is available in my environment, so I did not run cargo build, cargo test, or cargo about generate to independently regenerate the notices file — my review is based on static reading of the diff and cross-referencing the three changed files against each other and against Cargo.toml/workspace metadata. I did not check CI status on this PR (recommend confirming CI is green before merge). I skimmed prior review rounds from rominf and tomastola for context but did not re-verify their earlier-head findings against this head beyond what's described above.
🤖 Generated with Claude Code
|
🤖 Automated review (Claude Code) · 3d29c5e I reviewed this Dependabot grouped "cargo-minor-patch" bump, which touches only Blocking (high confidence): The No other concerns: the remaining 19 crate bumps in this group are all minor/patch releases with no indication of breaking API changes or yanked versions, and MSRV compatibility looks unaffected. I did not have a Rust toolchain available in this sandbox to actually run 🤖 Generated with Claude Code |
nowycondro
left a comment
There was a problem hiding this comment.
🔴 Automated review · pr-review-watcher · 3d29c5e
Review — needs work
Full review of the whole change.
No ticket named. Description is Dependabot's generated table for the 20-package cargo-minor-patch group, plus a bot follow-up commit regenerating MANIFEST.md/THIRD_PARTY_NOTICES.txt.
Blocking
- Five required/aggregate CI checks are red on head
3d29c5ec—build-and-test,Test (affected crates),Coverage (rocm-dash crates, ratcheted),E2E tests (Strix Halo, Windows, current),E2E consolidated report (self-hosted)
Read fromstatusCheckRollupon the live PR. Independently traced the root cause: the PR's base commit (0acf698d) predates#712("fix(ci): keep the GPU reclaim decoys alive on multicall coreutils", merged 2026-10-21T07:09, now onmainat5dfa9a85), which is exactly the class of failure the reclaim-related jobs exhibit.git merge-base --is-ancestor 0acf698d mainconfirms the PR base is an ancestor of currentmain, i.e.mainalready carries the fix this PR's CI run predates. The Windows E2E failure is arepo.amd.comtarball download timeout, i.e. infra/network, not code. The diff itself is confined toCargo.lock,MANIFEST.md,THIRD_PARTY_NOTICES.txt— no source file a reclaim test or a Windows download could plausibly regress.
This is almost certainly environmental/stale rather than a defect in this change, but the checks are still red as of this review and the PR is not mergeable in that state.
Confidence 90 · architectural · Fix:@dependabot rebase(or a manual rebase + CI rerun) onto currentmainto get a fresh run past#712's fix; merge only once green.
Non-blocking
- PR description/commit table understate the actual
libcbump —Cargo.lock(libcentry),MANIFEST.md(libcrow)
The Dependabot table and commitc591c44saylibc0.2.186→0.2.190. BothCargo.lockandMANIFEST.mdon this head record0.2.191, confirmed by direct read of both files atpr714. No bumped-crate manifest requires ≥0.2.191, so this reads as the resolver picking up a newer patch release after Dependabot generated the text, not a hand-edited mismatch. Harmless since the lockfile is what actually builds, but worth fixing in the merge/squash message so history doesn't record the wrong patch version.
Confidence 80 · mechanical · Fix: correct the version number when squash-merging, or trigger@dependabot recreate.
Decisions for the author
- The resolved tree now carries three
synmajor versions (1.0.109, 2.0.118, 3.0.9) and threerandmajor versions (0.8.7, 0.9.4, 0.10.3) — tradeoff
Verified directly:main's lockfile already hassyn1.0.109/2.0.118 andrand0.8.7/0.9.4 before this PR; this PR's resolver run addssyn3.0.9 (pulled in byanyhow,clap_derive, and similar proc-macro crates moving to syn 3 per their changelogs) andrand0.10.3 (pulled in transitively byproptest1.12, a dev-dependency, viarand_core0.10.1). The new majors are upstream's choice, not something this PR could avoid while taking the listed bumps.- For taking it now: these are legitimate upstream patch/minor releases; holding back means manually pinning against the group.
- Against: more duplicate major versions in the tree means slightly more compile time and binary size until the rest of the proc-macro ecosystem converges on
syn3.
No action needed if this is an accepted/expected tradeoff of taking the Dependabot group as-is.
Positive signals
- Diff is tightly scoped to exactly the three files a dependency bump should touch (
Cargo.lock,MANIFEST.md,THIRD_PARTY_NOTICES.txt) — no source, workflow, or config files touched, confirmed viagit diff main...pr714 --statagainst a direct clone of the PR head. - No major-version jump among the 20 listed packages is unexplained or surprising for a
cargo-minor-patchgroup: spot-checked the full set ofversion =diff lines inCargo.lockand every jump traces either to a listed package's own bump or to that package's own dependency moving in lockstep (e.g.clap_builder4.6.0→4.6.7 trackingclap's bump exactly). - A genuinely useful fix is bundled in:
anyhow1.0.103 fixes a Stacked-Borrows UB violation inError::downcast_mut.
Deployment notes
regex1.13.1 (within this group's listed1.12.4→1.13.1bump) fixes incorrect leftmost-first match offsets in some reverse-suffix/inner optimizations per upstream's changelog — any pattern in this codebase that hit that bug will return different (corrected) match positions after this merges.zbus-secret-service-keyring-storemoves patch 1.0.0→1.0.1; worth a quick look at whether its changelog touches the stored content-type for secrets, since credential-storage behavior changes are the kind of thing that's easy to miss in a bulk dependency bump. Not independently confirmed in this pass — flagging as a thing to double-check rather than an established finding.
What this covered
Cloned the PR head and main directly (git clone + git fetch origin pull/714/head) and read Cargo.lock, MANIFEST.md, and THIRD_PARTY_NOTICES.txt in full via git diff main...pr714. Verified live CI state via gh pr view --json statusCheckRollup immediately before writing this review, and re-confirmed headRefOid unchanged (3d29c5ec) immediately before posting. Cross-checked the reclaim-CI-failure theory against actual commit history (git log, git merge-base --is-ancestor, gh pr view 712) rather than taking it on faith. Independently verified the libc version and the syn/rand duplicate-major claims by reading the lockfiles directly (git show main:Cargo.lock, git show pr714:Cargo.lock), not by trusting any other party's account of them.
Did not run: cargo test/cargo clippy/cargo xtask manifest --check locally — no Rust toolchain available in this environment; relied on CI's own Third-party notices current and clippy checks (both green on this head) instead of re-deriving those results. Did not fetch/read per-package upstream changelogs for all 20 bumped crates beyond the ones cited above — the diff is a generated lockfile/manifest/notices set and the version-level cross-check (lockfile vs. manifest vs. notices vs. PR table) is the higher-signal check for this kind of change. GitHub Actions run-log API access was blocked in this environment (proxy 403), so the CI root-cause analysis above rests on git history and the linked fix PR rather than on reading job logs directly.
Not reconciled against the PR's existing review discussion.
…esh stale CI run Signed-off-by: Jussi Elo <jussi.elo@amd.com> # Conflicts: # Cargo.lock # MANIFEST.md
…atch bump cargo-about wasn't available when the merge commit was made, so the notices file was stale relative to the updated Cargo.lock. Regenerated with the pinned cargo-about 0.9.1. Signed-off-by: Jussi Elo <jussi.elo@amd.com>
nowycondro
left a comment
There was a problem hiding this comment.
🔴 Automated review · pr-review-watcher · 80469ac
Review — needs work
Full review of the whole change (fresh full re-review; PR head moved since my last review at commit 3d29c5ec, so the whole change was re-read rather than narrowed). No ticket or issue named; the PR body is dependabot's standard auto-generated dependency table.
Blocking
-
THIRD_PARTY_NOTICES.txtwas not regenerated afterCargo.lockchanged further in the merge-main commit, leaving 10 stale license-notice entries for packages no longer in the lockfile —THIRD_PARTY_NOTICES.txt(the shared Apache-2.0 license block),Cargo.lock.
Cargo.lockat head (80469ac4) no longer containswindows-sys 0.60.2,windows-targets 0.53.5, or any of the eightwindows_{aarch64,i686,x86_64}_{gnu,gnullvm,msvc} 0.53.1sub-crates (confirmed absent via direct grep of the committed head lockfile; all were present at the pre-merge dependabot commitc591c44cand atmain's tip).MANIFEST.md's diff correctly drops all 10 rows, butTHIRD_PARTY_NOTICES.txtas committed still lists all 10 removed versions inside the shared Apache-2.0 block. The regeneration at commit3d29c5ec(build(deps): regenerate MANIFEST.md and THIRD_PARTY_NOTICES.txt) was correct forCargo.lockas of that commit, but the later merge commit80469ac4("merge main into dependabot/cargo/cargo-minor-patch-c34f4c841e to refresh stale CI run") changedCargo.lockfurther (apparently via lockfile-conflict resolution during the merge) without anyone re-runningcargo xtask tpnafterward.
Confidence 100 — verified directly against the committed file text, and independently corroborated by the live CI check below.
Fix: re-runcargo xtask tpnagainst the current head'sCargo.lockand commit the regeneratedTHIRD_PARTY_NOTICES.txt. -
CI check
Third-party notices currentis FAILURE on the current head commit. This is the repo's own byte-for-byte staleness gate (cargo xtask tpn --check, perxtask/src/tpn.rs) catching exactly the defect above. Confidence 100 (gh pr view 714 --json statusCheckRollup, taken at face value). -
CI check
E2E tests (Strix Halo, Windows, current)is FAILURE on the current head commit. This diff touches no application code, but it does bumpccfrom1.2.65to1.8.0, pulling its helperfind-msvc-toolsfrom0.1.9to0.1.15— both are specifically in the native MSVC-toolchain-detection path used for Windows builds. Given the failure is on the Windows self-hosted lane specifically, this should not be assumed to be an unrelated infrastructure flake without checking the job log first; it is at least as plausible thecc/find-msvc-toolsjump changed MSVC-detection behavior on that runner. Confidence 100 for the failure itself; the causal link tocc/find-msvc-toolsis a hypothesis for the author to check (the job log was not accessible from this review environment —gh api/gh run view --logboth returned 403 through the egress proxy), not an independently verified cause.
Non-blocking
- PR description's dependency table understates the
libcbump: it claims0.2.186 -> 0.2.190, but the lockfile (both at the original dependabot commitc591c44cand at the current head) lockslibc 0.2.191. Still a forward upgrade, never a downgrade — a one-patch-release documentation mismatch, most likely because dependabot computed the table before a newer0.2.191patch landed on crates.io. Confidence 85. - This grouped bump pulls in several new transitive crates and a third live major version of two widely-used libraries.
syngains a third version (1.0.109,2.0.118, new3.0.9— consumed by the now-bumpedasync-trait,clap_derive,futures-macro,serde_derive,thiserror-impl), andrandgains a third version (0.8.7,0.9.4, new0.10.3, plusrand_core 0.10.1,chacha20,core_detect,cpufeatures 0.3.1), all traced toproptest's own bump to1.12.0;miniz_oxidesimilarly gains0.9.1viaflate2. Every new package is attributable to one of the 20 named bumps — not a defect, just added build-graph surface worth being aware of. Confidence 85.
Decisions for the author
None.
Positive signals
- No downgrades anywhere in the diff; every one of the 20 named crates lands at (or, for
libc, slightly past) its claimed target version. MANIFEST.md's regeneration is fully accurate and complete — every added/removed/changed row matchesCargo.lockexactly, including the 10windows-*row removals thatTHIRD_PARTY_NOTICES.txtmissed.- The
windows-sys/windows-targetsduplicate-version footprint actually decreased (base had 4 livewindows-sysand 2windows-targetsversions; head has 3 and 1 respectively) — a genuine dependency-tree cleanup, not a regression, onceTHIRD_PARTY_NOTICES.txtis brought in line. - All 14 first-party workspace crates are untouched in name/version — only their listed transitive dependencies moved, exactly as expected for a lockfile-only change.
- Every license string on every added/changed
MANIFEST.mdrow decomposes into identifiers already present inabout.toml's accepted list; thecargo-abouttool-version pin (ABOUT_VERSION = "0.9.1"inxtask/src/tpn.rs) is untouched and remains consistent across the repo. - Lockfile integrity is clean:
version = 4header unchanged, every registry package has a checksum, no unexpected git/path sources introduced for any bumped crate.
Deployment notes
No runtime/behavioral impact expected — no Cargo.toml semver-range changes, no application code touched. The PR cannot be safely merged as-is: the Third-party notices current CI gate is red and must be fixed by regenerating THIRD_PARTY_NOTICES.txt against the current lockfile before merge.
What this covered
Full review of the whole change: Cargo.lock, MANIFEST.md, THIRD_PARTY_NOTICES.txt — the only 3 files differing between main's tip (which equals the merge-base) and PR head 80469ac4580244c560ed384bc943f02785998a67 — each read completely, plus Cargo.toml, about.toml, xtask/src/tpn.rs, xtask/src/workflow_contract.rs, and AGENTS.md for supporting context. This is a dependency-bump PR whose generated-file diffs are individually small in file count but dense (the Cargo.lock diff alone is ~1000 lines, the license-notice diff ~380 lines), so the work was split across two independent fan-out workers grouped by coupling: one covering Cargo.lock's dependency-graph correctness, one covering MANIFEST.md/THIRD_PARTY_NOTICES.txt's consistency against it. I ran the history, prior-changes, and agent-instruction-adherence passes myself (git log/blame on all three files, comparison against a prior same-shaped bump commit efb9bc37, and a read of AGENTS.md and the generation tooling's own code comments); the code-comments pass is folded into that since the only relevant prose lives in about.toml/tpn.rs, already read for context.
CI status taken at face value from gh pr view 714 --json statusCheckRollup at review time; workflow YAML was not read to interpret what any job covers, and the failing jobs' own logs were not reachable from this sandbox (gh api/gh run view --log both returned HTTP 403 through the egress proxy) — the Windows-E2E causal hypothesis above is offered as a lead for the author, not a verified root cause.
Commits reviewed: 24e405a7 (merge-base / main tip) … 80469ac4 (PR head).
Not reconciled against any prior review or discussion on this PR. My own earlier reviews of this PR (at commit 3d29c5ec) were not read beyond the header needed to confirm they target a now-superseded commit, per this method's blind-review rule.
|
Addressing the three findings from the latest review (on THIRD_PARTY_NOTICES.txt stale after the merge commit — confirmed and fixed in Windows E2E failure possibly caused by
|
nowycondro
left a comment
There was a problem hiding this comment.
🔴 Automated review · pr-review-watcher · 50816ff
Review — no blocking findings
Full review of the whole change (dependency-lockfile bump, no hand-written logic).
No ticket named; this is a Dependabot-authored PR with no linked issue — the standard Dependabot PR body is itself the stated intent.
Blocking
None
Non-blocking
- A second major version of
syn(3.0.9) now coexists with the existingsyn 2.0.118—Cargo.lock(new[[package]] name = "syn" version = "3.0.9"block, ~45 other crates still pinsyn 2.0.118)
Five proc-macro crates bumped by this PR (async-trait0.1.92,clap_derive4.6.7,futures-macro0.3.34,serde_derive1.0.229,thiserror-impl2.0.21) now pull insyn3.x, while the rest of the dependency graph still resolvessyn2.x. This is upstream's doing (those crates adoptedsyn3 at different paces), not a defect in this PR, but it meanssyn's proc-macro parser now gets compiled twice, adding real build time. It will self-resolve as remaining crates migrate.
Confidence 80 · architectural · Fix: no action required now; worth a one-line note in a future bump's description once build-time impact is noticed, or track viacargo tree -dif it grows. - The Dependabot-generated PR description's prose is stale for
libc: it still says "Updates libc from 0.2.186 to 0.2.190," while the table at the top of the same description (and the actualCargo.lock) show0.2.191. PR description;Cargo.lock:libcentry (0.2.191, confirmed bygit show pr-714-head:Cargo.lock)
Traced the cause: the original Dependabot commit (c591c44c) bumpedlibcto0.2.190, matching the trailer/prose at the time. A later manual commit (80469ac4, "merge main ... to refresh stale CI run", by a human maintainer resolvingCargo.lock/MANIFEST.mdconflicts) re-locked and picked uplibc 0.2.191, released in the interim — a newer patch of the same package, same direction of travel. GitHub's auto-refreshed summary table reflects the current state (0.2.191) but the static prose bullet below it does not. This doesn't misrepresent the change's scope or nature (still a patch-levellibcbump), so it isn't blocking, but it is a genuine, verified mismatch between what the description's prose claims and what the lockfile contains.
Confidence 85 · mechanical · Fix: none needed for merge; informational only — Dependabot's own templating is the source, not something the author wrote by hand.
Decisions for the author
None
Positive signals
- The maintainer caught and fixed a real problem before this review: an earlier merge commit (
80469ac4) leftTHIRD_PARTY_NOTICES.txtstale relative toCargo.lockbecausecargo-aboutwasn't available at merge time, and a follow-up commit (50816ff8) explicitly regenerated it with the pinnedcargo-about 0.9.1— exactly the failure mode the repo'sdependabot-manifests.yml/-commit.ymlsplit-workflow design exists to prevent, and it was caught and corrected rather than merged stale. windows-sys/windows-targetsduplication actually decreased as a side effect of this bump (0.53.x/0.60.2variants consolidated into existing0.59.0/0.61.2/0.52.6entries) in bothCargo.lockand the regenerated manifests — a net cleanup, not new bloat.- All 20 claimed version bumps are exactly what both
Cargo.lockand the regeneratedMANIFEST.md/THIRD_PARTY_NOTICES.txtshow — no scope creep, no silent extra bumps, no license changes for any of the 20 packages (every SPDX string is unchanged before/after).
Deployment notes
None — no Cargo.toml changes (all 20 packages already fell within the existing semver ranges), no API or behavioral surface for this repo's own code changes, and the new transitive packages pulled in (chacha20, rand 0.10.x, rand_core, cpufeatures, core_detect, syn 3.0.9) are dev/build-only per about.toml's ignore-build-dependencies/ignore-dev-dependencies settings — confirmed they are not newly shipped in the built binary.
What this covered
Read the full diff between merge-base 24e405a7 and head 50816ff8 (Cargo.lock, MANIFEST.md, THIRD_PARTY_NOTICES.txt — 1,711 changed lines total), completely, via two independent fanned-out workers (one per Cargo.lock; one per the two generated/derived files), each of which cross-checked its slice against the other's and against the full files on disk. I additionally: read AGENTS.md for applicable conventions (none specific to dependency bumps beyond the generated-manifest workflow, which was followed correctly); read the dependabot-manifests.yml/dependabot-manifests-commit.yml workflows to understand why "Regenerate manifests" shows SKIPPED at this head (by design — that job only runs when github.actor == 'dependabot[bot]', and this head's regeneration was done manually by a maintainer instead); checked git log across all four of the PR's unique commits and confirmed no prior reverted dependency bumps exist in this repo's history (prior-changes pass); checked for RUSTSEC advisories on the higher-profile bumps (tokio 1.53.2 — below the yanked 1.54.0/RUSTSEC-2026-0384 and unaffected; regex, cc, http — none found affecting the new versions); and read gh pr view --json statusCheckRollup, which shows every required check (clippy, Test (affected crates), Third-party notices current, License header check, Coverage, build-and-test, windows-build-and-test, CodeQL, E2E tests, Commit signatures + sign-off, etc.) as SUCCESS, with only non-required/conditionally-skipped jobs (Regenerate manifests, Skill checks, Sphinx docs build) showing SKIPPED.
Did not run: code-comments pass (no hand-written code in this diff — the files are a lockfile and two generated artifacts); a line-by-line byte reproduction of cargo xtask manifest/tpn output (the "Third-party notices current" CI gate already verifies this exactly, so re-deriving it would duplicate a check CI already performed).
Not reconciled against any earlier review or discussion on this PR — per instructions, that thread was deliberately not read, and this is a fresh, independent review of the current head only.
|
Looks like these dependencies are updatable in another way, so this is no longer needed. |
Bumps the cargo-minor-patch group with 20 updates in the / directory:
1.0.1021.0.1044.6.14.6.74.6.54.6.111.0.01.0.10.2.1860.2.1911.0.2281.0.2291.0.1501.0.1541.52.31.53.21.1.91.1.101.0.01.0.21.0.01.0.11.11.01.12.01.12.41.13.11.2.651.8.02.0.182.0.210.21.00.21.10.7.180.7.200.3.320.3.340.1.890.1.921.4.21.5.0Updates
anyhowfrom 1.0.102 to 1.0.104Release notes
Sourced from anyhow's releases.
Commits
1dbe186Release 1.0.104f6479f8Update to syn 35bdb0e2Release 1.0.103e621bd3Merge pull request #452 from dtolnay/downcast6e8c000Eliminate pointer->reference->pointer during downcast67c4abdAdd regression test for issue 451917a169Update actions/upload-artifact@v6 -> v7d9dc3faUpdate actions/checkout@v6 -> v7841522bRaise minimum tested compiler to rust 1.85Updates
clapfrom 4.6.1 to 4.6.7Release notes
Sourced from clap's releases.
Changelog
Sourced from clap's changelog.
Commits
d3e59a9chore: Released997f87docs: Update changelogfb6058cMerge pull request #6409 from heaths/pwsh-support2310870test(complete): Add tests for completer_for_path5967c17refactor(complete): Move shell detection to Shells594602bfix(complete): Detect pwsh for PowerShell3a4f2d0Merge pull request #6427 from clap-rs/renovate/shlex-2.x67ebaedMerge pull request #6426 from clap-rs/renovate/actions-checkout-7.xc968b13chore(deps): Update Rust crate shlex to v28f247cbchore(deps): Update actions/checkout action to v7Updates
clap_completefrom 4.6.5 to 4.6.11Release notes
Sourced from clap_complete's releases.
Changelog
Sourced from clap_complete's changelog.
Commits
2cb76fdchore: Release0b00b8ddocs: Update changelog3443000Merge pull request #6526 from bonnefoa/fix-completion-escapea1b6be7fix(clap_complete): Fix value escape in zsh completionface9e8test(complete): Add completion test without arg's help88053abtest(complete): Re-enable complete testse6adcc2chore(release): Simplify replacements13f2db5chore: Release3304feadocs: Update changelog7b2ad34Merge pull request #6521 from r-near/feat/derive-deferred-initializationUpdates
keyring-corefrom 1.0.0 to 1.0.1Release notes
Sourced from keyring-core's releases.
Commits
50fe5c4Add cargo-mutants testing (#25)97b53d8Bump version for release.4004baaIntegrate review comments.6d2f8a5Integrate review comments.1aa61eaClean up .gitignore14d9c94Improve tests to cover cargo-mutants misses.9f71d13Set up cargo-mutants config.ce48eafAudit workflows with zizmor (#24)3649f1fDiscard changes to .github/workflows/ci.yamlaa5add8Merge branch 'main' into upstream/ci-zizmorUpdates
libcfrom 0.2.186 to 0.2.190Release notes
Sourced from libc's releases.
... (truncated)
Changelog
Sourced from libc's changelog.
... (truncated)
Commits
7b0ab55ci: Renamepublish_0.2.ymltorelease.yamlac85ddeci: Sync release permissions withmain8f8cd20libc: Release 0.2.190052c6e6changelog: Fix an incorrect commit linkea19fd7test: Remove explicitlibcversion6dbf3a2dragonfly: MoveINHERIT_ZEROto the freebsd module8a64766apple: addposix_spawn_file_actions_add(f)chdir(_np)28de514linux, netbsd: Give statvfs aDefaultimpla58a95fcygwin: ChangePOSIX_SPAWN_*flags toc_shortd175264apple:timeval32is exhaustiveUpdates
serdefrom 1.0.228 to 1.0.229Release notes
Sourced from serde's releases.
Commits
7fc3b4cRelease 1.0.2296d6e9a1Merge pull request #3085 from dtolnay/syn36dec3b7Update to syn 3cfe6692Resolve mut_mut pedantic clippy lint1023d07Update actions/upload-artifact@v6 -> v7dd682c2Update actions/checkout@v6 -> v75f0f18bUpdate ui test suite to nightly-2026-06-0163a1498Regenerate stderr with trybuild normalization fixesfa7da4aFix unused_features warning6b1a178Unpin CI miri toolchainUpdates
serde_jsonfrom 1.0.150 to 1.0.154Release notes
Sourced from serde_json's releases.
Commits
20572a6Release 1.0.154a91bfafFix RandomState links in map documentation3c932c0Merge pull request #1333 from razmser/no-std-preserve-order4b2d726Release 1.0.15383335eeTouch up PR 13454b4810aResolve range_plus_one pedantic clippy lint8af71ccMerge pull request #1345 from 00200200/fix-invalid-utf8-error-column452afa2Correct multiline raw UTF-8 error positions and simplify indexingc9f1e3bRelease 1.0.152854fc70Touch up PR 1347Updates
tokiofrom 1.52.3 to 1.53.2Release notes
Sourced from tokio's releases.
... (truncated)
Commits
ff0c406chore: prepare Tokio v1.53.2 (#8580)a762700Merge 'tokio-1.51.5' into 'tokio-1.53.x' (#8577)ec31a9fchore: prepare Tokio v1.51.5 (#8579)625c851sync: assign semaphore permits before emitting tracing event (#8542)832dd23sync: avoid leaking semaphore permits on tracing panic (#8542)826954async: unlink semaphore waiter before emitting tracing event (#8542)9a47992process: unregister Windows wait before closing child handle (#8564)2fc5972fs: handle integer overflow in buffered relative seek (#8574)85a6d13io: revert "always cleanup AsyncFd registration list on deregister" (#8540)436faa2rt: drop blocking pool mutex before shutting down rejected task (#8562)Updates
flate2from 1.1.9 to 1.1.10Release notes
Sourced from flate2's releases.
Commits
ed93d4fMerge pull request #558 from rust-lang/lib-doc-updatefb5228dMerge pull request #559 from bushrat011899/no_std6ed3ba3Add executableno_stdexamplefaed8a0Expand CI to testno_stdcompatibility and correctness2ba8e7eAdd unstableno_stdsupport behindflate2_unstable_nightly_alloc_io3fe1126Centralize usage ofstdforerrorandio98e313aAddGzHeader::mtime_as_duration0642965Switch tocoreimplicit prelude and only usestdwhere required454a63cRemove left-overdbg!statement2a490b7Addruntime_detectionfeatureUpdates
apple-native-keyring-storefrom 1.0.0 to 1.0.2Release notes
Sourced from apple-native-keyring-store's releases.
Commits
78cdfffPrepare release of v1.0.2. (#23)43bc380Prepare release of v1.0.2.79e4e6aCheck the OSStatus when deleting a keychain credential (#22)09582f7Map errSecInvalidOwnerEdit to NoStorageAccess.6f3cdbbCheck the OSStatus when deleting a keychain credential.4ffc36fPrepare release of v1.0.1 (#18)a8c792bPrepare release of v1.0.1.0de54c4Fix incorrect mapping of this-device-only access policies.Updates
zbus-secret-service-keyring-storefrom 1.0.0 to 1.0.1Release notes
Sourced from zbus-secret-service-keyring-store's releases.
Commits
a97612aPrepare to release v1.0.1 (#17)327e70ePrepare to release v1.0.1dd1a5caUse application/octet-stream when updating a secret's value (#16)56b4957Use application/octet-stream when updating a secret's valueUpdates
proptestfrom 1.11.0 to 1.12.0Commits
70cf37dMerge pull request #675 from proptest-rs/prep-1.12729e0ffprepare next releases and fix panic handling28c1fadMerge pull request #664 from Expyron/main5ddd9a4Merge pull request #668 from toddATavail/fix-fork-persisted-failurea6a9ac7Merge pull request #673 from glaziermag/fix-book-deployd57d88bReplacerand_chachawithchacha209411213Deploy the book on pushes to main1719745fix: terminate the fork replay when a persisted failure fails0f55b7atest: a persisted failure in a forked test must be reported4b0594eMerge pull request #669 from proptest-rs/no-fail-fastUpdates
regexfrom 1.12.4 to 1.13.1Changelog
Sourced from regex's changelog.
Commits
2b527591.13.1, redux40e98231.13.175fcb96changelog: 1.13.164ad0b6automata: fix bug in reverse suffix/inner optimizationfa91c31automata: fix a bug caught by Codex review30390ecautomata: formatting tweaks821a8ebautomata: refactor reverse suffix/inner search slightly10afd70automata: expose the extracted literals for inner literal extraction8c34f41automata: avoid reverse suffix optimization for non-leftmost-first5524f02test: add regression tests for failed reverse suffix/inner optimizationsUpdates
ccfrom 1.2.65 to 1.8.0Release notes
Sourced from cc's releases.