Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
274 changes: 225 additions & 49 deletions .github/workflows/ci.yml

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions .github/workflows/e2e-selfhosted.yml
Original file line number Diff line number Diff line change
Expand Up @@ -564,8 +564,8 @@ jobs:
path: tests/e2e-cucumber/results/

# First real Windows GPU coverage: the Strix Halo Windows 11 runner. The
# existing windows-build-and-test uses GitHub-hosted windows-latest, which has
# no GPU. Non-blocking so it never gates the PR.
# existing windows-debug/windows-release jobs use GitHub-hosted windows-latest,
# which has no GPU. Non-blocking so it never gates the PR.
e2e-gpu-strix-windows:
name: E2E tests (Strix Halo, Windows, ${{ matrix.sdk_version }})
# 45min: see e2e-gpu — one collapsed job runs all serves + per-scenario
Expand Down
13 changes: 7 additions & 6 deletions docs/testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ cargo test --workspace --all-targets
```

Note that `cargo test` runs every test as a thread in **one process**, which is
also what the required `windows-build-and-test` lane does. See
[Tests that touch the environment](#tests-that-touch-the-environment) before
writing a test that sets an environment variable.
also what the `windows-debug` job of the required `windows-build-and-test` lane
does. See [Tests that touch the environment](#tests-that-touch-the-environment)
before writing a test that sets an environment variable.

Run clippy with warnings as errors:

Expand Down Expand Up @@ -1650,9 +1650,10 @@ The harness applies the matching OS requirement itself; do not select these
with cucumber's `--tags`/`-n` flags, because those bypass the suite's custom
expectation and applicability resolver.

The required `windows-build-and-test` lane additionally folds in the hermetic
`comfyui-01`/`comfyui-02`/`comfyui-03` scenarios (not themselves `@lifecycle`)
via `E2E_ALSO_RUN_IDS`, a comma-separated list of `@id`s:
The `windows-release` job of the required `windows-build-and-test` lane
additionally folds in the hermetic `comfyui-01`/`comfyui-02`/`comfyui-03`
scenarios (not themselves `@lifecycle`) via `E2E_ALSO_RUN_IDS`, a
comma-separated list of `@id`s:

```powershell
$env:E2E_INCLUDE_LIFECYCLE = "1"
Expand Down
9 changes: 5 additions & 4 deletions tests/e2e-cucumber/features/comfyui.feature
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ Feature: ComfyUI install reports progress and makes failures actionable
#
# This scenario and comfyui-02/-03 below are hermetic and Windows-portable
# (no `@requires-os:linux`), but nothing in required CI ran them on Windows
# until the required `windows-build-and-test` lane started selecting their
# ids explicitly via `E2E_ALSO_RUN_IDS` (see `docs/testing.md`'s "Install
# lifecycle" section) — before that, Windows coverage depended entirely on
# the optional, self-hosted `e2e-selfhosted.yml` lane.
# until the `windows-release` job of the required `windows-build-and-test` lane
# started selecting their ids explicitly via `E2E_ALSO_RUN_IDS` (see
# `docs/testing.md`'s "Install lifecycle" section) — before that, Windows
# coverage depended entirely on the optional, self-hosted
# `e2e-selfhosted.yml` lane.
@id:comfyui-uv-install-failure-names-log
Scenario: comfyui-01 - A failed dependency install names the log it wrote
Given a ready ROCm runtime with a ComfyUI checkout pending dependencies
Expand Down
11 changes: 6 additions & 5 deletions xtask/src/env_mutation_contract.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,12 @@
//!
//! This is invisible on most of CI. `ci.yml`'s `Test (affected crates)` job
//! runs `cargo nextest` (a process per test, so the mutation cannot escape),
//! but `windows-build-and-test` runs `cargo test --workspace --all-targets` —
//! all tests as threads in ONE process. So the Windows lane, a required check,
//! was the only place the race could fire, and it read as "your change broke
//! Windows" on branches that never touched the crate. Nothing about the bug is
//! Windows-specific; it is a property of the runner.
//! but the `windows-debug` job (part of the required `windows-build-and-test`
//! check) runs `cargo test --workspace --all-targets` — all tests as threads in
//! ONE process. So the Windows lane, a required check, was the only place the
//! race could fire, and it read as "your change broke Windows" on branches that
//! never touched the crate. Nothing about the bug is Windows-specific; it is a
//! property of the runner.
//!
//! "the Linux lanes use nextest" would be too strong: `coverage`
//! (`cargo llvm-cov`, no `--nextest`) and `e2e` (`cargo test -p e2e-cucumber
Expand Down
Loading
Loading