Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/e2e-selfhosted.yml
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,16 @@ jobs:
# `channel` dimension above, not replacing it — this lane is the only
# per-PR job with two independent matrix axes.
sdk_version: ${{ fromJSON(needs.changes.outputs.sdk_version_matrix) }}
# The nightly channel only carries the latest (pre-)release builds, so
# it cannot resolve the n-1/n-2 released versions the matrix pins
# (`rocm install sdk` fails with "no mutually compatible TheRock ...
# versions"). Those legs are covered by the `release` channel; a no-op
# when the matrix is the single-element `current`.
exclude:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: nothing pins this exclude. The repo pins sibling workflow behaviour in xtask/src/workflow_contract.rs, and AGENTS.md §3 asks that a new test is shown to fail when the code it covers is broken. If someone drops this block, the red nightly n-1/n-2 legs come back quietly. Consider a small contract test asserting that the e2e-gpu-strix-ubuntu matrix excludes nightly x n-1 and n-2, or say in the PR text that you chose not to add one.

- channel: nightly
sdk_version: n-1
- channel: nightly
sdk_version: n-2
env:
E2E_SERVE_TIMEOUT_SECS: "300"
# A pool host can be busy with other CI work between GPU preflight and
Expand Down
8 changes: 6 additions & 2 deletions docs/ci-hardware-testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,12 @@ ordinary PR run is unaffected. Each leg uploads its own artifact (the
versions share one pre-warmed runtime tree rather than needing separate ones.
`e2e-gpu-strix-ubuntu` layers this `sdk_version` axis alongside its
pre-existing `channel` axis (ROCMAI-125) rather than replacing it, so a
release-branch push runs all six `channel` × `sdk_version` combinations on
that lane; `rad3`/`mi350p` are nightly-only (above) and don't run this matrix
release-branch push runs four of the six `channel` × `sdk_version`
combinations on that lane: the `nightly` channel is excluded from `n-1`/`n-2`,
because it only carries the latest (pre-)release builds and cannot resolve the
pinned released versions (`rocm install sdk` fails with "no mutually compatible
TheRock ... versions"); those versions are covered by the `release` channel.
`rad3`/`mi350p` are nightly-only (above) and don't run this matrix
at all.

`serve` is narrower than `heavy`: it matches only
Expand Down
Loading