fix(pull-requests): reconcile Gitea and dependency stack integration

apps/server/src/pullRequest/GiteaPullRequestApi.test.ts

@@ -512,12 +512,14 @@ layer("GiteaPullRequestApi", (it) => {
         viewer: "",
         limit: 200,
         relationshipOnly: true,
+        includeTracking: true,
       });
 
       expect(page.items.map((item) => item.number)).toEqual([1]);
       assert.strictEqual(page.consumed, 2);
       assert.isTrue(page.truncated);
       assert.strictEqual(mockedRequest.mock.calls.length, 1);
+      expect(callAt(0).path).not.toContain("include_tracking");
     }),
   );
 
@@ -1567,6 +1569,49 @@ layer("GiteaPullRequestApi", (it) => {
     }),
   );
 
+  it.effect("limits later reviews to the remaining shared inline-comment budget", () =>
+    Effect.gen(function* () {
+      mockedRequest.mockReturnValueOnce(
+        Effect.succeed(
+          response([
+            { id: 21, body: "First review", submitted_at: "2026-09-03T11:00:00Z" },
+            { id: 22, body: "Second review", submitted_at: "2026-09-03T12:00:00Z" },
+          ]),
+        ),
+      );
+      for (const [offset, length] of [
+        [0, 150],
+        [150, 100],
+      ] as const) {
+        mockedRequest.mockReturnValueOnce(
+          Effect.succeed(
+            response(
+              Array.from({ length }, (_, index) => ({
+                id: offset + index + 31,
+                body: "Comment",
+                path: "src/a.ts",
+                position: 1,
+                created_at: "2026-09-03T11:01:00Z",
+              })),
+            ),
+          ),
+        );
+      }
+      const api = yield* GiteaPullRequestApi.make;
+      const result = yield* api.listReviews({
+        host: "forge.example.test",
+        repository: "acme/web",
+        number: 7,
+      });
+
+      const inlineComments = result.comments.filter((comment) => comment.kind === "review-comment");
+      expect(inlineComments).toHaveLength(200);
+      expect(inlineComments.at(-1)?.id).toBe("review-comment:230");
+      expect(result.truncated).toBe(true);
+      expect(mockedRequest).toHaveBeenCalledTimes(3);
+    }),
+  );
+
   it.effect("follows pagination links when Gitea caps comment pages below the limit", () =>
     Effect.gen(function* () {
       mockedRequest
@@ -2555,6 +2600,60 @@ layer("GiteaPullRequestApi", (it) => {
     }),
   );
 
+  it.effect.each(
+    [undefined, "fix"].flatMap((query) => [403, 503].map((status) => ({ query, status }))),
+  )("preserves individual reviewing matches with partial team coverage (%j)", ({ query, status }) =>
+    Effect.gen(function* () {
+      const pullRequests = [
+        rawPullRequest(7),
+        rawPullRequest(8, {
+          requested_reviewers: [],
+          requested_reviewers_teams: [{ id: 9, name: "maintainers" }],
+        }),
+      ];
+      mockedRequest.mockImplementation((input) => {
+        if (input.path.startsWith("/user/teams?"))
+          return Effect.fail(
+            new GiteaApi.GiteaApiError({
+              operation: "getViewerTeams",
+              reason: "failed",
+              detail: "Viewer teams could not be read.",
+              status,
+            }),
+          );
+        if (input.path.startsWith("/repos/acme/web/pulls?"))
+          return Effect.succeed(response(pullRequests));
+        if (input.path.startsWith("/repos/acme/web/issues?"))
+          return Effect.succeed(response([{ number: 7 }, { number: 8 }]));
+        const pullRequest = pullRequests.find(
+          (pullRequest) => input.path === `/repos/acme/web/pulls/${pullRequest.number}`,
+        );
+        if (pullRequest !== undefined) return Effect.succeed(response(pullRequest));
+        return Effect.die(`unexpected request: ${input.path}`);
+      });
+      const api = yield* GiteaPullRequestApi.make;
+      const page = yield* api.listPullRequests({
+        host: "forge.example.test",
+        repository: "acme/web",
+        state: "open",
+        involvement: "reviewing",
+        viewer: "reviewer",
+        limit: 10,
+        ...(query === undefined ? {} : { query }),
+      });
+
+      expect(page.items.map((pullRequest) => pullRequest.number)).toEqual([7]);
+      expect(page.consumed).toBe(2);
+      expect(page.truncated).toBe(false);
+      expect(page.coverageWarning).toBe(
+        "Some team review requests may be missing because Gitea team membership could not be read.",
+      );
+      expect(
+        mockedRequest.mock.calls.filter(([input]) => input.path.startsWith("/user/teams?")),
+      ).toHaveLength(1);
+    }),
+  );
+
   it.effect("includes pull requests requested from a viewer team in reviewing listings", () =>
     Effect.gen(function* () {
       mockedRequest.mockImplementation((input) => {

apps/server/src/pullRequest/GiteaPullRequestApi.ts

@@ -520,6 +520,7 @@ export class GiteaPullRequestApi extends Context.Service<
         items: ReadonlyArray<GiteaPullRequest>;
         truncated: boolean;
         consumed: number;
+        coverageWarning?: string;
       },
       GiteaPullRequestApiError
     >;
@@ -910,8 +911,16 @@ export const make = Effect.gen(function* () {
       let rowsSkipped = 0;
       let consumed = 0;
       const collected: Array<GiteaPullRequest> = [];
-      const viewerTeamIDs =
-        input.involvement === "reviewing" ? yield* getViewerTeamIDs : new Set<number>();
+      const viewerTeams =
+        input.involvement === "reviewing"
+          ? yield* getViewerTeams
+          : { ids: new Set<number>(), available: true };
+      const coverage = viewerTeams.available
+        ? {}
+        : {
+            coverageWarning:
+              "Some team review requests may be missing because Gitea team membership could not be read.",
+          };
 
       while (page <= MAX_PAGINATION_PAGES) {
         const result = yield* readUnknownPage({
@@ -956,7 +965,7 @@ export const make = Effect.gen(function* () {
               input.state,
               input.involvement,
               input.viewer,
-              viewerTeamIDs,
+              viewerTeams.ids,
             )
           )
             continue;
@@ -971,6 +980,7 @@ export const make = Effect.gen(function* () {
             }
             return {
               items: collected,
+              ...coverage,
               truncated: index < pageRows.length - 1 || next !== null,
               consumed,
             };
@@ -989,6 +999,7 @@ export const make = Effect.gen(function* () {
       }
       return {
         items: collected,
+        ...coverage,
         truncated: false,
         consumed,
       };
@@ -1017,7 +1028,7 @@ export const make = Effect.gen(function* () {
     "1 minute",
   );
 
-  const getViewerTeamIDs = yield* Effect.cachedWithTTL(
+  const getViewerTeams = yield* Effect.cachedWithTTL(
     Effect.suspend(() =>
       Effect.gen(function* () {
         const teamIDs = new Set<number>();
@@ -1037,7 +1048,7 @@ export const make = Effect.gen(function* () {
             rowsSeen,
             headers: response.headers,
           });
-          if (next === null) return teamIDs;
+          if (next === null) return { ids: teamIDs, available: true };
           path = next;
         }
         return yield* new GiteaPullRequestApiError({
@@ -1046,6 +1057,10 @@ export const make = Effect.gen(function* () {
           detail: "Gitea viewer team pagination exceeded the safe page limit.",
         });
       }),
+    ).pipe(
+      // Public-only tokens can read pull requests while Gitea rejects their team lookup.
+      // Team membership enriches individual review requests and must not hide those matches.
+      Effect.orElseSucceed(() => ({ ids: new Set<number>(), available: false })),
     ),
     "1 minute",
   );
@@ -1133,8 +1148,16 @@ export const make = Effect.gen(function* () {
     const repositoryIdsByName = new Map<string, number>();
     const expectedRepository = input.repository.trim().toLowerCase();
     const collected: Array<GiteaPullRequest> = [];
-    const viewerTeamIDs =
-      input.involvement === "reviewing" ? yield* getViewerTeamIDs : new Set<number>();
+    const viewerTeams =
+      input.involvement === "reviewing"
+        ? yield* getViewerTeams
+        : { ids: new Set<number>(), available: true };
+    const coverage = viewerTeams.available
+      ? {}
+      : {
+          coverageWarning:
+            "Some team review requests may be missing because Gitea team membership could not be read.",
+        };
     const maxPages = relationshipOnly ? DEPENDENCY_PAGINATION_PAGES : MAX_PAGINATION_PAGES;
     let pagesRead = 0;
     let prefetchedPage: UnknownPage | null = null;
@@ -1230,7 +1253,9 @@ export const make = Effect.gen(function* () {
             else if (observed !== id) relationshipEvidenceIncomplete = true;
           }
         }
-        if (!matchesPullRequest(pr, input.state, input.involvement, input.viewer, viewerTeamIDs)) {
+        if (
+          !matchesPullRequest(pr, input.state, input.involvement, input.viewer, viewerTeams.ids)
+        ) {
           relationshipEvidenceIncomplete = relationshipOnly || relationshipEvidenceIncomplete;
           continue;
         }
@@ -1245,6 +1270,7 @@ export const make = Effect.gen(function* () {
           }
           return {
             items: collected,
+            ...coverage,
             truncated:
               relationshipEvidenceIncomplete || index < pageRows.length - 1 || next !== null,
             consumed,
@@ -1264,6 +1290,7 @@ export const make = Effect.gen(function* () {
     }
     return {
       items: collected,
+      ...coverage,
       truncated: relationshipOnly && (relationshipEvidenceIncomplete || next !== null),
       consumed,
     };
@@ -2133,11 +2160,12 @@ export const make = Effect.gen(function* () {
             }),
             limit: PAGE_SIZE,
           }),
-          readUnknownArray({
+          readUnknownPage({
             operation: "listTeamReviewerCandidates",
             ...input,
             path: `${basePath(input.repository)}/teams`,
           }).pipe(
+            Effect.map((page) => page.rows),
             Effect.catch((error) =>
               isGiteaApiError(error.cause) && error.cause.status === 405
                 ? Effect.succeed([])

apps/server/src/pullRequest/GiteaPullRequestProvider.test.ts

@@ -150,6 +150,60 @@ describe("GiteaPullRequestProvider", () => {
       expect("autoMergeEnabled" in detail).toBe(false);
     }),
   );
+  it.effect.each([undefined, "fix"])(
+    "retains Reviewing coverage warnings in provider listings (%s)",
+    (query) =>
+      Effect.gen(function* () {
+        const pull = { ...rawPullRequest(), requested_reviewers: [{ login: "reader" }] };
+        const request = vi.fn<GiteaApi.GiteaApi["Service"]["request"]>((input) => {
+          if (input.path.startsWith("/user/teams?"))
+            return Effect.fail(
+              new GiteaApi.GiteaApiError({
+                operation: "getViewerTeams",
+                reason: "failed",
+                status: 403,
+                detail: "Teams unavailable",
+              }),
+            );
+          if (input.path.startsWith("/repos/acme/web/pulls?"))
+            return Effect.succeed(response([pull]));
+          if (input.path.startsWith("/repos/acme/web/issues?"))
+            return Effect.succeed(response([{ number: 7 }]));
+          if (input.path.startsWith("/repos/acme/web/pulls/7"))
+            return Effect.succeed(response(pull));
+          return Effect.die(`Unexpected Gitea request: ${input.path}`);
+        });
+        const apiLayer = GiteaPullRequestApi.layer.pipe(
+          Layer.provide(
+            Layer.succeed(
+              GiteaApi.GiteaApi,
+              GiteaApi.GiteaApi.of({
+                baseUrl: Option.some("https://forge.example.test/gitea"),
+                sshHosts: [],
+                request,
+                probeAuth: Effect.die("not used"),
+              }),
+            ),
+          ),
+        );
+        const provider = yield* makeGiteaPullRequestProvider.pipe(Effect.provide(apiLayer));
+        const page = yield* provider.listChangeRequests({
+          cwd: "/repo",
+          host: "forge.example.test",
+          repository: "acme/web",
+          state: "open",
+          involvement: "reviewing",
+          viewer: "reader",
+          limit: 10,
+          ...(query === undefined ? {} : { query }),
+        });
+        expect(page.items.map((item) => item.number)).toEqual([7]);
+        expect(page.coverageWarning).toBe(
+          "Some team review requests may be missing because Gitea team membership could not be read.",
+        );
+        expect(page.truncated).toBe(false);
+      }),
+  );
   for (const discovery of ["failed", "incomplete"] as const) {
     it.effect(
       `keeps workflow approval state unknown when supported discovery is ${discovery}`,

apps/server/src/pullRequest/GiteaPullRequestProvider.ts

@@ -186,6 +186,9 @@ export const make = Effect.gen(function* () {
             items: page.items.map((pullRequest) =>
               giteaToChangeRequest(pullRequest, input.relationshipOnly === true),
             ),
+            ...(page.coverageWarning === undefined
+              ? {}
+              : { coverageWarning: page.coverageWarning }),
             truncated: page.truncated,
             cursorAdvance: page.consumed,
             continues: true,

apps/server/src/pullRequest/PullRequestProvider.ts

@@ -104,6 +104,8 @@ export interface ProviderChangeRequestSummary {
 }
 
 export interface ProviderChangeRequestPage {
+  /** Optional enrichment failed; pagination still describes only the rows the host returned. */
+  readonly coverageWarning?: string;
   readonly items: ReadonlyArray<ProviderChangeRequest>;
   /** True when the host has more rows than the page size asked for. */
   readonly truncated: boolean;

apps/server/src/pullRequest/PullRequestService.test.ts

@@ -935,6 +935,41 @@ it.effect("keeps healthy repositories when one of them cannot be read", () =>
   }),
 );
 
+it.effect(
+  "returns partial listing coverage with readable rows and no fabricated continuation",
+  () =>
+    Effect.gen(function* () {
+      const service = yield* makeService({
+        projects: [
+          project({ id: "p1", title: "web", workspaceRoot: "/a", repository: "acme/web" }),
+        ],
+        providers: [
+          fakeProvider("github", {
+            listChangeRequests: () =>
+              Effect.succeed({
+                items: [changeRequest(1, "2026-07-02T00:00:00Z")],
+                coverageWarning: "Team review requests may be missing.",
+                truncated: false,
+                continues: true,
+              }),
+          }),
+        ],
+      });
+      const result = yield* service.list({ state: "open", involvement: "reviewing" });
+      assert.strictEqual(result.entries.length, 1);
+      assert.deepStrictEqual(result.errors, [
+        {
+          projectId: "p1" as ProjectId,
+          projectTitle: "web",
+          message: "Team review requests may be missing.",
+          partial: true,
+        },
+      ]);
+      assert.isFalse(result.truncated);
+      assert.deepStrictEqual(result.nextCursors, {});
+    }),
+);
+
 it.effect("tries another workspace on the same host for the viewer", () =>
   Effect.gen(function* () {
     const service = yield* makeService({