Skip to content

CherryPicked: [v2.10] Support: change independent_nonpersistent disk mode after cloud-init - #383

Closed
manage-repositories-app[bot] wants to merge 1 commit into
v2.10from
CherryPicked-fix/copyoffload-independent-nonpersistent-cFDVT
Closed

manage-repositories-app[bot] wants to merge 1 commit into
v2.10from
CherryPicked-fix/copyoffload-independent-nonpersistent-cFDVT

Conversation

@manage-repositories-app

Copy link
Copy Markdown

Cherry-pick from main branch, original PR: #369, PR owner: prabinovRedhat

…369)

* fix: change disk mode to independent_nonpersistent after cloud-init

independent_nonpersistent disks lose data on power-off, so the disk
must be created as regular persistent during clone, then changed after
cloud-init completes and the VM is powered off.

- Remove disk_mode from config (defaults to persistent during clone)
- Add VMWareProvider.change_disk_mode() for ReconfigVM_Task
- Add nonpersistent_disk_ready fixture that chains after cloud-init

Made-with: Cursor

* feat: add test_check_xcopy_used to independent nonpersistent test class

Made-with: Cursor

* fix: add power state validation in change_disk_mode()

Made-with: Cursor

* docs: document 6-step copy-offload test pattern in CLAUDE.md

Made-with: Cursor

* docs: reference verify_xcopy_used utility instead of implementation detail

Made-with: Cursor
@redhat-qe-bot1

Copy link
Copy Markdown

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

Note: You are an auto-verified user. Your PRs will be automatically verified and may be auto-merged when all requirements are met.

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: Disabled for this repository
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: All label categories are enabled (default configuration)

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest conventional-title - Validate commit message format
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. Status Checks: All required status checks must pass
  3. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  4. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • myakove
  • solenoci

Reviewers:

  • krcmarik
  • myakove
  • solenoci
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
  • automerge

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is automatically removed on each new commit
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@prabinovRedhat

Copy link
Copy Markdown
Collaborator

/close

@prabinovRedhat

prabinovRedhat commented Mar 24, 2026 •

Copy link
Copy Markdown
Collaborator

This PR needs to be closed — it has been superseded by #386 which was cherry-picked cleanly onto the latest v2.10.

cc @prabinovRedhat @myakove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants