Repository navigation
Add tox verify-bugs-are-open-gh to add this check as a check run - #3048
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughAdds a new tox testenv Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot
added
size/L
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot
previously approved these changes
Dec 9, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/verify-bugs-are-open.yml (1)
41-53: Unusedrebase_successvariable should be removed or utilized.Line 47 and 50 set
rebase_success, but this output is never referenced in subsequent steps. Either remove it (if rebase result isn't needed) or use it to conditionally skip verification when rebase fails.If rebase failure should block verification, apply this diff:
- name: Verify bugs are open + if: steps.rebase.outputs.rebase_success == 'true' id: verify-bugs env: JIRA_TOKEN: ${{ secrets.JIRA_TOKEN }}Otherwise, remove the unused output variables:
if git rebase origin/${{ github.event.pull_request.base.ref }}; then - echo "rebase_success=true" >> "$GITHUB_OUTPUT" echo "Successfully rebased on ${{ github.event.pull_request.base.ref }}" else - echo "rebase_success=false" >> "$GITHUB_OUTPUT" echo "Rebase failed, aborting and continuing with original PR state"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/verify-bugs-are-open.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR #2469) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2701
File: .github/scripts/coderabbit_workflow.py:45-46
Timestamp: 2025-11-27T11:45:54.224Z
Learning: In the openshift-virtualization-tests repository, when using the PyGithub library or similar API clients, rnetser prefers to rely on API-level validation rather than adding redundant client-side input validation, since the API will handle validation and raise appropriate errors.
Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR #2199 depends on PR #2139 which adds architecture-specific OS_FLAVOR attributes to the Images.Cirros class (OS_FLAVOR_CIRROS for x86_64/ARM64, OS_FLAVOR_FEDORA for s390x), enabling conditional logic based on the underlying OS flavor in tests.
Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 2838
File: .github/workflows/net-utils-builder-staging.yml:37-37
Timestamp: 2025-11-25T01:56:54.902Z
Learning: In the openshift-virtualization-tests repository, when renaming container images that are built and used by GitHub Actions workflows, the changes must be done sequentially: first merge the workflow files (.github/workflows/) that update the image name in the CI/CD pipelines, then update the code references (like constants.py and manifest files) in a follow-up PR. This prevents the old workflow from running with mismatched image names during the transition.
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1244
File: utilities/os_utils.py:248-250
Timestamp: 2025-07-08T05:51:06.314Z
Learning: User rnetser prefers fail-fast code design where functions should raise exceptions immediately when encountering unexpected or malformed input, rather than implementing defensive error handling with fallbacks. They value making problems visible immediately during development over graceful degradation.
📚 Learning: 2025-11-25T01:56:54.902Z
Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 2838
File: .github/workflows/net-utils-builder-staging.yml:37-37
Timestamp: 2025-11-25T01:56:54.902Z
Learning: In the openshift-virtualization-tests repository, when renaming container images that are built and used by GitHub Actions workflows, the changes must be done sequentially: first merge the workflow files (.github/workflows/) that update the image name in the CI/CD pipelines, then update the code references (like constants.py and manifest files) in a follow-up PR. This prevents the old workflow from running with mismatched image names during the transition.
Applied to files:
.github/workflows/verify-bugs-are-open.yml
🔇 Additional comments (3)
.github/workflows/verify-bugs-are-open.yml (3)
91-139: Label management logic is solid.The two label-update steps properly remove the opposite label before adding the new one, and gracefully handle cases where labels don't exist. The defensive error handling is appropriate.
62-76: Token masking and validation are properly implemented.The use of
::add-mask::to prevent token exposure, combined with validation that the secret is set, provides good security hygiene. The error message helpfully guides users on where to add the secret.
22-53: Git setup and fetch strategy are appropriate.The workflow properly uses
fetch-depth: 0to ensure full history for rebase operations, configures git with standard bot credentials, and gracefully handles rebase failures withcontinue-on-error: true. This allows verification to proceed even if rebasing isn't possible.
dshchedr
previously approved these changes
Dec 15, 2025
vsibirsk
previously approved these changes
Dec 15, 2025
Collaborator
|
/approve |
Contributor
|
/lgtm |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:passed
openshift-virtualization-qe-bot
previously approved these changes
Jan 6, 2026
Collaborator
|
/approve |
openshift-virtualization-qe-bot
previously approved these changes
Jan 18, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@tox.ini`:
- Around line 95-104: The tox testenv verify-bugs-are-open-gh currently injects
the secret via a CLI flag to pyutils-jira; remove the --token "{env:JIRA_TOKEN}"
argument and instead rely on a config file or environment variable: either add
--config-file-path jira.cfg (matching the other testenv) so the token stays in
the config file, or ensure pyutils-jira reads JIRA_TOKEN from the environment by
exporting it via passenv/setenv and omitting the --token flag; update the
commands for the testenv:verify-bugs-are-open-gh and keep the JIRA_TOKEN
referenced only via passenv/setenv, not in the command line.
Collaborator
Author
|
/verified
|
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 882 🏁 Script executed: Length of output: 456 🏁 Script executed: Length of output: 0 🏁 Script executed: Length of output: 272 🏁 Script executed: Length of output: 1728 🧠 Learnings used |
openshift-virtualization-qe-bot
approved these changes
Jan 18, 2026
Collaborator
Author
|
/approve |
vsibirsk
approved these changes
Jan 18, 2026
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published |
This was referenced Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
To allow open bugs check to be a GH check run, integrated with myk-org/github-webhook-server#961 -
toxwas updated with an explicit commandMore details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.