0.10.2: ReferenceError: name is not defined #1485

Activity

1. StephaneLambert commented on Dec 18, 2020

   

   StephaneLambert

   on Dec 18, 2020

   More actions

   Same trouble for me with NodeJS 12.19 et redoc-cli 0.10.2, not with 0.10.1.
   Clarification: redoc-cli serve is OK while redoc-cli bundle is NOT.

   My YAML sample :

   openapi: 3.0.2
   info:
     title: Test Redoc Bundle
     version: 1.0.0
     description: Redoc Bundle fail if headers are used ?
   paths:
     /entities:
       summary: '...'
       description: '...'
       get:
         parameters:
           - examples:
               all:
                 value: 0-5/6
               page2:
                 value: 20-39/258
             name: Content-Range
             description: |-
               Content-Range: `offset`–`limit`/`count`
                 * offset : ...
                 * limit : ...
                 * count : ...
             schema:
               type: string
             in: header
         responses:
           '200':
             content:
               application/json:
                 schema:
                   type: array
                   items:
                     $ref: '#/components/schemas/entities'
             description: Successful response - returns an array of `entities` entities.
         operationId: getentities
         summary: List All entities
         description: Gets a list of all `entities` entities.
   components:
     schemas:
       entities:
         description: ''
         type: object
         properties:
           property1:
             description: property1 description
             type: string
           property2:
             description: property2 description
             type: integer
   
2. RomanHotsiy

   closed this as completedin 0dce880on Jan 28, 2021
3. dowy commented on Mar 7, 2021

   

   dowy

   on Mar 7, 2021

   Last edited by dowy

   More actions

   That line:
   .../node_modules/redoc-cli/node_modules/redoc/bundles/redoc.lib.js:9404:124
   points to the variable "name" but there is no such variable.
   It should refer to the "this.name" assigned on line 9391.

   My javascript isn't strong enough to figure out how "name" on line 9404 can refer to "this.name" on line 9391 so I added a local variable:

   --- redoc.lib.js        2021-03-08 10:04:59.848676574 +1300
   +++ redoc.lib.js.patched        2021-03-08 10:05:46.578731187 +1300
   @@ -9383,12 +9383,12 @@
     */
    var Field_FieldModel = /** @class */ (function () {
        function FieldModel(parser, infoOrRef, pointer, options) {
   -        var _a, _b, _c, _d;
   +        var _a, _b, _c, _d, name;
            this.expanded = false;
            Object(external_mobx_["makeObservable"])(this);
            var info = parser.deref(infoOrRef);
            this.kind = infoOrRef.kind || 'field';
   -        this.name = infoOrRef.name || info.name;
   +        name = this.name = infoOrRef.name || info.name;
            this.in = info.in;
            this.required = !!info.required;
            var fieldSchema = info.schema;

   I leave it to someone who knows what they're doing to raise a patch for this.
4. EvanCarroll commented on Mar 26, 2021

   

   EvanCarroll

   on Mar 26, 2021

   More actions

   @RomanHotsiy why was this issue closed?
5. EvanCarroll commented on Mar 26, 2021

   

   EvanCarroll

   on Mar 26, 2021

   More actions

   @dowy I'm confused how this isn't broken for everyone.
6. RomanHotsiy commented on Mar 26, 2021

   

   RomanHotsiy

   on Mar 26, 2021

   Member

   More actions

   @EvanCarroll because It was fixed.

   Could you specify more details? Which version of openapi-cli do you use? What node version?
7. RomanHotsiy commented on Mar 26, 2021

   

   RomanHotsiy

   on Mar 26, 2021

   Member

   More actions

   @EvanCarroll I just tested it again and it works for me on the latest redoc-cli@0.10.4 version.
8. glosier

   added a commit that references this issue on Dec 5, 2021

   Redoc update (#5)

   ...

   This issue will close once commit 63ead20 is merged into the 'main' branch.

   63ead20
9. glosier

   added a commit that references this issue on Oct 6, 2025

   fix: crash on multiple examples on parameter object

   ...

   This issue will close once commit 0dce880 is merged into the 'main' branch.

   0dce880