[Bug]: No maxLength label is displayed for arrays of items #1701

Activity

1. RomanHotsiy

   added

   Type: Bug

   on Jul 30, 2021
2. ihah commented on Aug 10, 2021

   

   ihah

   on Aug 10, 2021

   More actions

   Instead of creating new issue just making confirmation on array items string type rules.
   Confirming redoc-cli v0.12.2 has same behavior, pattern, description, minLength, maxLength rule badges are not rendered.
   Enum rendered.

   starts:
       type: array
       items:
         type: string
         description: "My start list"
         minLength: 3
         maxLength: 100
       maxItems: 12

   starts:
       type: array
       items:
         type: string
         description: "My start list"
         pattern: /([A-Z])/
       maxItems: 12

   It seems enum rule works:

   starts:
       type: array
       items:
         type: string
         enum: [Jr. Test, Dr. Tester]
       maxItems: 12

   

   Maybe pattern, description, minLength, maxLength string rules should be rendered same as enum rule.

   With pattern, minLength, maxLength string rules
   Items pattern: A-Z
   Items length: [ 3 .. 100 ] characters

   With maxLength string rule
   Items length: <= 100 characters

   With minLength string rule
   Items length: >= 10 characters
3. miqh commented on Oct 7, 2021

   

   miqh

   on Oct 7, 2021

   Last edited by miqh

   Contributor

   More actions

   I don't believe the current implementation will show constraint badges for array item types.

   In situations where constraint badges appear next to array-based fields, they refer to the constraint applying to the array itself. An example is maxItems, as pointed out in a previous comment.

   The additional problem here is how best to present the array item type constraints.

   A naive (and I think quick) solution would be to collect and stack all array item type constraints adjacent to array constraints. However, this mightn't read intuitively.

   Example:

   Array of strings [<= 3 items] [<= 80 characters]
   ...
   

   @RomanHotsiy, if you've got any opinions on how best to present the array item type constraints, I can have a shot at making changes to support them.
4. RomanHotsiy commented on Oct 8, 2021

   

   RomanHotsiy

   on Oct 8, 2021

   Member

   More actions

   I believe there is a PR already in progress related to this but I have to check if this is considered. See the mentioned PR above.
5. zalesky

   added a commit that references this issue on Oct 8, 2021

   fix: No maxLength label is displayed for arrays of items #1701

   543ecc4
6. zalesky

   self-assigned this

   on Oct 8, 2021
7. zalesky

   added 2 commits that reference this issue on Oct 12, 2021

   Revert "fix: No maxLength label is displayed for arrays of items #1701"

   ...

   b5fb407

   fix: No maxLength label is displayed for arrays of items #1701

   74bcf11
8. Oprysk

   closed this as completedin #1765on Jan 5, 2022
9. Oprysk

   added a commit that references this issue on Jan 5, 2022

   fix: No maxLength label is displayed for arrays of items #1701 (#1765)

   ...

   6c7685e