Skip to content

Improve emulator lifecycle reliability (boot/cpu/animation exception handling) #65

Description

@mattleibow

Ref: PR #63

The following improvements were identified during review of PR #63 to improve reliability and handle transient ADB failures:

  1. WaitForBootComplete: The adb.Shell calls inside the polling loop (lines ~355) can throw SdkToolFailedExitException if adb exits non-zero. These should be wrapped in a try-catch block to allow retrying, similar to FindRunningEmulatorSerialByAvdName.
  2. WaitForCpuLoadBelow: The adb.Shell call (line ~401) should also be wrapped in try-catch to handle transient failures.
  3. DisableAnimations: The adb.Shell calls (line ~429) should be best-effort and wrapped in try-catch.
  4. Test Coverage: Add tests for DisableAnimations and the new launcher waiting logic in WaitForBootComplete.
  5. Cleanup: Remove unused using System.Data; in Emulator.cs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions