Ref: PR #63
The following improvements were identified during review of PR #63 to improve reliability and handle transient ADB failures:
- WaitForBootComplete: The
adb.Shell calls inside the polling loop (lines ~355) can throw SdkToolFailedExitException if adb exits non-zero. These should be wrapped in a try-catch block to allow retrying, similar to FindRunningEmulatorSerialByAvdName.
- WaitForCpuLoadBelow: The
adb.Shell call (line ~401) should also be wrapped in try-catch to handle transient failures.
- DisableAnimations: The
adb.Shell calls (line ~429) should be best-effort and wrapped in try-catch.
- Test Coverage: Add tests for
DisableAnimations and the new launcher waiting logic in WaitForBootComplete.
- Cleanup: Remove unused
using System.Data; in Emulator.cs.
Ref: PR #63
The following improvements were identified during review of PR #63 to improve reliability and handle transient ADB failures:
adb.Shellcalls inside the polling loop (lines ~355) can throwSdkToolFailedExitExceptionif adb exits non-zero. These should be wrapped in atry-catchblock to allow retrying, similar toFindRunningEmulatorSerialByAvdName.adb.Shellcall (line ~401) should also be wrapped intry-catchto handle transient failures.adb.Shellcalls (line ~429) should be best-effort and wrapped intry-catch.DisableAnimationsand the new launcher waiting logic inWaitForBootComplete.using System.Data;inEmulator.cs.