Upgrade to .NET 10 and harden CI reliability - #74
Merged
Merged
Conversation
Test Results 4 files 4 suites 21m 19s ⏱️ Results for commit 0bfaf17. ♻️ This comment has been updated with latest results. |
mattleibow
changed the title
There was a problem hiding this comment.
Pull request overview
Consolidates the repo’s modernization track by moving project targets to .NET 10 and refreshing CI workflows, while also improving emulator/device command robustness (process output draining, adb transient handling, and app launch retries).
Changes:
- Add/advance .NET 10 target frameworks across tool/library/test projects.
- Modernize GitHub Actions workflows (actions versions, .NET 10 baselines, OS matrices, artifact-based TRX publishing, and
dotnet $TOOLinvocation). - Improve runtime reliability around adb/emulator operations (transient adb failures, app launch retries, and process output completion).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
AndroidSdk/ProcessRunner.cs |
Waits briefly for stdout/stderr close events after process exit to reduce truncated output. |
AndroidSdk/Emulator/Emulator.cs |
Treats transient adb failures as “not found” during emulator serial discovery. |
AndroidSdk/Adb/Adb.cs |
Adds retry logic and syskey suppression for monkey-based app launches. |
AndroidSdk.Tool/Commands/Device/DeviceLaunchCommand.cs |
Adjusts CLI launch handling when no activity is specified. |
AndroidSdk.Tool/AndroidSdk.Tool.csproj |
Adds net10.0 to tool multi-targeting. |
AndroidSdk.Tests/EmulatorOperations_Tests.cs |
Updates emulator launch assertion to match new launch behavior. |
AndroidSdk.Tests/AndroidSdk.Tests.csproj |
Moves tests to net10.0. |
AndroidSdk.Adbd.Tests/AndroidSdk.Adbd.Tests.csproj |
Moves tests to net10.0. |
AndroidRepository/AndroidRepository.csproj |
Adds net10.0 to library multi-targeting. |
.github/workflows/test.yml |
Adds Linux+macOS matrix, uploads TRX artifacts, and separates publishing into a follow-up job. |
.github/workflows/run.yml |
Updates to .NET 10 and modernizes command execution (dotnet $TOOL), plus matrix coverage and more validations. |
.github/workflows/build-publish.yml |
Updates actions and .NET baseline to .NET 10. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This aligns project targets with the deferred net10 modernization from #56 while keeping the scope intentionally mechanical and low risk. The change only updates target framework declarations and avoids behavioral churn so it can be reviewed independently from workflow changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…r updates This is PR 2 of 2 in the follow-up plan: all workflow modernization lands in one place after the net10 framework PR. It upgrades workflow tooling to .NET 10, adopts matrix-based CI coverage, and switches run workflow invocations to the built tool DLL while preserving strict launch-marker checks and avoiding API36/logcat fallback pivots. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reruns on the previous workflow run IDs kept producing a stale failing Test Results check due mixed-attempt artifacts. This empty commit triggers fresh pull_request runs with clean artifacts for reliable status. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ases The Ubuntu matrix leg was repeatedly failing on emulator-boot dependent tests while the macOS leg remained the full integration signal. This keeps broad test coverage in place, preserves full macOS validation, and makes Linux CI deterministic by filtering only the known flaky emulator-dependent cases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- restore full test matrix execution in workflow test job - handle transient adb device-list failures during emulator startup - improve ProcessRunner stream-drain reliability before returning - harden LaunchApp monkey invocation with syskey filtering and retries Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The macOS emulator job can hang in the AVD start step when boot detection stalls. This caps wait time with --timeout 300 so the step is bounded and can recover on rerun instead of hanging indefinitely. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The macOS emulator run intermittently fails with PackageInstaller storage NPE during app install. Add a bounded retry loop that rechecks package presence to make install robust without weakening validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Change app launch logic to check for output success.
mattleibow
force-pushed
the
best56/f2-2-workflows
branch
from
February 18, 2026 20:28
b34eef1 to
3963894
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mattleibow
changed the title
Adds net10.0 to the multi-target list while preserving all existing targets (netstandard2.0, net6.0, net8.0) for broad compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
macOS CI runners have variable boot times (4–14+ min observed). The 15-minute cap was too tight for slower runs, causing the EmulatorBootFixture to fail and skipping all EmulatorOperations tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Boot wait now logs elapsed time. CPU threshold wait logs elapsed time, last observed load, and threshold on both success and timeout. This makes CI logs actionable when tuning --cpu-threshold values. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace --disable-animations with --no-animations|--no-anim to match the --no-window/--no-audio/--no-boot-anim naming convention. - CPU threshold timeout now sets exit code 1 (matching boot timeout behavior) instead of silently proceeding. - WaitForCpuLoadBelow now exposes last observed load value via out parameter for diagnostic reporting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When --timeout is not set, WaitForBootComplete correctly treats TimeSpan.Zero as 'wait forever', but GetStepTimeout was returning a 120s fallback for the CPU threshold wait. Now both treat TimeSpan.Zero consistently as no timeout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Restore GetStepTimeout fallback parameter (120s) so WaitForCpuLoadBelow
never receives TimeSpan.Zero (= infinite loop) when --timeout is omitted
- Revert CPU threshold timeout to warn-and-proceed (remove ok = false):
CPU is naturally high post-boot on macOS CI (~38 vs 3.0 threshold);
the emulator is functional so unsettled CPU should warn, not fail
- Extract DefaultCpuSettleTimeoutSeconds constant for clarity
- Add EmulatorStartOptions.Cores (int?) mapped to emulator -cores flag
- Add --cores CLI option to AvdStartCommand (int?, consistent type)
- Wire Cores through AvdStartCommand.ExecuteAsync -> EmulatorStartOptions
- Add --cores ${{ matrix.cores }} to run.yml avd start step (cores: 2)
so macOS/Ubuntu runners use 2 virtual cores instead of the default 1
- Add AvdStartCommandSettingsAllowCores validation test
Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
- Remove DefaultCpuSettleTimeoutSeconds: WaitForCpuLoadBelow now waits until --timeout budget expires or the step is cancelled externally - Revert GetStepTimeout back to 2-parameter signature (no fallback) - Add timeout-minutes: 30 to the Do Start AVD workflow step so the CI job times out cleanly instead of hanging indefinitely - Move cpu_threshold into the matrix: 30 for macos-15-intel (high post- boot load), 3 for ubuntu-latest (KVM stays consistently low) Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
Replace the GitHub Actions timeout-minutes: 30 property with the tool's own --timeout flag (1800 seconds = 30 min). Add timeout_seconds to the matrix so each OS entry controls its own boot timeout independently. Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
Fix avd start infinite hang + add --cores and per-OS cpu-threshold
…ng on macOS Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
…low emulators Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
Fix macOS emulator boot hang: remove launcher focus check, unify --timeout budget
…t markers Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
…ring Co-authored-by: mattleibow <1096616+mattleibow@users.noreply.github.com>
…r-issue Restore launcher readiness check after boot; require dual logcat markers for launch validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The project was still on .NET 9 with older GitHub Actions versions, and emulator CI runs were flaky enough that macOS matrix legs couldn't be trusted. This PR upgrades everything to .NET 10 and fixes the specific reliability gaps that were causing intermittent failures — so we ship a modern baseline with a CI pipeline that actually stays green.
What's in this PR
.NET 10 target frameworks
net10.0alongside existing targets (netstandard2.0,net6.0,net8.0); no compatibility changenet10.0alongside existing targetsnet10.0alongside existing targetsnet9.0tonet10.0net9.0tonet10.0Workflow modernization (
build-publish.yml)actions/checkoutto v4,actions/setup-dotnetto v4,actions/download-artifactto v4Test workflow overhaul (
test.yml)fail-fast: falseEnricoMi/publish-unit-test-result-action@v2always() && !cancelled()so results are never lost on failed test runsEmulator run workflow overhaul (
run.yml)dotnet run --framework net9.0 --project AndroidSdk.Tool --todotnet $TOOLusing the pre-built DLLAVD_NAME,TEST_APP_PACKAGE,APP_START_MARKER— no more magic strings scattered through steps--cpu-threshold 3.0to wait for the guest CPU to settle before proceedingAPP_START_MARKER${{ matrix.os }}CLI improvements (
AvdStartCommand.cs)--disable-animationsto--no-animations|--no-animto match the--no-window/--no-audio/--no-boot-animnaming conventionProcess output reliability (
ProcessRunner.cs)TaskCompletionSourcesignals for stdout/stderr stream closureWaitForExit()now waits up to 5 seconds for both streams to close after the process exits, preventing a race where output lines were silently lostApp launch reliability (
Adb.cs)LaunchAppnow retries monkey up to 3 times with a 1-second delay between attempts--pct-syskeys 0to prevent random HOME/BACK key events during launchEvents injectedsuccess; on exhausted retries, returns the last attempt output (never throws)SdkToolFailedExitExceptionon intermediate attempts and preservesStdOutfor the return valueEmulator lifecycle reliability (
Emulator.cs)FindRunningEmulatorSerialByAvdNamecatches transientSdkToolFailedExitExceptionfromadb.GetDevices()and returnsnull— the caller's polling loop retries naturallyStopAvdpolling and final check now also catch transientSdkToolFailedExitExceptionfromadb.GetDevices()instead of crashing during emulator shutdownWaitForCpuLoadBelownow exposes the last observed load value for diagnostic reportingTest fixture reliability (
EmulatorTestsBase.cs)EmulatorBootFixtureboot timeout from 15 to 20 minutes — macOS CI runners show boot times ranging from 4 to 14+ minutesBreaking changes
--disable-animationsCLI flag removed; use--no-animationsor--no-animinstead--cpu-thresholdtimeout now returns exit code 1 (previously returned 0 with a warning)Explicitly excluded
Validation
dotnet build --configuration Release✅