Android SDK/JDK Detection Issues

[aritchie]

Android Keystores

• JDK Found 21

Doctor

• OpenJDK not found

NOTE: The doctor isn't seeing any of my android SDK stuff installed either.

[aritchie]

Brew installed Microsoft JDK v21.

installer: Package name is Microsoft Build of OpenJDK
installer: Installing at base path /
installer: The install was successful.
==> Purging files for version 21.0.9 of Cask microsoft-openjdk@21
🍺 microsoft-openjdk@21 was successfully upgraded!

[aritchie]

I borked your android tool

android sdk list
Error: Object reference not set to an instance of an object.
android sdk info
Error: Object reference not set to an instance of an object.
android sdk info
Error: Object reference not set to an instance of an object.

[Redth]

I wonder if we aren't looking where brew installs things for ms openjdk.

[aritchie]

The installer does create a symlink though - /Library/Java/JavaVirtualMachines/microsoft-21.jdk/Contents/Home

[Redth]

Found two issues in the upstream AndroidSdk.Tools library's JdkLocator.cs:

1. Mac Catalyst platform detection: IsMac property uses RuntimeInformation.IsOSPlatform(OSPlatform.OSX) which returns false on Mac Catalyst. This skips the entire Mac JDK search including /Library/Java/JavaVirtualMachines/ where brew installs Microsoft OpenJDK.

2. Minor bug: The /Library/Java/JavaVirtualMachines/ enumeration loop passes the parent javaVmDir instead of the matched javaVmJdkDir to SearchDirectoryForJdks.

Re: symlinks — Homebrew's microsoft-openjdk@21 cask installs via a .pkg which puts real files (not symlinks) at /Library/Java/JavaVirtualMachines/microsoft-21.jdk/. .NET's Directory.Exists/File.Exists follow symlinks by default anyway, so symlinks are not an issue.

Fix PR: Redth/AndroidSdk.Tools#53

Note: MauiSherpa's own DoctorService already handles Mac Catalyst correctly (IsMacPlatform => OperatingSystem.IsMacOS() || OperatingSystem.IsMacCatalyst()), but OpenJdkSettingsService also uses RuntimeInformation.IsOSPlatform(OSPlatform.OSX) — should probably be updated too for consistency.

[aritchie]

Discovered the NRE in the androidtool on my machine - Running android sdk info eventually gets to a call GetVersion (that does check for null) but it goes down into SdkManager (JavaProcessRunner Start) that assumes sdkManager is found
It isn't as straight as a fix to start accounting for null and returning a null JavaProcessRunner as it started to NRE elsewhere after that.

My SDK is in a standard path - /Users/allanritchie/Library/Android/sdk
I wonder if permissions are involved somehow

[aritchie]

The issue is that I installed my android SDK through Android Studio which doesn't install the "Android SDK Command line tools" by default.