Skip to content
This repository was archived by the owner on Sep 4, 2026. It is now read-only.
This repository was archived by the owner on Sep 4, 2026. It is now read-only.

APCDataSubstrate depends on category methods during initialization #30

Description

@p2

During initialization, APCDataSubstrate initializes its CoreData stack and a HKStore handle. These methods are defined in the categories CoreData and HealthKit, which makes for neat code separation but technically is not suitable for a category.

Activity

  1. jwe-apple commented on May 4, 2015

    @jwe-apple
    Member

    This is actually ok as long as they are always built together (which they are, if you build APCAppCore as a whole). Could see an argument for merging them all into one h/m pair but retaining the category separation, but don't think it's a strong one. If you're cherry-picking files into another project, why not just pick them all?

  2. p2 commented on May 4, 2015

    @p2
    MemberAuthor

    I find it strange that a class cannot live without categories of itself. Sure, I can include them all, but since it's not that much code (HealthKit is a one-line method) I'm not sure this separation is needed.

  3. jwe-apple commented on May 6, 2015

    @jwe-apple
    Member

    Happy to accept a PR for this.

  4. added a commit that references this issue on May 14, 2015
    c93c3ac
  5. added a commit that references this issue on Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions