Skip to content

MNT: let pylint use every core it is given - #1163

Merged
Gui-FernandesBR merged 1 commit into
RocketPy-Team:developfrom
thc1006:mnt/pylint-uses-every-core
Aug 14, 2026
Merged

MNT: let pylint use every core it is given#1163
Gui-FernandesBR merged 1 commit into
RocketPy-Team:developfrom
thc1006:mnt/pylint-uses-every-core

Conversation

@thc1006

@thc1006 thc1006 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Pull request type

  • Code maintenance (refactoring, formatting, tests)

Checklist

  • Lint (pylint rocketpy/ tests/ docs/) has passed locally
  • All tests have passed locally

Current behavior

.pylintrc sets jobs=1, so the lint runs in one process no matter what the machine has. The comment directly above it already describes 0 as the auto-detecting value, including the Windows cap, so the setting reads as a leftover rather than a decision.

New behavior

jobs=0. Measured over rocketpy/, tests/ and docs/ on eight cores:

setting wall clock exit code
jobs=1 36.4s 0
jobs=0 14.0s 0

I diffed the two message sets rather than trusting the exit code, since some checkers behave differently when the files are split across processes. They are identical, so the gate is the same one and only the wait is shorter.

This reaches CI, the Makefile target and a plain local pylint at once, because all three read this file rather than passing -j.

Breaking change

  • No

Additional information

Windows is the usual worry with -j. pylint caps the process count there itself, which is what the comment in the file says, and the linters workflow runs on ubuntu-latest in any case.

jobs=1 pins the run to one process. Measured on eight cores over rocketpy/,
tests/ and docs/: 36.4s at jobs=1 against 14.0s at jobs=0, and the two produce
the same messages, so the gate is unchanged and only the wait is shorter.

0 asks pylint to count the processors itself, which is what the comment above
the setting already describes, and it caps the count on Windows on pylint's own
side.

Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
@thc1006
thc1006 requested a review from a team as a code owner August 14, 2026 20:56
@Gui-FernandesBR
Gui-FernandesBR merged commit 3e16c9f into RocketPy-Team:develop Aug 14, 2026
2 checks passed
@thc1006
thc1006 deleted the mnt/pylint-uses-every-core branch August 14, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants