BUG: build Monte Carlo flights with the configuration they were given

[thc1006]

Pull request type

• Code changes (bugfix, features)

Checklist

• Tests for the changes have been added (if needed)
• Docs have been reviewed and added / updated
• Lint (ruff check / ruff format --check, pylint) has passed locally
• All tests (pytest tests/unit tests/integration) have passed locally

Current behavior

MonteCarlo.__run_single_simulation writes the Flight constructor out by hand and stops at time_overshoot. StochasticFlight.create_object passes nine arguments it does not:

max_time, max_time_step, min_time_step, rtol, atol, name, equations_of_motion, ode_solver, simulation_mode.

Counted on develop: 8 keyword arguments in the Monte Carlo path against 17 in StochasticFlight.create_object.

So a Monte Carlo run ignores the max time, the tolerances, the solver and the equations of motion the caller set, and resets the simulation mode to the constructor default. The same rocket, environment and flight fly differently under MonteCarlo than under StochasticFlight.create_object, which is the opposite of what #1070 added StochasticFlight's handling of these for.

New behavior

The Monte Carlo path passes the same seventeen, read the same way StochasticFlight.create_object reads them: max_time off the stochastic model, the rest off the flight it wraps.

Breaking change

• No

Runs that set any of these were silently getting the defaults, so their results change. That was the bug.

Additional information

One test builds the flight through __run_single_simulation with a stand-in Flight and asserts each of the nine arrives. Dropping max_time, the solver, or the pair of tolerances turns it red.

Local run against develop at 1d04bcc: ruff clean, pylint exit 0, pytest tests/unit tests/integration 2214 passed, 51 skipped.

#1126 is open against this same method, for the separate matter of how the launch fields are sampled. This change only appends to the argument list and leaves those lines alone, but whichever lands second will want a look.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.33%. Comparing base (f604534) to head (0f4b33f).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1164   +/-   ##
========================================
  Coverage    84.32%   84.33%           
========================================
  Files          130      130           
  Lines        17258    17258           
========================================
+ Hits         14553    14554    +1     
+ Misses        2705     2704    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.