Skip to content

MNT: bumps min python version to 3.10 - #857

Merged
phmbressan merged 7 commits into
developfrom
mnt/min-python-version-310
Oct 19, 2025
Merged

MNT: bumps min python version to 3.10#857
phmbressan merged 7 commits into
developfrom
mnt/min-python-version-310

Conversation

@Gui-FernandesBR

Copy link
Copy Markdown
Member

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Enter text here...

New behavior

Enter text here...

Breaking change

  • Yes
  • No

Additional information

Enter text here...

@Gui-FernandesBR

Copy link
Copy Markdown
Member Author

Python 3.14 will be released at Oct 7th, aka this Tuesday.
After that, I expect CI to be get run correctly.
Let's wait for it.

https://devguide.python.org/versions/

@Gui-FernandesBR
Gui-FernandesBR force-pushed the mnt/min-python-version-310 branch from cff273f to 0f035fe Compare October 8, 2025 15:46
@codecov

codecov Bot commented Oct 13, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.26%. Comparing base (f17893b) to head (bc6dd6f).
⚠️ Report is 28 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/mathutils/function.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #857      +/-   ##
===========================================
+ Coverage    80.02%   80.26%   +0.24%     
===========================================
  Files           98      104       +6     
  Lines        12004    12767     +763     
===========================================
+ Hits          9606    10248     +642     
- Misses        2398     2519     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phmbressan
phmbressan force-pushed the mnt/min-python-version-310 branch from b824966 to 6b1dc13 Compare October 18, 2025 12:55
@phmbressan

phmbressan commented Oct 18, 2025

Copy link
Copy Markdown
Collaborator

Retrying Python 3.14 on the CI, since this command pytest && pytest -m slow --runslow && pytest rocketpy/ --doctest-modules worked for me locally on the new version.

Edit: All passing on the CI.

@Gui-FernandesBR
Gui-FernandesBR force-pushed the mnt/min-python-version-310 branch from 6b1dc13 to 0407cb7 Compare October 18, 2025 17:12
@Gui-FernandesBR

Copy link
Copy Markdown
Member Author

@copilot could you please update our CHANGELOG?

@phmbressan
phmbressan merged commit af7bbff into develop Oct 19, 2025
9 of 10 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Closed in LibDev Roadmap Oct 19, 2025
@phmbressan
phmbressan deleted the mnt/min-python-version-310 branch October 19, 2025 07:52
Gui-FernandesBR pushed a commit that referenced this pull request Aug 12, 2026
…ove (#1139)

* docker: mount the repository root in compose, not the docker folder

#732 moved docker-compose.yml into docker/. Compose resolves relative
host paths against the compose file's own directory, so `- .:/app`
mounts docker/, which has no pyproject.toml and no requirements-tests.txt
for the services to install.

* docker: raise the compose service to the python floor the package declares

#857 moved requires-python to >=3.10; pip declines the install on 3.9.
Renamed the service key so it does not outlive the version again.

* docker: pin the base image to python:3.14

python:latest and python:3.14 are the same digest today, so the image
does not change. 3.14 is the ceiling of the test matrix, and a pinned
tag is one renovate can see and bump.

* docs: describe the docker layout as it is after #732

The build command needs a repository-root context to find
requirements.txt, compose runs from inside docker/, and the file
tests 3.10 and 3.12 rather than 3.9 and 3.12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants