allow disabling check for updates#278
Conversation
|
I'm all for this, but the implementation isn't what I like. Consider using |
unsecretised
left a comment
There was a problem hiding this comment.
Switch to run_with
|
Could you also consider joining the discord? |
|
sure, I can join. |
switch to run_with
|
A few questions, Have you used AI in them? I'm not against AI but it's just that I need to know if the code is going to work and that you are willing to vouch for the code generated by the models. |
|
Yes, I have used AI to assist in these PRs. Sorry I did not notify you before, it wasn't intentional and hope it's forgivable in retrospect. FWIW I did review any generated code, wrote all PR descriptions myself, and am comfortable vouching for the code (although with less confidence for this particular file for the window tiling (different PR)). That part is a little outside of my wheelhouse admittedly, and if you don't want to merge it I'll understand. Most of these features I'm implementing for my own sake and just want to offer upstream for public benefit. |
|
Sorry, accidentally pushed some commits to the wrong branch, pls ignore |
This is just something I want, and if you don't want to merge it, no hard feelings, but I figured if I wanted it, maybe someone else will want it and the default value can keep the behavior the same as it was before.