Skip to content

allow disabling check for updates#278

Closed
theryangeary wants to merge 7 commits into
RustCastLabs:masterfrom
theryangeary:master
Closed

allow disabling check for updates#278
theryangeary wants to merge 7 commits into
RustCastLabs:masterfrom
theryangeary:master

Conversation

@theryangeary

Copy link
Copy Markdown
Contributor

This is just something I want, and if you don't want to merge it, no hard feelings, but I figured if I wanted it, maybe someone else will want it and the default value can keep the behavior the same as it was before.

@unsecretised

Copy link
Copy Markdown
Collaborator

I'm all for this, but the implementation isn't what I like.

Consider using subscription::run_with

@unsecretised unsecretised left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to run_with

@unsecretised

Copy link
Copy Markdown
Collaborator

Could you also consider joining the discord?

@theryangeary

Copy link
Copy Markdown
Contributor Author

sure, I can join.

@unsecretised unsecretised left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unsecretised

Copy link
Copy Markdown
Collaborator

@theryangeary

A few questions,
You've made a few PRs to this repo in the past few days.

Have you used AI in them?
I prefer to be notified if AI was used in the code.

I'm not against AI but it's just that I need to know if the code is going to work and that you are willing to vouch for the code generated by the models.

@theryangeary

Copy link
Copy Markdown
Contributor Author

Yes, I have used AI to assist in these PRs. Sorry I did not notify you before, it wasn't intentional and hope it's forgivable in retrospect. FWIW I did review any generated code, wrote all PR descriptions myself, and am comfortable vouching for the code (although with less confidence for this particular file for the window tiling (different PR)). That part is a little outside of my wheelhouse admittedly, and if you don't want to merge it I'll understand. Most of these features I'm implementing for my own sake and just want to offer upstream for public benefit.

@theryangeary

Copy link
Copy Markdown
Contributor Author

Sorry, accidentally pushed some commits to the wrong branch, pls ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants