aes: refactor backends#575
Open
newpavlov wants to merge 10 commits into
Open
Conversation
newpavlov
marked this pull request as ready for review
July 21, 2026 14:07
tarcieri
reviewed
Jul 23, 2026
| impl Clone for $name { | ||
| #[inline] | ||
| fn clone(&self) -> Self { | ||
| unsafe { core::ptr::read(self) } |
Member
There was a problem hiding this comment.
This feels a little brittle. I'm surprised it isn't triggering a lint.
tarcieri
reviewed
Jul 23, 2026
| pub(crate) mod x86_aes; | ||
|
|
||
| #[cfg(all( | ||
| any(aes_backend = "avx256", aes_backend = "avx256"), |
Member
There was a problem hiding this comment.
This seems to be duplicated?
Suggested change
| any(aes_backend = "avx256", aes_backend = "avx256"), | |
| aes_backend = "avx256", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies and consolidates switching between backends. Fixes performance regression introduced in v0.9.
Closes #574