Skip to content

feat: change pattern properties. - #4450

Merged
hyperupcall merged 4 commits into
SchemaStore:masterfrom
ya7010:update_poetry_pattern_properties
Feb 17, 2025
Merged

hyperupcall merged 4 commits into
SchemaStore:masterfrom
ya7010:update_poetry_pattern_properties

Conversation

@ya7010

@ya7010 ya7010 commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

Change to simple pattern.

See #4434 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall

Copy link
Copy Markdown
Member

Looks like linter in CI is complaining due to use of that patternProperties. Using additionalProperties instead of patternProperties should fix things

@ya7010

ya7010 commented Feb 17, 2025 •

Copy link
Copy Markdown
Contributor Author

@hyperupcall

I fixed 991047c

But I found merge conflict error 5e76103

Should I separate another PR?

@btea

btea commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

I have created a PR #4451, do I need to close it?

@hyperupcall

Copy link
Copy Markdown
Member

Oops, nope it looks like it's already mergable as-is. Thank you!

@hyperupcall
hyperupcall merged commit e69f87f into SchemaStore:master Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants