Repository navigation
fix(server): explain merge queue check timeouts in PR watch wakes - #843
Merged
Merged
Conversation
GitHub removes a pull request with reason "checks_timed_out" when its queue checks run past the queue's timeout; a wake read "...without merging: checks_timed_out." It now says the checks did not finish in time and ran on the queue's own commit. The fingerprint test also feeds totalCount, so only removals may move the status. Matches the follow-ups sent to pingdotgg/t3code#24141. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yaacovcorcos
enabled auto-merge
November 10, 2026 17:36
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
A follow-up to #819, so Scient matches the follow-ups sent upstream on pingdotgg/t3code#24141:
checks_timed_out. The wake used to read "…without merging: checks_timed_out." It now says the checks did not finish in time, and that they ran on the queue's own commit, not on the head.totalCountandfilteredCountdifferent values. A timeline item that is not a removal must leave the status alone. This fails on the oldtotalCountcode because of the fingerprint behaviour, not a decode error.Why
This repo has seen
checks_timed_out4 times among its 471 queue removals since 2026-09-29. A probe PR (ScientFactory/merge-queue-watch-probe#7, with a 1-minute queue check timeout) reproduced the reason live. Read through the real GitHub API code, it woke with the new sentence.Documentation Impact
Documentation impact: None — agent-facing wake text only.
Verification
pullRequestWatch.test.ts(32) andgitHubPullRequestJson.test.ts(64) pass.source-control-githubtypecheck, lint and format pass.Checklist
🤖 Generated with Claude Code