Repository navigation
fix(server): overlapping status reads share one untracked listing - #864
Merged
Merged
Conversation
Follow-ups to the untracked backoff and Codex kill deadline, both now merged in T3: overlapping reads share one running listing, the remembered failure keeps the listing error as its cause, and the kill-deadline test waits for its stand-in's ready line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yaacovcorcos
enabled auto-merge
November 11, 2026 21:52
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Follow-ups to #861's untracked backoff and Codex kill deadline, which T3 has since merged as pingdotgg/t3code#34460 and #34461. All changes sit in the existing fork-marked blocks and
.scient.test.tsfiles:git ls-files --otherslisting is running waits for it instead of starting another walk of the untracked tree. This uses an EffectCachewith zero time-to-live, so only an in-flight listing is shared, and a shared listing keeps running until the last read waiting on it leaves. Each read still builds its own temporary review index.GitCommandErrorascause, for a fresh failure and for the remembered one.readybefore stopping it, so an early exit can no longer pass without testing the force-kill.UPSTREAM.md: records that #34460 and #34461 are merged in T3 and links the two new T3 PRs.Why
CodeRabbit raised these three points on the T3 PRs, and they were merged without being addressed. A status read restarted by a file change during a slow listing (up to the 30 s timeout) started another full walk of the tree before the backoff could apply. The same changes are offered upstream as pingdotgg/t3code#34574 (listing and cause) and #34575 (test). When they merge, the next alignment takes T3's version and drops these blocks.
Verification
share one listing between overlapping status reads(GitVcsDriverCore.scient.test.ts): it holds the first read's listing until the second read's last Git command before its own listing has returned.main: fails with 2 listings.mainand passed 5 of 5 with the change.exit 0, the old test passes and the new one fails.causechange has no test of its own: status reports a totals failure as missing totals, so the cause shows only in thereadBranchChangeTotalsspan.GitVcsDriverCore.scient.test.tsandCodexAdapterV2.scient.test.ts(86 tests), server typecheck,vp lint,vp fmt --check, seam check and provenance all pass on macOS.Platforms: no platform-specific code. The shared listing behaves the same on macOS, Linux and Windows. The Codex test stays skipped on Windows, as before. Run on macOS only; CI covers Linux and Windows.
Documentation Impact
Documentation impact: Updated —
UPSTREAM.mdUI Changes
None.
Made with Claude Opus 5.5 in Claude Code; reviewed by Codex (gpt-6.1-sol).
🤖 Generated with Claude Code