[py] Type BaseOptions.set_capability parameters - #18027
Merged
diemol merged 4 commits intoSep 16, 2026
Merged
Conversation
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Member
|
@adamtheturtle can you check the PR description? Looks like the formar went wrong. Also, can you please follow the PR template? |
Contributor
Author
|
Thanks — I fixed the formatting and rewrote the description using the current PR template, including the AI-assistance disclosure. |
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full |
Contributor
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
None.
💥 What does this PR do?
Annotates
BaseOptions.set_capabilityso strict Pyright consumers no longer see a partially unknown method type.🔧 Implementation Notes
str.objectbecause extension capabilities can contain heterogeneous user-supplied values and the method stores them unchanged.Validation:
git diff --checkpassed.(name: str, value: object) -> None.🤖 AI assistance
💡 Additional Considerations
This is annotation-only and does not change runtime behavior.
🔄 Types of changes