Skip to content

[dotnet] [build] Include package license/notice files - #18048

Merged
titusfortner merged 4 commits into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-package-notice
Sep 22, 2026
Merged

titusfortner merged 4 commits into
SeleniumHQ:trunkfrom
nvborisenko:dotnet-package-notice

Conversation

@nvborisenko

Copy link
Copy Markdown
Member

🔗 Related Issues

Contributes to #16113

💥 What does this PR do?

This pull request ensures that the LICENSE and NOTICE files are included in the distributed artifacts for both the Selenium.Support and Selenium.WebDriver .NET packages, as well as making these files available as exported files in the Bazel build. This change helps maintain compliance with open source licensing requirements.

Packaging and distribution compliance:

  • Updated dotnet/src/support/BUILD.bazel and dotnet/src/webdriver/BUILD.bazel to include LICENSE and NOTICE files in the NuGet package contents for both Selenium.Support and Selenium.WebDriver. [1] [2]
  • Modified dotnet/src/support/Selenium.Support.nuspec and dotnet/src/webdriver/Selenium.WebDriver.nuspec to explicitly add LICENSE and NOTICE files to the NuGet packages. [1] [2]

Build system updates:

  • Added LICENSE and NOTICE to the list of exported files in BUILD.bazel so they are available for packaging and distribution.

🤖 AI assistance

  • No substantial AI assistance used
  • AI assisted (complete below)
    • Tool(s):
    • What was generated:
    • I reviewed all AI output and can explain the change

🔄 Types of changes

  • New feature (non-breaking change which adds functionality)

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@selenium-ci selenium-ci added C-dotnet .NET Bindings B-build Includes scripting, bazel and CI integrations B-support Issue or PR related to support classes labels Sep 17, 2026
@selenium-ci

Copy link
Copy Markdown
Member

Thank you, @nvborisenko for this code suggestion.

The support packages contain example code that many users find helpful, but they do not necessarily represent
the best practices for using Selenium, and the Selenium team is not currently merging changes to them.

After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium
to work, we will likely close the PR.

We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks.
If you have any questions, please contact us

Comment thread dotnet/src/support/BUILD.bazel Outdated
Comment thread dotnet/src/support/Selenium.Support.nuspec
Comment thread BUILD.bazel Outdated
@titusfortner

titusfortner commented Sep 19, 2026 •

Copy link
Copy Markdown
Member

/agentic_review

1 similar comment
@titusfortner

Copy link
Copy Markdown
Member

/agentic_review

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@titusfortner

Copy link
Copy Markdown
Member

I think .NET should follow the existing convention with the //:license filegroup instead of creating something new.

@nvborisenko

Copy link
Copy Markdown
Member Author

Done, please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations B-support Issue or PR related to support classes C-dotnet .NET Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants