Add domain in default run_id#156
Merged
Merged
Conversation
My only concern is that the domain name `medical_hr` contains an underscore, which is the separator we use between the bits of id here. A `run_id` like `<date>_medical_hr_en_<models>` is slightly confusing. Furthermore, `hr` is the language code for Croatian. A couple of solutions: 1. Write `medical-hr` instead of `medical_hr`. There are often dashes within language codes and within model names. But then, it doesn't match the domain name exactly. 2. Change our separator for something that risks fewer collisions, like a tilde `~`. 3. Live with it.
JosephMarinier
commented
Jun 19, 2026
JosephMarinier
commented
Jun 23, 2026
| file=TqdmNewlineStream(sys.stderr), | ||
| mininterval=0, | ||
| unit="task", | ||
| smoothing=0, # Smoothing would produce unstable estimates because tasks run in parallel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the domain name in the default
run_id.