Add SelfDrop parity specs#141
Open
karreiro wants to merge 1 commit into
Open
Conversation
aswamy
approved these changes
Jun 2, 2026
Contributor
aswamy
left a comment
aswamy
left a comment
There was a problem hiding this comment.
Few questions, but tests look good 👍
EvilGenius13
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds extra
liquid-speccoverage for bare-bracket rejection and the newselfdrop behavior.The specs cover bare bracket parse errors,
self['key']/self[key]as the dynamic lookup path, scope lookup and local shadowing, missing keys, nested lookups, loops, captures, render boundaries, static environment keys namedself, counters namedself, special names likesize/first/last, equality, filters, and stringification.--
CI will pass once Shopify/liquid#2091 gets merged.