undefined.empty? is not true or false #609

Activity

1. pushrax commented on Jul 6, 2015

   

   pushrax

   on Jul 6, 2015

   Contributor

   More actions

   a is not defined, so its value is nil. nil does not have an empty? property, so the result of the whole keypath is nil, which doesn't match any of the cases so the else is hit.

   It's a weird test though, since empty? is not actually a thing in Liquid (unless you expose it specifically in a drop or hash).
2. pushrax

   closed this as completedon Jul 6, 2015
3. pushrax

   added

   Question

   on Jul 6, 2015
4. mikebridge commented on Jul 6, 2015

   

   mikebridge

   on Jul 6, 2015

   Author

   More actions

   @pushrax Ah, so you're saying that the case statement does not actually compare based on truthiness, correct? I see that the following does not use truthiness as a basis for comparison either:

       {% case nil %}{% when false %}FALSE{% when true %}TRUE{%else%}NOT TRUE OR FALSE{% endcase %}
       --> NOT TRUE OR FALSE
   
       {% case 0 %}{% when true %}TRUE{% when false %}FALSE{%else%}NOT TRUE OR FALSE{% endcase %}
       --> NOT TRUE OR FALSE
   

   Without knowing that, I would have expected those to return "FALSE" and "TRUE", respectively....
5. pushrax commented on Jul 6, 2015

   

   pushrax

   on Jul 6, 2015

   Contributor

   More actions

   It works similarly to ruby when using equality rather than truthiness (in ruby nil != false).
6. mikebridge commented on Jul 6, 2015

   

   mikebridge

   on Jul 6, 2015

   Author

   More actions

   Ok, thanks for the clarification!