Skip to content

Minor version bump to 0.7.2 - #168

Closed
meagar wants to merge 1 commit into
masterfrom
bump-to-v0.7.2-for-gem-release
Closed

meagar wants to merge 1 commit into
masterfrom
bump-to-v0.7.2-for-gem-release

Conversation

@meagar

@meagar meagar commented Oct 13, 2017

Copy link
Copy Markdown

Bump to 0.7.2 for release to RubyGems

@andrewloux andrewloux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meagar

meagar commented Oct 13, 2017

Copy link
Copy Markdown
Author

It looks like something is up with travis, @dalehamel you're the last person to touch travis.yml and @camilo your previous build failed for the same reason, anybody recognize this? Do we need to change the version of redis being provisioned by travis?

  1) Error:
TestRedis#test_connection_errors_open_the_circuit:
Redis::CommandError: ERR Syntax error, try CLIENT (LIST | KILL | GETNAME | SETNAME | PAUSE | REPLY)
    /home/travis/.rvm/gems/ruby-2.3.1/gems/redis-4.0.0/lib/redis/client.rb:119:in `call'
    /home/travis/.rvm/gems/ruby-2.3.1/gems/redis-4.0.0/lib/redis.rb:210:in `block in client'
    /home/travis/.rvm/gems/ruby-2.3.1/gems/redis-4.0.0/lib/redis.rb:45:in `block in synchronize'
    /home/travis/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/monitor.rb:214:in `mon_synchronize'
    /home/travis/.rvm/gems/ruby-2.3.1/gems/redis-4.0.0/lib/redis.rb:45:in `synchronize'
    /home/travis/.rvm/gems/ruby-2.3.1/gems/redis-4.0.0/lib/redis.rb:209:in `client'
    /home/travis/build/Shopify/semian/lib/semian/redis.rb:28:in `initialize'
    /home/travis/build/Shopify/semian/test/redis_test.rb:222:in `new'
    /home/travis/build/Shopify/semian/test/redis_test.rb:222:in `new_redis'
    /home/travis/build/Shopify/semian/test/redis_test.rb:233:in `connect_to_redis!'
    /home/travis/build/Shopify/semian/test/redis_test.rb:46:in `test_connection_errors_open_the_circuit'

@meagar

meagar commented Nov 6, 2017

Copy link
Copy Markdown
Author

Closing in favor of #170

@meagar meagar closed this Nov 6, 2017
@epk
epk deleted the bump-to-v0.7.2-for-gem-release branch June 26, 2019 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants