Fix FileSnippet test race and retry the unchanged-content read - #846
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 28.4.4 release failed on net48 with
IOException: ... one.md ... being used by another processinFileSnippetExplicitIncludeBypassesExcludeSnippetFiles(reproduced locally 3/30).FileSnippetandFileSnippetExplicitIncludeBypassesExcludeSnippetFilesboth processedDirectoryMarkdownProcessor/FileSnippetand wrote the sameone.mdin parallel. The second now has its own copy of the fixture (FileSnippetExplicitInclude).WriteLinesread the existing target to skip unchanged writes with no retry, while the write already retried onIOException. The read now retries the same way, and treats a still-locked file as changed so the (retrying) write path handles it.After the change: full suite passes, and the racy pair ran 30/30 clean on net48.