SONARPY-4539 FP: S1313 should not report version values assigned to __version__ - #2300
Closed
erwan-leforestier-sonarsource wants to merge 5 commits into
Closed
SONARPY-4539 FP: S1313 should not report version values assigned to __version__#2300erwan-leforestier-sonarsource wants to merge 5 commits into
erwan-leforestier-sonarsource wants to merge 5 commits into
Conversation
erwan-leforestier-sonarsource
marked this pull request as ready for review
August 19, 2026 09:07
Code Review ✅ ApprovedUpdates rule S1313 to ignore IPv4-shaped literal values assigned to version variables, eliminating false positives on package versions. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid false positives by treating IPv4-shaped literals assigned directly to the Python version variable as package versions.
Changes