Skip to content

Fix/plugin register guard#1581

Closed
beljand wants to merge 2 commits into
SortableJS:masterfrom
beljand:fix/PluginRegisterGuard
Closed

Fix/plugin register guard#1581
beljand wants to merge 2 commits into
SortableJS:masterfrom
beljand:fix/PluginRegisterGuard

Conversation

@beljand

@beljand beljand commented Jul 22, 2019

Copy link
Copy Markdown
Contributor

Mounting the same plugin twice, results in doubling the number of registered Event listeners - causing unintended behaviour.

Discovered this while trying to implement MultiDrag into Vue.Draggable

toggleClass() was called multiple times in case of multiple/nested instances of Draggable component

@owen-m1

owen-m1 commented Jul 22, 2019

Copy link
Copy Markdown
Member

Great idea, but we cannot use map or includes as these are features not included in all the browsers Sortable supports, and I am not using a polyfill for babel.

@beljand

beljand commented Jul 23, 2019

Copy link
Copy Markdown
Contributor Author

👍 will amend to meet browsers compatibility

@owen-m1

owen-m1 commented Jul 24, 2019

Copy link
Copy Markdown
Member

FYI - Tests are failing right now because of an issue I had with the old CircleCI config which you forked before I fixed

@waynevanson

Copy link
Copy Markdown
Contributor

@owen-m1 FYI - Just retested and it failed due to sauce labs authentication: we don't have the right tokens/codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants