Skip to content

fix(Build): add resolution for patched brace-expansion - BED-9060 - #3056

Merged
TheNando merged 1 commit into
mainfrom
BED-9060-brace-expansion-cve
Jul 27, 2026
Merged

TheNando merged 1 commit into
mainfrom
BED-9060-brace-expansion-cve

Conversation

@TheNando

@TheNando TheNando commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

Add explicit resolution for patched version of brace-expansion dep.

Motivation and Context

Resolves BED-9060

How Has This Been Tested?

Tested via build vuln audit

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

Summary by CodeRabbit

  • Chores
    • Updated the project’s dependency resolution to remove an override and pin brace-expansion to version 5.0.8 for more consistent installs.
    • No new features, bug fixes, or user-facing behavior changes are included in this release.

@TheNando TheNando self-assigned this Jul 27, 2026
@TheNando
TheNando requested review from a team as code owners July 27, 2026 15:37
@TheNando TheNando added user interface A pull request containing changes affecting the UI code. dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 27, 2026
@coderabbitai

coderabbitai Bot commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 06fc1df6-9f5a-441e-8225-17b410e1303b

📥 Commits

Reviewing files that changed from the base of the PR and between 1d9aa06 and a55698f.

⛔ Files ignored due to path filters (3)
  • .yarn/cache/brace-expansion-npm-5.0.7-48dc108338-98c12de33f.zip is excluded by !**/.yarn/**, !**/*.zip
  • .yarn/cache/brace-expansion-npm-5.0.8-08bf144160-75d2d2ebc8.zip is excluded by !**/.yarn/**, !**/*.zip
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

📝 Walkthrough

Walkthrough

The root package.json removes the @isaacs/brace-expansion resolution override and pins brace-expansion to 5.0.8.

Changes

Dependency resolution

Layer / File(s) Summary
Update brace-expansion resolutions
package.json
The resolutions block removes the scoped override and pins brace-expansion to 5.0.8.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: elikmiller

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change to pin brace-expansion via package.json resolution and includes the related ticket.
Description check ✅ Passed The description covers the change, motivation, testing, type, and checklist, and it includes the required ticket reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BED-9060-brace-expansion-cve

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@package.json`:
- Line 34: Update yarn.lock to resolve brace-expansion@npm:^5.0.7 to version
5.0.8, including its corresponding metadata and integrity information, so it
matches the brace-expansion dependency declared in package.json.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4caaca41-0940-47ca-b701-6bc71545e4a6

📥 Commits

Reviewing files that changed from the base of the PR and between 33224ac and 1d9aa06.

📒 Files selected for processing (1)
  • package.json

Comment thread package.json Resolved
@TheNando
TheNando force-pushed the BED-9060-brace-expansion-cve branch from 1d9aa06 to a55698f Compare July 27, 2026 15:41

@urangel urangel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@TheNando
TheNando merged commit 9ce509b into main Jul 27, 2026
13 checks passed
@TheNando
TheNando deleted the BED-9060-brace-expansion-cve branch July 27, 2026 17:16
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code user interface A pull request containing changes affecting the UI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants