Repository navigation
Conversation
- Adds principalobjectid query param with description and schema documentation to "attack-paths.attack-paths-findings.yaml" file for "/attack-paths/findings" endpoint - Resolves BED-9834
merging with main
merge with main
- Adds corresponding UTs
merging with main
merging with main
merge with main
merge with main
merge with main
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documents
PATCH /api/v2/collie-job-secrets/:idin the OpenAPI source and generated specification.Defines optional
name,external_key_id, and write-onlyvaluefields, validation requirements, the metadata response, and error statuses.Merge Danger
Door: Two-way. Documentation can be reverted.
Blast Radius: Documentation. The runtime endpoint is implemented in a separate BHE PR. The contract documents unchanged job snapshots and the possibility that a provider write succeeds before a database commit fails.
Motivation and Context
Resolves BED-10419
Keeps the API specification aligned with the credential update endpoint. Companion implementation: BHE #2398. Merge this PR first, then update the BHE submodule pointer to its merged revision.
How Has This Been Tested?
After: Both the YAML source and generated JSON describe PATCH. The generated JSON parses and includes the expected request fields and response statuses.
Manual verification for reviewers: inspect
UpdateCollectorJobSecretin the source YAML and generated JSON; confirmvalueis write-only, at least one update field is required, additional fields are rejected, and the 200 response contains credential metadata only.No BHCE runtime code changed; the full BHCE test suite was not run.
Screenshots (optional):
Not applicable; OpenAPI documentation change.
Types of changes
Checklist: