Repository navigation
fix: Synchronize environment access on SSO role updates BED-9921 - #3656
Draft
justin-prime1 wants to merge 2 commits into
Draft
justin-prime1 wants to merge 2 commits into
justin-prime1 wants to merge 2 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recalculate the ETAC all-environments flag when SAML/OIDC provisioning changes a user's role, using the same rules as account creation. Preserve manual access when the role is unchanged or role provisioning is disabled.
Sister PR: https://github.com/SpecterOps/bloodhound-enterprise/pull/2400
Motivation and Context
Resolves BED-9921
Previously, promoted users could remain restricted and demoted users could retain broader environment access.
How Has This Been Tested?
Passed:
go test ./cmd/api/src/api/v2/auth -count=1Rollback: revert the code; persisted access flags require review.
Screenshots (optional):
N/A — backend change.
Types of changes
Checklist: