Skip to content

fix: preserve managed native editing and save custody - #1

Open
Srbino wants to merge 9 commits into
fix/native-read-only-qualifiedfrom
fix/managed-native-file-io
Open

Srbino wants to merge 9 commits into
fix/native-read-only-qualifiedfrom
fix/managed-native-file-io

Conversation

@Srbino

@Srbino Srbino commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Private-port managed embedding currently loses its bound document on File Open and confuses native storage with downloads. Imports now replace content under the existing document ID with undo/redo and a retained host-confirmed saved baseline. Unsaved imports refuse until a matching save acknowledgement arrives. Native Save from the title bar, keyboard and File menu requests host storage; explicit XLSX/PDF downloads never acknowledge storage.

The native UI preserves address-entry and initial typing bursts across coalesced input frames. A later Ctrl+S no longer discards earlier text in the same frame; cell editors apply the text before requesting Save, while invalid and read-only drafts remain held. Explicit Name Box navigation settles valid writable drafts, retains refused drafts, and leaves read-only parked drafts held. Managed UI omits host-owned New/Close/New Window, desktop AutoSave in both title bar and Options, read-dependent Paste, desktop update checks and desktop agent instructions. About retains information and credits without blocked popup links. External cell links remain stored/exported while their unsupported popup action is refused; internal links still navigate. Print retains its preview and exports a PDF copy. File Info describes host custody instead of inferring unsaved state from an absent filesystem path.

Repeated exports retain at most 256 request aliases only for the exact same document, opaque revision and immutable workbook Arc. A later identical capture therefore cannot invalidate an in-flight durable save proof. Different snapshots replace the pending baseline, foreign identities are refused, and acknowledging an older baseline never cleans later edits. Native host custody remains opt-in; standalone XLSX save routing remains available.

Stacked on the read-only source in upstream storytold#2788 (3d04d41). Final head: 687c58d. Independent source review covers each final delta.

Validation: actual failing engine/UI regressions before fixes; all ten cargo xtask ci steps pass with required frozen craft-fonts. Hashes captured before CI match the normally committed source bytes. Clean-HEAD CLI/WASM builds use the installable server manifest format and run through the actual Go editor-origin/native credential gates. Current 687c assets pass seven actual Go-gated cases: core product regression, Name Box input, read-only/held drafts, XLSX IO, original 60ms typing, immediate Ctrl+S after 0ms/60ms typing with full native content and exact ACK, and File Info after ACK. Deterministic raw-event tests cover cold/warm editors, coalesced/individual Text, refused/read-only drafts and shortcut echo; twelve existing shortcut cases also pass. Unchanged PDF, managed capability visibility, identical-export ACK custody, external/internal links and Backstage Save implementation retain explicitly prior immutable 7bd8/3822 evidence; those are not claimed as reruns on 687c. Additional real UI Title/comment/password-protection mutations survived exact ACK and fresh iframe reopen; CSV import also passed.

The product sweep lists specific exercised actions and opens all nine main tabs. It does not establish that every nested visible control works. Crewship leases, server save admission and agent HTTP integration are outside this upstream change. Structure/sheet protection is distinct from encrypted-file authoring.

@Srbino Srbino changed the title fix: preserve managed native document identity and save custody fix: preserve managed native editing and save custody Oct 28, 2026
@Srbino
Srbino marked this pull request as ready for review October 28, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant