Repository navigation
L10n: second round of review fixes (Spanish names, Ukrainian booleans, (€-5)) - #24
Merged
Merged
Conversation
…that reads back as another function CodeRabbit review of storytold#2820: COVARIANCE.P is COVARIANZA.P in Spanish Excel. A function given by name as an argument (MAP({1;4};RAIZ)) is translated like a call, unless a binding, a defined name or a boolean owns the name. When a binding shadows CONV.DECIMAL, the English DECIMAL would read back as FIXED, so such a formula is not shown in Spanish rather than shown wrong. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147pTEvxKfh4hi3my35jsAg
…arentheses CodeRabbit review of storytold#2822: Ukrainian entry reads ІСТИНА and ХИБНІСТЬ in any case (full Unicode upper-casing), and (€-5), like ($-5), is text, both when typed and in the Number Stored as Text check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147pTEvxKfh4hi3my35jsAg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the fixes made for the second CodeRabbit round on the upstream PRs (storytold#2820, storytold#2822) to the fork.
Summary
MAP({1;4};RAIZ)) is translated both ways, unless a binding, a defined name or a boolean owns the name.(€-5), like($-5), is text, both when typed and in the Number Stored as Text check.Tests
New tests in
crates/formula/tests/it/spanish_input.rsandcrates/core/tests/regional_input.rs; each fails with its fix reverted. core, formula and engine suites green; ui-egui green except the two known container-only failures (no ẞ font, same on main). fmt and clippy -D warnings clean.Generated by Claude Code