Skip to content

L10n: second round of review fixes (Spanish names, Ukrainian booleans, (€-5)) - #24

Merged
StDenis1980 merged 2 commits into
mainfrom
claude/project-thread-olo23h
Oct 29, 2026
Merged

StDenis1980 merged 2 commits into
mainfrom
claude/project-thread-olo23h

Conversation

@StDenis1980

Copy link
Copy Markdown
Owner

Ports the fixes made for the second CodeRabbit round on the upstream PRs (storytold#2820, storytold#2822) to the fork.

Summary

  • COVARIANCE.P is COVARIANZA.P in Spanish.
  • A function given by name as a call argument (MAP({1;4};RAIZ)) is translated both ways, unless a binding, a defined name or a boolean owns the name.
  • When a binding shadows CONV.DECIMAL, the formula is not shown in Spanish: the English DECIMAL would read back as FIXED.
  • uk-UA entry reads ІСТИНА / ХИБНІСТЬ in any case.
  • (€-5), like ($-5), is text, both when typed and in the Number Stored as Text check.

Tests

New tests in crates/formula/tests/it/spanish_input.rs and crates/core/tests/regional_input.rs; each fails with its fix reverted. core, formula and engine suites green; ui-egui green except the two known container-only failures (no ẞ font, same on main). fmt and clippy -D warnings clean.


Generated by Claude Code

…that reads back as another function

CodeRabbit review of storytold#2820: COVARIANCE.P is COVARIANZA.P in Spanish Excel.
A function given by name as an argument (MAP({1;4};RAIZ)) is translated
like a call, unless a binding, a defined name or a boolean owns the name.
When a binding shadows CONV.DECIMAL, the English DECIMAL would read back as
FIXED, so such a formula is not shown in Spanish rather than shown wrong.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0147pTEvxKfh4hi3my35jsAg
…arentheses

CodeRabbit review of storytold#2822: Ukrainian entry reads ІСТИНА and ХИБНІСТЬ in
any case (full Unicode upper-casing), and (€-5), like ($-5), is text, both
when typed and in the Number Stored as Text check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0147pTEvxKfh4hi3my35jsAg
@StDenis1980
StDenis1980 merged commit f5e9621 into main Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants