Repository navigation
L10n: third round of review fixes (function-name positions, CSV en-US, uk-UA decimals, per-app region) - #25
Merged
Conversation
…ected Review of storytold#2820 (CodeRabbit, Harrison-Booth): SUMA(RAIZ;1) became SUM(SQRT,1). A bare name is now translated only in the positions the evaluator reads as a function (the LAMBDA of MAP, REDUCE, SCAN, BYROW, BYCOL and MAKEARRAY, the aggregation of GROUPBY and PIVOTBY); every other argument, and LAMBDA invocation arguments, keep the name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147pTEvxKfh4hi3my35jsAg
…per app frame Review of storytold#2822 (CodeRabbit, Harrison-Booth): - CSV import reads values with parse_file_input, without the euro and hryvnia forms only typed entry reads. - In uk-UA, 1 234.5 mixes two conventions and stays text rather than being read as 1234.5. - SheetApp::logic and ::ui each run in the app's region and put the thread's region back afterwards, so two apps sharing a thread never show values in each other's region (interleaving regression test). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147pTEvxKfh4hi3my35jsAg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the third round of review fixes from the upstream PRs (storytold#2820 and storytold#2822) into the fork.
Summary
SUMA(RAIZ;1)now keepsRAIZas a name.parse_file_input. It does not accept the euro and hryvnia forms (€5,12,50 €,250 грн), which only typed entry reads.1 234.5stays text. Before, it was read as 1234.5.SheetApp::logicandSheetApp::uieach run in the app's own display region and restore the thread's region afterwards. Two apps on one thread no longer show values in each other's region.Tests
New tests are in
spanish_input.rs,regional_input.rs,csv_tests.rsand the ui-eguiformula_locale.rs; the last one interleaves frames from two apps on one thread. I checked that the function-name, CSV and two-app tests fail with their fix reverted. The uk-UA check was not run against a revert.Results: the core, formula, xlsx and engine suites are green, and fmt and clippy
-D warningsare clean. ui-egui has two failures, the same two that fail on main in this container because there is no ẞ font.Generated by Claude Code