Skip to content

Check for DOMContentLoaded in one place #122

Open

Description

@psimonyi

Right now there are several $(document).ready() things when nothing in the module actually works without the DOM. We should just wait for the DOM in main.js or something before letting those modules do anything instead of checking within each one.

Activity

  1. spratt commented on Apr 4, 2013

    @spratt
    Member

    Nothing in the module works without the DOM?

  2. psimonyi commented on Apr 4, 2013

    @psimonyi
    ContributorAuthor

    There are several. tutorial, for example.

  3. spratt commented on Apr 4, 2013

    @spratt
    Member

    I feel like I'm missing the context for that reply.

  4. psimonyi commented on Apr 4, 2013

    @psimonyi
    ContributorAuthor

    login.js also makes no sense without a DOM; all that is useful before the DOM is loaded is downloading the JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions