Repository navigation
Conversation
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
input_audio_buffer.appendcarries headerless PCM16, and the server always reads it at the model's sample rate (16 kHz for Voxtral). A client that setssession.audio.input.format.rateto something else, for example the 24 kHz that OpenAI Realtime clients default to, currently getssession.updatedback and then a transcript of audio played at the wrong speed, with no error.With this change, a
session.updatewhoseaudio.input.format.rateis not an integer equal to the model rate gets anerror(audio.input.format.rate must be 16000), and the session keeps its previous config. An update that does not set a rate is unchanged. The check reads the JSON value directly, becausejson_value()would fall back to the default for a string like"24000"and truncate a fraction.The README also drops the stale note that held-back words are attributed to the next item, which ggml-org#30994 fixed.
Additional information
test_realtime_control_eventsgains three updates: 24000, "24000" (a string) and 16000.For scale, on an RTX 3090, 24 kHz audio read as 16 kHz gave 41% WER unpaced against about 22% at 16 kHz.
Requirements
🤖 Generated with Claude Code