fix: add publishConfig and bump version for npm release - #29
Merged
Conversation
- publishConfig.access public fixes scoped package publish failure - version bump 0.0.4 → 0.0.5 (0.0.4 already published to npm)
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Member
Author
|
I told AI this was probably the case. It verified it. This is the PR it came up with. I've reviewed it. Looks right. |
wesleyboar
added a commit
that referenced
this pull request
Jul 13, 2026
## Overview Adds `workflow_dispatch` to the npm publish workflow so it can be triggered manually from the GitHub Actions UI, without needing to create a release. > [!IMPORTANT] > We would only manually run if it fails and we have a fix after GitHub release, because GitHub release automatically triggers this job. ## Related - requires #29 ## Changes - **updated** `.github/workflows/npm-publish.yml` — added `workflow_dispatch` trigger ## Testing 1. Merge this PR. 2. Go to [Actions → Node.js Package](https://github.com/TACC/Core-Components/actions/workflows/npm-publish.yml). 3. Click **Run workflow** and confirm it appears as an option. ## UI N/A
This was referenced Jul 13, 2026
wesleyboar
added a commit
that referenced
this pull request
Jul 13, 2026
## Overview Switch npm publishing from a token (`NPM_TOKEN`) to Trusted Publisher (OIDC), so CI authenticates to npm without a stored secret. This fixes the publish failure, which was a token auth error. ## Related - Mirrors the Trusted Publisher setup used for `@tacc/html-filter-sort` - Follows #31 and #29 ## Changes - **changed** npm auth to Trusted Publisher (OIDC) - **removed** the `NPM_TOKEN` secret dependency - **merged** the build and publish jobs into one - **updated** workflow actions to `@v6` and Node to `24` ## Testing > [!TIP] > [Successfully tested.](https://github.com/TACC/Core-Components/actions/runs/29286986062/job/86941791315) 1. On npmjs.com, register the Trusted Publisher for `@tacc/core-components`: owner `TACC`, repo `Core-Components`, workflow `npm-publish.yml`. 2. Publish via a release or `workflow_dispatch`, and confirm it succeeds without a token. --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
wesleyboar
added a commit
that referenced
this pull request
Jul 13, 2026
## Overview
Adds contributor documentation and git conventions in the style of
Core-CMS and Core-Styles.
> [!WARNING]
> Pending successful release test.
## Related
- `PUBLISHING.md` tested via:
- #29
- #_LINK_TO_SECOND_FIX_
- _LINK_TO_SUCCESSFUL_RUN_
## Changes
- **added** `CONTRIBUTING.md` (which points to PUBLISHING)
- **added** `PUBLISHING.md`
- **added** `.gitmessage`
- **updated** `.github/pull_request_template.md`
## Testing & UI
-
[`CONTRIBUTING.md`](https://github.com/TACC/Core-Components/blob/docs/contributing-publishing/CONTRIBUTING.md)
-
[`PUBLISHING.md`](https://github.com/TACC/Core-Components/blob/docs/contributing-publishing/PUBLISHING.md)
-
[`.gitmessage`](https://github.com/TACC/Core-Components/blob/docs/contributing-publishing/.gitmessage)
-
[`.github/pull_request_template.md`](https://github.com/TACC/Core-Components/blob/docs/contributing-publishing/.github/pull_request_template.md?plain=1)
wesleyboar
added a commit
that referenced
this pull request
Aug 27, 2026
Updates the uuid dependency range from "^8 || ^9" to "^11.1.1", which includes a fix for GHSA-w5hq-g745-h8pq (missing buffer bounds check in v3/v5/v6 when buf is provided). Only v4() is used in this package, so the API is unaffected. Also regenerates package-lock.json, which had drifted out of sync with package.json since #28/#29 (storybook deps moved to devDependencies, version bumped to 0.0.5, but the lockfile was never updated to match).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Two bugs caused the v0.0.4 release CI run to fail:
--access restricted, so I addpublishConfiginpackage.jsonasaccess: publicto letnpm publishsucceeds without extra flags.0.0.4was already published to npm, so publishing again would fail with a 403.Related
Changes
publishConfig.access: "public"topackage.json0.0.4→0.0.5Testing
v0.0.5(if not already present).@tacc/core-components@0.0.5appears on npm.UI
N/A